[GitHub] trafficserver pull request: Removed hard-coded formats; now config...

2015-06-17 Thread cjqian
Github user cjqian closed the pull request at: https://github.com/apache/trafficserver/pull/225 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: Removed hard-coded formats; now config...

2015-06-16 Thread PSUdaemon
Github user PSUdaemon commented on the pull request: https://github.com/apache/trafficserver/pull/225#issuecomment-112621262 Sorry, I forgot to add the "this closes" part. @cjqian, can you close this please? Thanks. --- If your project is set up for it, you can reply to this

[GitHub] trafficserver pull request: Removed hard-coded formats; now config...

2015-06-15 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/225#issuecomment-112213434 Couple of nit-picks: 1) The documentations is slightly confusing now. What's a "variable" in the XML context? What we should document is that all log format

[GitHub] trafficserver pull request: Removed hard-coded formats; now config...

2015-06-12 Thread cjqian
GitHub user cjqian opened a pull request: https://github.com/apache/trafficserver/pull/225 Removed hard-coded formats; now configurable in log .xml. 1) Removed hard-coded proxy.config.log.[format].[variable] from records.config and references in code. 2) Added configurable featu