Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/225#issuecomment-112213434
Couple of nit-picks:
1) The documentations is slightly confusing now. What's a "variable" in the
XML context? What we should document is that all log formats are now configured
and enabled via logs_xml.config. We provide four "example" log formats, which
match with the previous configurations. In addition, we still create the
default squid log object as well (which will be used if logging is enabled).
Users are at liberty to use zero, one or any number of the log formats. They
can create any number of log objects, all via the XML config.
2) This doesn't make a whole lot of sense:
+ #define make_format(is_ascii) ((is_ascii) ? LOG_FILE_ASCII :
LOG_FILE_BINARY)
+ #undef make_format
Presumably we don't need these any more?
3) I sort of figured that all of proxy/logging/LogPredefined.cc could be
nuked ? I.e. git rm the .cc and .h file, and all other places using it?
(Although, I haven't quite looked at that code in details).
All in all, this is nice, it'll make things a lot clearer and nicer to
configure going forward.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
