[GitHub] trafficserver pull request: TS-3478: Indexing header representatio...

2016-01-07 Thread syucream
Github user syucream commented on the pull request: https://github.com/apache/trafficserver/pull/391#issuecomment-169910983 @masaori335 @maskit please take another look --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] trafficserver pull request: TS-3478: Indexing header representatio...

2016-01-05 Thread syucream
Github user syucream commented on the pull request: https://github.com/apache/trafficserver/pull/391#issuecomment-168982622 @maskit I concern about Http2DynamicTable too. I'll add IndexingTable layer and separate Http2DynamicTable and static table. --- If your project is set u

[GitHub] trafficserver pull request: TS-3478: Indexing header representatio...

2016-01-05 Thread syucream
Github user syucream commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/391#discussion_r48837742 --- Diff: proxy/http2/HPACK.h --- @@ -153,9 +165,9 @@ int64_t decode_string(Arena &arena, char **str, uint32_t &str_length, co

[GitHub] trafficserver pull request: TS-3478: Indexing header representatio...

2015-12-20 Thread syucream
GitHub user syucream opened a pull request: https://github.com/apache/trafficserver/pull/391 TS-3478: Indexing header representations on HPACK encoder https://issues.apache.org/jira/browse/TS-3478 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] trafficserver pull request: doc: fix links of admin-guide

2015-11-28 Thread syucream
GitHub user syucream opened a pull request: https://github.com/apache/trafficserver/pull/352 doc: fix links of admin-guide You can merge this pull request into a Git repository by running: $ git pull https://github.com/syucream/trafficserver doc Alternatively you can review

[GitHub] trafficserver pull request: TS-3998: Disable h2c upgrades

2015-11-15 Thread syucream
GitHub user syucream opened a pull request: https://github.com/apache/trafficserver/pull/338 TS-3998: Disable h2c upgrades https://issues.apache.org/jira/browse/TS-3998 Reject h2c token for now. after applying this patch, h2c upgrading is handled as Invalid Upgrade Request

[GitHub] trafficserver pull request: TS-3782: Add H2 exceptional test cases

2015-09-16 Thread syucream
Github user syucream commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/277#discussion_r39702473 --- Diff: ci/tsqa/tests/test_http2_spec.py --- @@ -0,0 +1,114 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] trafficserver pull request: TS-3782: Add H2 exceptional test cases

2015-08-12 Thread syucream
Github user syucream commented on the pull request: https://github.com/apache/trafficserver/pull/277#issuecomment-130503083 @jacksontj Hi, I fixed my patch for tsqa test cases. please take another look. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver pull request: TS-3782: Add H2 exceptional test cases

2015-08-12 Thread syucream
GitHub user syucream opened a pull request: https://github.com/apache/trafficserver/pull/277 TS-3782: Add H2 exceptional test cases HTTP/2 exceptional test cases. It has already been fixed based on comments on [TS-3782](https://issues.apache.org/jira/browse/TS-3782) You can merge

[GitHub] trafficserver pull request: Fix the automake rule to satisfy heade...

2014-05-21 Thread syucream
Github user syucream commented on the pull request: https://github.com/apache/trafficserver/pull/80#issuecomment-43770175 Thank you for your review. I agree with your opinion and want to continue discussion to solve it on JIRA. so I close this pull-request for now. --- If your

[GitHub] trafficserver pull request: Fix the automake rule to satisfy heade...

2014-05-21 Thread syucream
Github user syucream closed the pull request at: https://github.com/apache/trafficserver/pull/80 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver pull request: Fix the automake rule to satisfy heade...

2014-05-10 Thread syucream
GitHub user syucream opened a pull request: https://github.com/apache/trafficserver/pull/80 Fix the automake rule to satisfy header requirements of atscppapi When I built my plugin outside of trafficserver source tree, I found build failure related to header requirements of