GitHub user shukitchan opened a pull request:
https://github.com/apache/trafficserver/pull/779
TS-4627: support TSRemapOSResponse in ts_lua
@jpeach pls take a look. Thanks.
I want to add enhancement to ts_lua so I can write script to take advantage
of the TSRemapOSResponse
Github user shukitchan commented on the issue:
https://github.com/apache/trafficserver/pull/776
@bgaff i know you may have a plugin ready as well.
Anyway, we can either add our needs onto your code. Or you can start with
reviewing and merging this PR and add on your requirements
Github user shukitchan commented on the issue:
https://github.com/apache/trafficserver/pull/744
Yeah. I just filed TS-4592 for myself
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user shukitchan commented on the issue:
https://github.com/apache/trafficserver/pull/744
ð
I will also need to support these in lua api
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user shukitchan closed the pull request at:
https://github.com/apache/trafficserver/pull/697
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user shukitchan commented on the issue:
https://github.com/apache/trafficserver/pull/719
yeah. just checked. it is only built at "make check" time. merging now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
Github user shukitchan closed the pull request at:
https://github.com/apache/trafficserver/pull/719
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user shukitchan opened a pull request:
https://github.com/apache/trafficserver/pull/719
TS-4551: remove OS_TYPE restriction in gunzip and add unit test
@zwoop can you please take a quick look and review? Thanks.
You can merge this pull request into a Git repository by
Github user shukitchan commented on the issue:
https://github.com/apache/trafficserver/pull/697
@jpeach , I just updated according to your comments. pls take a look.
once i get a thumbs up, will definitely squash the commits before merge
---
If your project is set up for it, you
GitHub user shukitchan opened a pull request:
https://github.com/apache/trafficserver/pull/697
TS-4510: support multiple header with same name
Currently ts_lua plugin does not handle well when the request or response
contains multiple header with the same name.
We either
Github user shukitchan closed the pull request at:
https://github.com/apache/trafficserver/pull/685
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user shukitchan closed the pull request at:
https://github.com/apache/trafficserver/pull/681
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user shukitchan commented on the issue:
https://github.com/apache/trafficserver/pull/681
I am now thinking using luacrypto is a better choice. Closing for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user shukitchan commented on the issue:
https://github.com/apache/trafficserver/pull/685
@sudheerv I made the change already. Please take a look.
will definitely squash into a single commit before merge. Thanks.
---
If your project is set up for it, you can reply to this
Github user shukitchan commented on the issue:
https://github.com/apache/trafficserver/pull/685
The added call to ts_lua_fetch_multi_cleanup() is protected with a mutex.
However, i think this function is called in another place and i need to
protect that as well.
---
If your
GitHub user shukitchan opened a pull request:
https://github.com/apache/trafficserver/pull/685
TS-4497: fix fetch api to release async item sooner
@sudheerv this is what we have been discussing for a while. With TS-3777,
the ts.fetch() of ts_lua is no longer working fine. I finally
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/681
These are just convenient and frequently used so we pulled them in instead
of telling user to use external library.
---
If your project is set up for it, you can reply to this
Github user shukitchan commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/681#discussion_r65225001
--- Diff: doc/admin-guide/plugins/ts_lua.en.rst ---
@@ -2107,6 +2107,85 @@ Here is an example:
bin = ts.sha1_bin(uri)
end
Github user shukitchan commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/681#discussion_r65224725
--- Diff: plugins/experimental/ts_lua/ts_lua_crypto.c ---
@@ -23,13 +23,21 @@
#define TS_LUA_MD5_DIGEST_LENGTH 16
#define
Github user shukitchan commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/681#discussion_r65224696
--- Diff: plugins/experimental/ts_lua/ts_lua_crypto.c ---
@@ -23,13 +23,21 @@
#define TS_LUA_MD5_DIGEST_LENGTH 16
#define
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/681
@jpeach this one should be simple. would appreciate if you can take a quick
look and see if there is any trivial thing i miss. thanks.
---
If your project is set up for it, you can
GitHub user shukitchan opened a pull request:
https://github.com/apache/trafficserver/pull/681
TS-4491: support sha256 and sha512 in ts_lua
support sha256 and sha512 in ts_lua plugin
You can merge this pull request into a Git repository by running:
$ git pull https
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/624
also is there a jira ticket for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user shukitchan commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/624#discussion_r62701424
--- Diff: proxy/api/ts/ts.h ---
@@ -2328,6 +2328,7 @@ tsapi TSReturnCode
TSHttpTxnCacheLookupUrlGet(TSHttpTxn txnp, TSMBuffer bufp, TS
tsapi
Github user shukitchan closed the pull request at:
https://github.com/apache/trafficserver/pull/503
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/503#issuecomment-216434585
test added. @jpeach pls take a look.
again i will squash the commits before merging. Thanks.
---
If your project is set up for it, you can reply to this
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/503#issuecomment-216400714
I can now reproduce the problem and the fix is working.
@jpeach pls take a look as well
---
If your project is set up for it, you can reply to this email
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/607#issuecomment-215973625
it looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/607#issuecomment-215972733
It looks fine. But I think we dropped 32 bit support already? so i doubt
this is the only problem?
@zwoop
---
If your project is set up for it, you can
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/503#issuecomment-210846959
@jpeach patch is updated. please take a look.
I will test more tonight and if it is good, i will squash the commit before
merge.
---
If your project is
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/503#issuecomment-210377071
@jpeach i thought that it was safe, too. Till i see the core dump reported
in the jira. i am just being extra safe in this PR. What do you think?
---
If your
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/543#issuecomment-210329030
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user shukitchan closed the pull request at:
https://github.com/apache/trafficserver/pull/543
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/408#issuecomment-207840880
yeah. let's write one for the webp_transform plugin and see.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/543#issuecomment-203650097
thanks. will try to find some time to review and merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user shukitchan opened a pull request:
https://github.com/apache/trafficserver/pull/503
TS-4240: fix coredump issues with esi plugin
@jpeach @zwoop pls take a look and review
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/499#issuecomment-188981191
don't worry about merging. i can do that myself later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
GitHub user shukitchan opened a pull request:
https://github.com/apache/trafficserver/pull/499
TS-4230: support matrix style parameter in ts_lua plugin
@jpeach pls take a look. hopefully it is a simple quick one.
You can merge this pull request into a Git repository by running
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/494#issuecomment-187394404
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/494#issuecomment-187297552
Yup, just as James said. enable-cppapi check is needed as well.
Also thanks for the fix.
---
If your project is set up for it, you can reply to this
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/393#issuecomment-186080875
I am :+1: as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user shukitchan commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/393#discussion_r53426210
--- Diff: doc/admin-guide/plugins/webp_transform.en.rst ---
@@ -0,0 +1,38 @@
+.. _webp_transform:
+
+WebpTransform Plugin
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/455#issuecomment-185373900
thanks... let me merge it tonight.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/455#issuecomment-180906411
I think we should use TSDebug as well.
The change should be "backwards compatible".
---
If your project is set up for it, you can rep
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/455#issuecomment-180587604
looks good now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/455#issuecomment-180535806
@jpeach , can you take a look as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user shukitchan commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/455#discussion_r52065719
--- Diff: plugins/experimental/s3_auth/s3_auth.cc ---
@@ -346,26 +349,48 @@ S3Request::authorize(S3Config *s3)
// If the configuration is a
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/451#issuecomment-180135445
TS_LUA_REQUEST_TRANSFORM - it only worked on request body. That means for
POST method. Can you try it out and see if you see the problem mentioned in
TS-2825
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/408#issuecomment-180054661
@bgaff. you have a chance to look at this yet?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/451#issuecomment-179714610
looks good. just to re-iterate and confirm
TS_LUA_REQUEST_TRANSFORM is not working because of
https://issues.apache.org/jira/browse/TS-2825 and
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/442#issuecomment-179556276
I think we can close this now. the changes are merged. here are the commits
17cc1561b25bb4f1be9834d9f7e94dcdeef868bf
GitHub user shukitchan opened a pull request:
https://github.com/apache/trafficserver/pull/441
TS-4158: release mlocs correctly
@zwoop , pls take a look.
i tested it briefly and it is fine.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/422#issuecomment-17376
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/420#issuecomment-173363560
before i merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/420#issuecomment-173363535
@jpeach , any other advice?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/420#issuecomment-172630184
A couple of functions will result in LUA_YIELD, such as sleep() and
fetch(). And they all have schedule event to happen through their handler and
those
Github user shukitchan commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/422#discussion_r49959828
--- Diff: lib/bindings/repl.cc ---
@@ -0,0 +1,60 @@
+/** @file
+ *
+ * Lua bindings REPL.
+ *
+ * @section license License
Github user shukitchan commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/422#discussion_r49959792
--- Diff: cmd/traffic_manager/metrics.cc ---
@@ -0,0 +1,385 @@
+/** @file
+ *
+ * Traffic Manager custom metrics
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/420#issuecomment-172416165
I just updated the pull request. @jpeach, pls take a look. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/420#issuecomment-172102643
nice catch on both cases. let me update the PR over the weekend after some
tests on the new code.
---
If your project is set up for it, you can reply to this
Github user shukitchan commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/422#discussion_r49809962
--- Diff: lib/bindings/repl.cc ---
@@ -0,0 +1,60 @@
+/** @file
+ *
+ * Lua bindings REPL.
+ *
+ * @section license License
Github user shukitchan commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/422#discussion_r49808951
--- Diff: cmd/traffic_manager/metrics.cc ---
@@ -0,0 +1,385 @@
+/** @file
+ *
+ * Traffic Manager custom metrics
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/422#issuecomment-171777895
should we add something here in these 2 places ?
https://docs.trafficserver.apache.org/en/latest/admin-guide/files/index.en.html
https
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/422#issuecomment-171767764
awesome. will take some time to review it today/tomorrow.
Would be nice if you can take some time to write the doc to accompany this
feature. thanks
GitHub user shukitchan opened a pull request:
https://github.com/apache/trafficserver/pull/420
[TS-4129] Support TSContSchedule in ts_lua plugin
@jpeach , pls help to take a look.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user shukitchan reopened a pull request:
https://github.com/apache/trafficserver/pull/403
TS-4109: fix ts.debug/ts.error problem with long string
fix ts.debug/ts.error problem with long string in ts_lua plugin
You can merge this pull request into a Git repository by running
Github user shukitchan closed the pull request at:
https://github.com/apache/trafficserver/pull/403
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/403#issuecomment-168995777
This is closed by 874016357466879496ca08fa20960de1591be915
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/394#issuecomment-168899579
ha. my bad english
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/394#issuecomment-168898944
@jpeach
Before the change the lua number is always an integer (e.g. 1451970346).
Now after the change the lua number will contain the fraction of the
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/394#issuecomment-168871196
@jpeach
Yes. the time is still in seconds. But instead of returning an integer all
the time, it is now a "lua_Number", which is like
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/394#issuecomment-168799362
@jpeach , can you take a quick look on this as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/403#issuecomment-168776257
so given that, is this one ok?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/403#issuecomment-168776170
see https://issues.apache.org/jira/browse/TS-4110
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/403#issuecomment-168775306
That's correct. I think we should keep this fix and have another jira for
that problem in TSDebug.
---
If your project is set up for it, you can rep
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/403#issuecomment-168601285
here is a sample stack trace -
Core was generated by `/home/y/bin/traffic_server -M --httpport
80:fd=8,443:fd=9:ssl'.
Program terminated with sign
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/403#issuecomment-168368324
@zwoop , pls take a look. thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user shukitchan opened a pull request:
https://github.com/apache/trafficserver/pull/403
TS-4109: fix ts.debug/ts.error problem with long string
fix ts.debug/ts.error problem with long string in ts_lua plugin
You can merge this pull request into a Git repository by running
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/393#issuecomment-167850957
seems good. would be great if you can run clang-format on this
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/393#issuecomment-167030403
Something like this -
https://github.com/apache/trafficserver/blob/master/doc/admin-guide/plugins/esi.en.rst
And it should be refered in here -
https
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/393#issuecomment-167015374
Also we should write a document if we are putting this into experimental
plugin directory
---
If your project is set up for it, you can reply to this email
Github user shukitchan commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/393#discussion_r48389749
--- Diff: lib/atscppapi/examples/webp_transform/README ---
@@ -0,0 +1,6 @@
+onverting jpeg and png to webp
--- End diff --
small
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/393#issuecomment-166739688
2 more comments
1) Please add an ASF license blurb to all new files
2) you can also run clang-format to beautify your code a bit as well. Check
GitHub user shukitchan opened a pull request:
https://github.com/apache/trafficserver/pull/394
TS-4096: ts.now() should return subsecond info for ts_lua plugin
@bgaff and @zwoop , pls review
You can merge this pull request into a Git repository by running:
$ git pull https
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/393#issuecomment-166470972
need some time to go through the code. But @bgaff, any objection to put it
in experimental plugin instead of example/ ?
---
If your project is set up for it
GitHub user shukitchan opened a pull request:
https://github.com/apache/trafficserver/pull/392
TS-4083: CID 1343347: Fix unchecked return value
@zwoop pls review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shukitchan
Github user shukitchan commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/385#discussion_r47969659
--- Diff:
doc/developer-guide/plugins/hooks-and-transactions/http-transactions.en.rst ---
@@ -179,6 +179,8 @@ The HTTP transaction functions are
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/378#issuecomment-164923218
also is this for TS-4079 instead of TS-4091?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/378#issuecomment-164920093
cool. will do. can you update the doc as well?
it is here -
https://github.com/apache/trafficserver/blob/master/doc/admin-guide/plugins/esi.en.rst
---
If
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/368#issuecomment-162840282
thanks for the contribution.
you have a jira created already? Also would you please also provide
documentation on the plugin?
I believe you can add
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/357#issuecomment-160906831
@bgaff - updated with using macro. thank.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/357#issuecomment-160890632
@jpeach , would really appreciate if you can take a look and review.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user shukitchan opened a pull request:
https://github.com/apache/trafficserver/pull/357
TS-4045: ts_lua improvements
3 things to accomplish in this jira
1) add support for TSHttpTxnDebugSet
2) protect http context pointer access in api calls
3) fix a spelling
Github user shukitchan closed the pull request at:
https://github.com/apache/trafficserver/pull/11
GitHub user shukitchan opened a pull request:
https://github.com/apache/trafficserver/pull/11
TS 2116 and TS 2114
TS 2116 - Make buffer_upload plugin build correctly
TS 2114 - remove true/false definition
You can merge this pull request into a Git repository by running
Github user shukitchan closed the pull request at:
https://github.com/apache/trafficserver/pull/10
GitHub user shukitchan opened a pull request:
https://github.com/apache/trafficserver/pull/10
TS 2116
Making buffer_upload plugin build correctly
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shukitchan/trafficserver TS-2116
Github user shukitchan closed the pull request at:
https://github.com/apache/trafficserver/pull/3
Github user shukitchan closed the pull request at:
https://github.com/apache/trafficserver/pull/3
Github user shukitchan closed the pull request at:
https://github.com/apache/trafficserver/pull/5
1 - 100 of 105 matches
Mail list logo
