[GitHub] trafficserver pull request: TS-4387 Add enforcement of TSCont havi...

2016-04-27 Thread shenzhang920
Github user shenzhang920 commented on the pull request: https://github.com/apache/trafficserver/pull/603#issuecomment-215265241 Description: When calling TSContSchedule()/TSContScheduleEvery(), the passed in parameter TSCont have to have MUTEX; otherwise if we call

[GitHub] trafficserver pull request: TS-4387 Add enforement of TSCont havin...

2016-04-26 Thread shenzhang920
GitHub user shenzhang920 opened a pull request: https://github.com/apache/trafficserver/pull/603 TS-4387 Add enforement of TSCont having MUTEX for TSContSchedule() https://issues.apache.org/jira/browse/TS-4387 You can merge this pull request into a Git repository by running

[GitHub] trafficserver pull request: TS-4387 Add enforement of TSCont havin...

2016-04-26 Thread shenzhang920
Github user shenzhang920 closed the pull request at: https://github.com/apache/trafficserver/pull/602 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver pull request: TS-4387 Add enforement of TSCont havin...

2016-04-26 Thread shenzhang920
GitHub user shenzhang920 opened a pull request: https://github.com/apache/trafficserver/pull/602 TS-4387 Add enforement of TSCont having MUTEX for TSContSchedule() https://issues.apache.org/jira/browse/TS-4387 You can merge this pull request into a Git repository by running

[GitHub] trafficserver pull request: TS-4312 Add config to strictly parse U...

2016-04-15 Thread shenzhang920
Github user shenzhang920 commented on the pull request: https://github.com/apache/trafficserver/pull/574#issuecomment-210592225 @jpeach @bgaff I squash my previous 4 commit into 1 commit and re-submit the pull request. I also modify the commit message to be concise. --- If your

[GitHub] trafficserver pull request: TS-4312 Add config to strictly parse U...

2016-04-15 Thread shenzhang920
GitHub user shenzhang920 opened a pull request: https://github.com/apache/trafficserver/pull/574 TS-4312 Add config to strictly parse URL according to RFC 3986 Add "proxy.config.http.strict_uri_parsing" in records.config to enable Traffic Server to return a 400 Bad

[GitHub] trafficserver pull request: TS-4312: Adding config to parse urls a...

2016-04-15 Thread shenzhang920
Github user shenzhang920 closed the pull request at: https://github.com/apache/trafficserver/pull/541 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver pull request: TS-4312: Adding config to parse urls a...

2016-04-13 Thread shenzhang920
Github user shenzhang920 commented on the pull request: https://github.com/apache/trafficserver/pull/541#issuecomment-209688326 @bgaff I search the code, no usage of is_wildmat()/is_wildmat_BIT. @jpeach any suggestion to the name "is_uri"? --- If your project is set up f

[GitHub] trafficserver pull request: TS-4312: Adding config to parse urls a...

2016-04-13 Thread shenzhang920
Github user shenzhang920 commented on the pull request: https://github.com/apache/trafficserver/pull/541#issuecomment-209686860 @jpeach I removed is_wildmat_BIT and added is_uri_BIT, please refer to commit d9d972d --- If your project is set up for it, you can reply to this email and

[GitHub] trafficserver pull request: TS-4312: Adding config to parse urls a...

2016-04-13 Thread shenzhang920
Github user shenzhang920 commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/541#discussion_r59641878 --- Diff: proxy/hdrs/URL.cc --- @@ -1158,9 +1158,51 @@ url_parse_scheme(HdrHeap *heap, URLImpl *url, const char **start, const char *en

[GitHub] trafficserver pull request: TS-4312: Adding config to parse urls a...

2016-04-13 Thread shenzhang920
Github user shenzhang920 commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/541#discussion_r59641766 --- Diff: mgmt/RecordsConfig.cc --- @@ -441,6 +441,8 @@ static const RecordElement RecordsConfig[] = , {RECT_CONFIG

[GitHub] trafficserver pull request: TS-4312: Adding config to parse urls a...

2016-04-04 Thread shenzhang920
Github user shenzhang920 commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/541#discussion_r58474731 --- Diff: proxy/hdrs/URL.cc --- @@ -1158,9 +1158,51 @@ url_parse_scheme(HdrHeap *heap, URLImpl *url, const char **start, const char *en

[GitHub] trafficserver pull request: TS-4312: Adding config to parse urls a...

2016-03-28 Thread shenzhang920
GitHub user shenzhang920 opened a pull request: https://github.com/apache/trafficserver/pull/541 TS-4312: Adding config to parse urls according to RFC Adding a config option "proxy.config.http.strict_uri_parsing" to sends http status code 400 back to client if the URL in