[GitHub] trafficserver issue #763: TS-4610: Fix HTTP and HTTP2 stats

2016-07-08 Thread masaori335
Github user masaori335 commented on the issue: https://github.com/apache/trafficserver/pull/763 @zwoop Looks good. We should land this to add a option to get metrics per protocol. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] trafficserver issue #790: TS-4472 Fixes http_current_active_client_connectio...

2016-07-08 Thread masaori335
Github user masaori335 commented on the issue: https://github.com/apache/trafficserver/pull/790 Looks good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] trafficserver issue #593: TS-4156: remove the traffic_sac, stand alone log c...

2016-06-29 Thread masaori335
Github user masaori335 commented on the issue: https://github.com/apache/trafficserver/pull/593 I updated PO files in 0ebfab01d909bcd0d99cd2f8fb2f816916bc80f3. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] trafficserver pull request #733: TS-4324: Allocate 16KB for DATA frame paylo...

2016-06-29 Thread masaori335
Github user masaori335 closed the pull request at: https://github.com/apache/trafficserver/pull/733 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver pull request #767: TS-4605: fix Coverity issue 1357058

2016-06-29 Thread masaori335
Github user masaori335 closed the pull request at: https://github.com/apache/trafficserver/pull/767 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver pull request #767: TS-4605: fix Coverity issue 1357058

2016-06-29 Thread masaori335
GitHub user masaori335 opened a pull request: https://github.com/apache/trafficserver/pull/767 TS-4605: fix Coverity issue 1357058 You can merge this pull request into a Git repository by running: $ git pull https://github.com/masaori335/trafficserver ts-4605 Alternatively

[GitHub] trafficserver issue #760: TS-4542: ASAN error with HTTP/2

2016-06-28 Thread masaori335
Github user masaori335 commented on the issue: https://github.com/apache/trafficserver/pull/760 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] trafficserver pull request #760: TS-4542: ASAN error with HTTP/2

2016-06-28 Thread masaori335
Github user masaori335 commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/760#discussion_r68878648 --- Diff: proxy/http2/Http2ConnectionState.cc --- @@ -1054,7 +1055,7 @@ Http2ConnectionState::send_a_data_frame(Http2Stream *stream, size_t

[GitHub] trafficserver pull request #760: TS-4542: ASAN error with HTTP/2

2016-06-28 Thread masaori335
Github user masaori335 commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/760#discussion_r68876890 --- Diff: proxy/http2/Http2ConnectionState.cc --- @@ -1054,7 +1055,7 @@ Http2ConnectionState::send_a_data_frame(Http2Stream *stream, size_t

[GitHub] trafficserver issue #593: TS-4156: remove the traffic_sac, stand alone log c...

2016-06-28 Thread masaori335
Github user masaori335 commented on the issue: https://github.com/apache/trafficserver/pull/593 @mingzym I'll update Japanese docs after this is merged if you want :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] trafficserver issue #749: TS-4506 Don't remove Expires/Last-Modifed on 304 r...

2016-06-28 Thread masaori335
Github user masaori335 commented on the issue: https://github.com/apache/trafficserver/pull/749 Do we need some changes in `HttpTransact::build_response()` too? https://github.com/apache/trafficserver/blob/master/proxy/http/HttpTransact.cc#L7945-L7975. --- If your project is

[GitHub] trafficserver pull request #749: TS-4506 Don't remove Expires/Last-Modifed o...

2016-06-27 Thread masaori335
Github user masaori335 commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/749#discussion_r68698335 --- Diff: proxy/http/HttpTransact.cc --- @@ -8199,13 +8199,15 @@ HttpTransact::build_error_response(State *s, HTTPStatus status_code, const char

[GitHub] trafficserver pull request #733: TS-4324: Allocate 16KB for DATA frame paylo...

2016-06-22 Thread masaori335
Github user masaori335 commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/733#discussion_r68175695 --- Diff: proxy/http2/Http2ClientSession.h --- @@ -94,63 +89,60 @@ class Http2Frame { this->ioblock = new_IOBufferBl

[GitHub] trafficserver pull request #733: TS-4324: Allocate 16KB for DATA frame paylo...

2016-06-22 Thread masaori335
GitHub user masaori335 opened a pull request: https://github.com/apache/trafficserver/pull/733 TS-4324: Allocate 16KB for DATA frame payload exactly - [TS-4324 comment-15313205](https://issues.apache.org/jira/browse/TS-4324?focusedCommentId=15313205&

[GitHub] trafficserver issue #708: TS-4537 Add `erase` method to PriorityQueue

2016-06-14 Thread masaori335
Github user masaori335 commented on the issue: https://github.com/apache/trafficserver/pull/708 Looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver pull request #708: TS-4537 Add `erase` method to PriorityQueue

2016-06-14 Thread masaori335
Github user masaori335 commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/708#discussion_r67087190 --- Diff: lib/ts/PriorityQueue.h --- @@ -115,6 +117,22 @@ PriorityQueue::pop() template void +PriorityQueue::erase

[GitHub] trafficserver pull request #686: TS-4496: Remove ink_code_md5_stringify

2016-06-08 Thread masaori335
Github user masaori335 closed the pull request at: https://github.com/apache/trafficserver/pull/686 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver issue #686: TS-4496: Remove ink_code_md5_stringify

2016-06-08 Thread masaori335
Github user masaori335 commented on the issue: https://github.com/apache/trafficserver/pull/686 FreeBSD build successful https://ci.trafficserver.apache.org/job/Github-FreeBSD/189/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] trafficserver pull request #686: TS-4496: Remove ink_code_md5_stringify

2016-06-02 Thread masaori335
Github user masaori335 commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/686#discussion_r65658324 --- Diff: mgmt/api/INKMgmtAPI.cc --- @@ -1865,8 +1865,7 @@ TSGetErrorMessage(TSMgmtError err_id) tsapi TSMgmtError TSEncryptPassword(char

[GitHub] trafficserver issue #693: TS-4324: Buffer responses to not send small size D...

2016-06-02 Thread masaori335
Github user masaori335 commented on the issue: https://github.com/apache/trafficserver/pull/693 OK, I'll close this and think this issue again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] trafficserver pull request #693: TS-4324: Buffer responses to not send small...

2016-06-02 Thread masaori335
Github user masaori335 closed the pull request at: https://github.com/apache/trafficserver/pull/693 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver issue #693: TS-4324: Buffer responses to not send small size D...

2016-06-02 Thread masaori335
Github user masaori335 commented on the issue: https://github.com/apache/trafficserver/pull/693 Yes, this could increase time to first byte. We should send the first chunk in anyway. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] trafficserver issue #693: TS-4324: Buffer responses to not send small size D...

2016-06-02 Thread masaori335
Github user masaori335 commented on the issue: https://github.com/apache/trafficserver/pull/693 ## before ``` $ nghttp --no-dep -vn "https://127.0.0.1:4443/stream-bytes/163840?chunk_size=16284"; ... [ 0.130] recv DATA frame [ 0.130] recv DATA frame

[GitHub] trafficserver pull request #693: TS-4324: Buffer responses to not send small...

2016-06-02 Thread masaori335
GitHub user masaori335 opened a pull request: https://github.com/apache/trafficserver/pull/693 TS-4324: Buffer responses to not send small size DATA frames If body_done flag is not marked and read available size is smaller than 16KB in Http2ConnectionState::send_a_data_frame

[GitHub] trafficserver pull request #686: TS-4496: Remove ink_code_md5_stringify

2016-06-02 Thread masaori335
Github user masaori335 commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/686#discussion_r65574580 --- Diff: mgmt/api/INKMgmtAPI.cc --- @@ -1865,8 +1865,7 @@ TSGetErrorMessage(TSMgmtError err_id) tsapi TSMgmtError TSEncryptPassword(char

[GitHub] trafficserver pull request #686: TS-4496: Remove ink_code_md5_stringify

2016-06-01 Thread masaori335
Github user masaori335 commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/686#discussion_r65416448 --- Diff: mgmt/WebMgmtUtils.h --- @@ -113,7 +113,7 @@ bool recordRangeCheck(const char *pattern, const char *value); bool recordIPCheck(const

[GitHub] trafficserver pull request #686: TS-4496: Remove ink_code_md5_stringify

2016-06-01 Thread masaori335
GitHub user masaori335 opened a pull request: https://github.com/apache/trafficserver/pull/686 TS-4496: Remove ink_code_md5_stringify [TS-4496](https://issues.apache.org/jira/browse/TS-4496) You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] trafficserver pull request #684: TS-4494: Replace ink_code_md5_stringify to ...

2016-06-01 Thread masaori335
Github user masaori335 closed the pull request at: https://github.com/apache/trafficserver/pull/684 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver pull request #682: TS-4489: Remove second calling of Http2Conn...

2016-06-01 Thread masaori335
Github user masaori335 closed the pull request at: https://github.com/apache/trafficserver/pull/682 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver pull request: TS-4494: Replace ink_code_md5_stringify to ink_c...

2016-05-31 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/684 Yes! I'll file another JIRA tickets for it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] trafficserver pull request: TS-4494: Replace ink_code_md5_stringify to ink_c...

2016-05-31 Thread masaori335
GitHub user masaori335 opened a pull request: https://github.com/apache/trafficserver/pull/684 TS-4494: Replace ink_code_md5_stringify to ink_code_to_hex_str - [TS-4494](https://issues.apache.org/jira/browse/TS-4494) - It looks like `ink_code_md5_stringify` is broken. So using

[GitHub] trafficserver pull request: TS-4489: Remove second calling of Http2Connectio...

2016-05-31 Thread masaori335
GitHub user masaori335 opened a pull request: https://github.com/apache/trafficserver/pull/682 TS-4489: Remove second calling of Http2ConnectionState::delete_stream in Http2Stream::do_io_close [TS-4489](https://issues.apache.org/jira/browse/TS-4489) You can merge this pull request

[GitHub] trafficserver pull request: TS-4477: Decrement http_current_client...

2016-05-24 Thread masaori335
GitHub user masaori335 opened a pull request: https://github.com/apache/trafficserver/pull/662 TS-4477: Decrement http_current_client_transactions_stat in HTTP/2 [TS-4477](https://issues.apache.org/jira/browse/TS-4477) You can merge this pull request into a Git repository by

[GitHub] trafficserver pull request: TS-4472: Decrement http_current_active...

2016-05-23 Thread masaori335
GitHub user masaori335 opened a pull request: https://github.com/apache/trafficserver/pull/660 TS-4472: Decrement http_current_active_client_connections_stat in HTTP/2 `http_current_active_client_connections_stat` is incremented in HttpSM. And if client connection is HTTP/1.1

[GitHub] trafficserver pull request: TS-3535: Experimental Support of HTTP/...

2016-05-18 Thread masaori335
Github user masaori335 commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/632#discussion_r63741679 --- Diff: proxy/http2/Http2ConnectionState.cc --- @@ -906,74 +957,140 @@ Http2ConnectionState::update_initial_rwnd(Http2WindowSize new_size

[GitHub] trafficserver pull request: TS-3535: Experimental Support of HTTP/...

2016-05-16 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/632#issuecomment-219591587 The new commit passed the build tests on the CI - https://ci.trafficserver.apache.org/view/github/job/Github-Linux/80/ - https

[GitHub] trafficserver pull request: TS-3535: Experimental Support of HTTP/...

2016-05-13 Thread masaori335
Github user masaori335 commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/632#discussion_r63255750 --- Diff: proxy/http2/Http2ConnectionState.cc --- @@ -238,22 +241,29 @@ rcv_headers_frame(Http2ConnectionState &cstate, const Http2Frame &a

[GitHub] trafficserver pull request: TS-3535: Experimental Support of HTTP/...

2016-05-13 Thread masaori335
Github user masaori335 commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/632#discussion_r63215167 --- Diff: proxy/http2/Http2DependencyTree.h --- @@ -0,0 +1,296 @@ +/** @file + + HTTP/2 Dependency Tree + + The original idea

[GitHub] trafficserver pull request: TS-3535: Experimental Support of HTTP/...

2016-05-13 Thread masaori335
Github user masaori335 commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/632#discussion_r63212972 --- Diff: mgmt/RecordsConfig.cc --- @@ -1976,6 +1976,8 @@ static const RecordElement RecordsConfig[] = // {RECT_CONFIG

[GitHub] trafficserver pull request: TS-3535: Experimental Support of HTTP/...

2016-05-12 Thread masaori335
Github user masaori335 commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/632#discussion_r63078637 --- Diff: proxy/http2/HTTP2.h --- @@ -60,6 +60,10 @@ const uint32_t HTTP2_MAX_FRAME_SIZE = 16384; const uint32_t HTTP2_HEADER_TABLE_SIZE = 4096

[GitHub] trafficserver pull request: TS-3535: Experimental Support of HTTP/...

2016-05-12 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/632#issuecomment-218822758 This is second patch after the #525 and TS-4295. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] trafficserver pull request: TS-3535: Experimental Support of HTTP/...

2016-05-12 Thread masaori335
GitHub user masaori335 opened a pull request: https://github.com/apache/trafficserver/pull/632 TS-3535: Experimental Support of HTTP/2 Stream Priority feature This is an experimental support of HTTP/2 Stream Priority feature. - Add a option to enable this feature ( disabled

[GitHub] trafficserver pull request: TS-4156: remove the traffic_sac, stand...

2016-05-02 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/593#issuecomment-216432563 Here is the docs : [Internationalize Documentation - Update PO files](https://cwiki.apache.org/confluence/display/TS/Internationalize+Documentation

[GitHub] trafficserver pull request: TS-4355: Change assert condition for T...

2016-04-26 Thread masaori335
Github user masaori335 closed the pull request at: https://github.com/apache/trafficserver/pull/600 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver pull request: TS-4355: Change assert condition for T...

2016-04-25 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/600#issuecomment-214584746 Summary is added. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] trafficserver pull request: TS-4355: Change assert condition for T...

2016-04-25 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/600#issuecomment-214583503 When I send HTTP/2 request to ATS (built with debug option), I always see this assertion is triggered. It looks like `make check` and Regression Tests

[GitHub] trafficserver pull request: TS-4355: Change assert condition for T...

2016-04-24 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/600#issuecomment-214095730 @shinrich Could you take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] trafficserver pull request: TS-4355: Change assert condition for T...

2016-04-24 Thread masaori335
GitHub user masaori335 opened a pull request: https://github.com/apache/trafficserver/pull/600 TS-4355: Change assert condition for TS-3612 You can merge this pull request into a Git repository by running: $ git pull https://github.com/masaori335/trafficserver ts-4355

[GitHub] trafficserver pull request: TS-4364: Address remnants from HTTP/2 ...

2016-04-20 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/584#issuecomment-212708586 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] trafficserver pull request: TS-4361: Remove TS_FETCH_EVENT handler...

2016-04-18 Thread masaori335
GitHub user masaori335 opened a pull request: https://github.com/apache/trafficserver/pull/581 TS-4361: Remove TS_FETCH_EVENT handlers from Http2ClientSession You can merge this pull request into a Git repository by running: $ git pull https://github.com/masaori335

[GitHub] trafficserver pull request: TS-3535: Experimental Support of Strea...

2016-04-17 Thread masaori335
Github user masaori335 closed the pull request at: https://github.com/apache/trafficserver/pull/525 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver pull request: TS-3535: Experimental Support of Strea...

2016-04-17 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/525#issuecomment-211173098 Now, FetchSM and PluginVC is removed from HTTP/2 components by TS-3612. It look like I need more works to rebase this on latest master. I'm going to

[GitHub] trafficserver pull request: TS-4087: Docs: About new settings to l...

2016-04-10 Thread masaori335
Github user masaori335 closed the pull request at: https://github.com/apache/trafficserver/pull/540 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver pull request: TS-4295: Add Priority Queue in lib/ts/

2016-04-05 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/537#issuecomment-206131655 @jpeach I didn't know we can use `TestBox.h` in Unit Tests:p I'll fix tests to use it. https://github.com/apache/traffics

[GitHub] trafficserver pull request: TS-4295: Add Priority Queue in lib/ts/

2016-04-05 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/537#issuecomment-206128440 @jpeach I agree with using many asserts is ugly. But if I understand correctly, when we use `TestBox.h`, we need to write tests as Regression Tests. Right

[GitHub] trafficserver pull request: TS-4295: Add Priority Queue in lib/ts/

2016-04-05 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/537#issuecomment-206096251 @maskit Comparator is added. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] trafficserver pull request: TS-4295: Add Priority Queue in lib/ts/

2016-03-30 Thread masaori335
Github user masaori335 commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/537#discussion_r58005044 --- Diff: lib/ts/PriorityQueue.h --- @@ -0,0 +1,207 @@ +/** @file + + Priority Queue Implementation using Min Heap

[GitHub] trafficserver pull request: TS-4295: Add Priority Queue in lib/ts/

2016-03-30 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/537#issuecomment-203739388 @maskit Please take another look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] trafficserver pull request: TS-4295: Add Priority Queue in lib/ts/

2016-03-30 Thread masaori335
Github user masaori335 commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/537#discussion_r57996852 --- Diff: lib/ts/PriorityQueue.h --- @@ -0,0 +1,191 @@ +/** @file + + Priority Queue Implimentation using Min Heap

[GitHub] trafficserver pull request: TS-4295: Add Priority Queue in lib/ts/

2016-03-30 Thread masaori335
Github user masaori335 commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/537#discussion_r57996306 --- Diff: lib/ts/PriorityQueue.h --- @@ -0,0 +1,191 @@ +/** @file + + Priority Queue Implimentation using Min Heap

[GitHub] trafficserver pull request: TS-4295: Add Priority Queue in lib/ts/

2016-03-30 Thread masaori335
Github user masaori335 commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/537#discussion_r57996067 --- Diff: lib/ts/PriorityQueue.h --- @@ -0,0 +1,191 @@ +/** @file + + Priority Queue Implimentation using Min Heap

[GitHub] trafficserver pull request: TS-4087: Docs: About new settings to l...

2016-03-27 Thread masaori335
GitHub user masaori335 opened a pull request: https://github.com/apache/trafficserver/pull/540 TS-4087: Docs: About new settings to limit streams You can merge this pull request into a Git repository by running: $ git pull https://github.com/masaori335/trafficserver ts

[GitHub] trafficserver pull request: TS-4298: Breakdown parameter checks in...

2016-03-25 Thread masaori335
GitHub user masaori335 opened a pull request: https://github.com/apache/trafficserver/pull/539 TS-4298: Breakdown parameter checks in Http2::init() [TS-4298](https://issues.apache.org/jira/browse/TS-4298) You can merge this pull request into a Git repository by running: $ git

[GitHub] trafficserver pull request: TS-3535: Experimental Support of Strea...

2016-03-24 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/525#issuecomment-200705387 I spined out priority queue stuff as [TS-4295](https://issues.apache.org/jira/browse/TS-4295). I'm going to fix this patch to use it and fix conf

[GitHub] trafficserver pull request: TS-4295: Add Priority Queue in lib/ts/

2016-03-24 Thread masaori335
GitHub user masaori335 opened a pull request: https://github.com/apache/trafficserver/pull/537 TS-4295: Add Priority Queue in lib/ts/ [TS-4295](https://issues.apache.org/jira/browse/TS-4295) You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] trafficserver pull request: TS-3535: Experimental Support of Strea...

2016-03-23 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/525#issuecomment-200337999 @PSUdaemon Yes, it is! It is one of reasons of implemented Http2PriorityQueue using template. Is it better to change name and move under `lib/ts

[GitHub] trafficserver pull request: TS-3535: Experimental Support of Strea...

2016-03-23 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/525#issuecomment-200325489 @zwoop Should we avoid STL in test code too? I used `ts/Vec.h` and implemented priority queue to avoid STL:D --- If your project is set up for it, you can

[GitHub] trafficserver pull request: TS-4087: Reduce SETTINGS_MAX_CONCURREN...

2016-03-21 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/485#issuecomment-199581399 That is good point. This patch doesn't cover such cases. > I think it would be better to dynamically adjust the max stream when a new s

[GitHub] trafficserver pull request: TS-3535: Experimental Support of Strea...

2016-03-15 Thread masaori335
GitHub user masaori335 opened a pull request: https://github.com/apache/trafficserver/pull/525 TS-3535: Experimental Support of Stream Priority Feature in HTTP/2 [TS-3535](https://issues.apache.org/jira/browse/TS-3535) Experimental Support of Stream Priority Feature

[GitHub] trafficserver pull request: TS-4267: HTTP/2 Updates to debugging

2016-03-09 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/522#issuecomment-194609719 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] trafficserver pull request: TS-4087: Reduce SETTINGS_MAX_CONCURREN...

2016-02-24 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/485#issuecomment-188585450 1. Removed `max_active_streams_per_thread_in` and related code. 2. Set default value of `proxy.config.http2.max_active_streams_in` 0 for backward

[GitHub] trafficserver pull request: TS-4087: Reduce SETTINGS_MAX_CONCURREN...

2016-02-24 Thread masaori335
Github user masaori335 commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/485#discussion_r54039631 --- Diff: proxy/http2/Http2ConnectionState.cc --- @@ -1160,3 +1162,31 @@ Http2ConnectionState::send_window_update_frame(Http2StreamId id, uint32_t

[GitHub] trafficserver pull request: TS-4092: Decouple HPACK from HTTP/2

2016-02-19 Thread masaori335
Github user masaori335 commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/460#discussion_r53448759 --- Diff: proxy/http2/HTTP2.cc --- @@ -484,246 +498,162 @@ convert_from_2_to_1_1_header(HTTPHdr *headers) return PARSE_DONE

[GitHub] trafficserver pull request: TS-4092: Decouple HPACK from HTTP/2

2016-02-18 Thread masaori335
Github user masaori335 commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/460#discussion_r53417506 --- Diff: proxy/http2/HTTP2.cc --- @@ -484,246 +498,162 @@ convert_from_2_to_1_1_header(HTTPHdr *headers) return PARSE_DONE

[GitHub] trafficserver pull request: TS-4092: Decouple HPACK from HTTP/2

2016-02-18 Thread masaori335
Github user masaori335 commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/460#discussion_r53414542 --- Diff: proxy/http2/Http2ConnectionState.cc --- @@ -992,43 +998,50 @@ Http2ConnectionState::send_headers_frame(FetchSM *fetch_sm

[GitHub] trafficserver pull request: TS-4092: Decouple HPACK from HTTP/2

2016-02-18 Thread masaori335
Github user masaori335 commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/460#discussion_r53414029 --- Diff: proxy/http2/Http2ConnectionState.cc --- @@ -992,43 +998,50 @@ Http2ConnectionState::send_headers_frame(FetchSM *fetch_sm

[GitHub] trafficserver pull request: TS-4087: Reduce SETTINGS_MAX_CONCURREN...

2016-02-18 Thread masaori335
GitHub user masaori335 opened a pull request: https://github.com/apache/trafficserver/pull/485 TS-4087: Reduce SETTINGS_MAX_CONCURRENT_STREAMS when too many streams Add below variables in records.config - proxy.config.http2.min_concurrent_streams_in - proxy.config.http2

[GitHub] trafficserver pull request: TS-4213: Remove unused arguments from ...

2016-02-17 Thread masaori335
GitHub user masaori335 opened a pull request: https://github.com/apache/trafficserver/pull/484 TS-4213: Remove unused arguments from frame_handlers [TS-4213](https://issues.apache.org/jira/browse/TS-4213) You can merge this pull request into a Git repository by running: $ git

[GitHub] trafficserver pull request: TS-4209: Limit concurrent streams corr...

2016-02-15 Thread masaori335
GitHub user masaori335 opened a pull request: https://github.com/apache/trafficserver/pull/480 TS-4209: Limit concurrent streams correctly [TS-4209](https://issues.apache.org/jira/browse/TS-4209) You can merge this pull request into a Git repository by running: $ git pull

[GitHub] trafficserver pull request: TS-3917: Sending only SETTINGS_INITIAL...

2016-02-11 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/471#issuecomment-183182665 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] trafficserver pull request: TS-4066: Memory leaks in gmake check t...

2016-02-11 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/468#issuecomment-183179482 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] trafficserver pull request: TS-4172: Cleanup debug logs of Http2Co...

2016-02-11 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/454#issuecomment-183178568 Please take another look --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] trafficserver pull request: TS-3917: Sending only SETTINGS_INITIAL...

2016-02-11 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/466#issuecomment-183178397 @bryancall OK :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] trafficserver pull request: TS-3917: Sending only SETTINGS_INITIAL...

2016-02-11 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/466#issuecomment-183175215 @bryancall Oh really? I'll check. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] trafficserver pull request: TS-3917: Sending only SETTINGS_INITIAL...

2016-02-11 Thread masaori335
Github user masaori335 commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/466#discussion_r52704287 --- Diff: proxy/http2/HTTP2.cc --- @@ -727,7 +727,7 @@ http2_decode_header_blocks(HTTPHdr *hdr, const uint8_t *buf_start, const uint8_t

[GitHub] trafficserver pull request: TS-4172: Cleanup debug logs of Http2Co...

2016-02-09 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/454#issuecomment-182204034 I didn't know this one. Thanks! I'll fix with this. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver pull request: TS-4172: Cleanup debug logs of Http2Co...

2016-02-09 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/454#issuecomment-182203173 @jpeach I thought that too, but it has error in my box (CentOS7, gcc-4.8) Diff: https://paste.apache.org/4tlm Result: https://paste.apache.org/gnEb

[GitHub] trafficserver pull request: TS-4172: Cleanup debug logs of Http2Co...

2016-02-09 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/454#issuecomment-182201082 (Because of I force pushed, James's comment is disappeared:\ ) --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] trafficserver pull request: TS-4172: Cleanup debug logs of Http2Co...

2016-02-09 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/454#issuecomment-182200775 @bryancall It looks good. But it totally needs 3 macros like below as far as I tried. ``` #define DebugHttp2Con(ua_session, fmt

[GitHub] trafficserver pull request: TS-4172: Cleanup debug logs of Http2Co...

2016-02-08 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/454#issuecomment-181738410 @jpeach Please take a look --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] trafficserver pull request: TS-4172: Cleanup debug logs of Http2Co...

2016-02-05 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/454#issuecomment-180258234 I agree with we should keep consistency. So, I'm going to keep current names and debug tag in Http2ClientSession. The problem is same

[GitHub] trafficserver pull request: TS-4172: Cleanup debug logs of Http2Co...

2016-02-04 Thread masaori335
GitHub user masaori335 opened a pull request: https://github.com/apache/trafficserver/pull/454 TS-4172: Cleanup debug logs of Http2ConnectionState [TS-4172](https://issues.apache.org/jira/browse/TS-4172) You can merge this pull request into a Git repository by running: $ git

[GitHub] trafficserver pull request: TS-4144: Add TSHttpTxnSetHttpRetStatus...

2016-02-01 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/435#issuecomment-178292993 Looks good to me. @bgaff Could you take a look this? If you're ok, I'll land this. --- If your project is set up for it, you can reply to this

[GitHub] trafficserver pull request: TS-4162: Add proxy.config.http2.active...

2016-01-29 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/444#issuecomment-177047293 Current value is 0, because active timeout of VConnection in Http2ClientSession is not set. I changed default value of `proxy.config.http2

[GitHub] trafficserver pull request: TS-4162: Add proxy.config.http2.active...

2016-01-29 Thread masaori335
Github user masaori335 commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/444#discussion_r51245359 --- Diff: mgmt/RecordsConfig.cc --- @@ -1995,6 +1995,8 @@ static const RecordElement RecordsConfig[] = , {RECT_CONFIG

[GitHub] trafficserver pull request: TS-4162: Add proxy.config.http2.active...

2016-01-29 Thread masaori335
GitHub user masaori335 opened a pull request: https://github.com/apache/trafficserver/pull/444 TS-4162: Add proxy.config.http2.active_timeout_in - Fix [TS-4162](https://issues.apache.org/jira/browse/TS-4162) You can merge this pull request into a Git repository by running

[GitHub] trafficserver pull request: TS-4118: CID 1347871: Add error handli...

2016-01-13 Thread masaori335
GitHub user masaori335 opened a pull request: https://github.com/apache/trafficserver/pull/423 TS-4118: CID 1347871: Add error handling in HPACK_Encode [TS-4118](https://issues.apache.org/jira/browse/TS-4118) You can merge this pull request into a Git repository by running

[GitHub] trafficserver pull request: Doc: Add config file for Transifex Cli...

2016-01-11 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/406#issuecomment-170460942 I wrote about GitHub, ReadTheDocs and Transifex. https://cwiki.apache.org/confluence/display/TS/Internationalize+Documentation --- If your project is set

[GitHub] trafficserver pull request: TS-3478: Indexing header representatio...

2016-01-09 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/391#issuecomment-170210554 Oops, I mean TS-4092. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] trafficserver pull request: TS-3478: Indexing header representatio...

2016-01-08 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/391#issuecomment-170200715 I'm fine to ship this. 1. Actually I'm not big fun of names of classes and functions in HPACK starting with 'HTTP2'. But those con

  1   2   >