[GitHub] trafficserver pull request #788: TS-4635: Fix RefCountCacheSerializer file d...

2016-07-08 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/788 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #770: Integrate clang-tidy into the build.

2016-07-08 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/770 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #783: TS-3816 : Replace ptr_len_cmp with memcmp

2016-07-07 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/783 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #783: TS-3816 : Replace ptr_len_cmp with memcmp

2016-07-07 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/783 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #783: TS-3816 : Replace ptr_len_cmp with memcmp

2016-07-07 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/783 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] trafficserver pull request #789: TS-4100: Remove remaining stats processor c...

2016-07-07 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/789 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #789: TS-4100: Remove remaining stats processor c...

2016-07-07 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/789 TS-4100: Remove remaining stats processor code. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jpeach/trafficserver fix/4100-2

[GitHub] trafficserver pull request #786: TS-4396: fix number_of_redirections off-by-...

2016-07-06 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/786#discussion_r69782549 --- Diff: proxy/http/HttpSM.cc --- @@ -1954,9 +1954,7 @@ HttpSM::state_read_server_response_header(int event, void *data

[GitHub] trafficserver pull request #788: TS-4635: Fix RefCountCacheSerializer file d...

2016-07-06 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/788 TS-4635: Fix RefCountCacheSerializer file descriptor leaks. Fix various file descriptor leaks on the RefCountCacheSerializer error path. Move RefCountCacheSerializer to a separate header so

[GitHub] trafficserver pull request #783: TS-3816 : Replace ptr_len_cmp with memcmp

2016-07-05 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/783#discussion_r69640431 --- Diff: proxy/StatPages.cc --- @@ -83,7 +83,7 @@ StatPagesManager::handle_http(Continuation *cont, HTTPHdr *header) host_len

[GitHub] trafficserver issue #787: TS-4507: Fix SSN and TXN hook ordering.

2016-07-05 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/787 Is is possible to break the addditional fixes out into separate tickets and PRs? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] trafficserver pull request #783: TS-3816 : Replace ptr_len_cmp with memcmp

2016-07-05 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/783#discussion_r69635990 --- Diff: proxy/StatPages.cc --- @@ -83,7 +83,7 @@ StatPagesManager::handle_http(Continuation *cont, HTTPHdr *header) host_len

[GitHub] trafficserver pull request #783: TS-3816 : Replace ptr_len_cmp with memcmp

2016-07-05 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/783#discussion_r69613350 --- Diff: proxy/StatPages.cc --- @@ -83,7 +83,7 @@ StatPagesManager::handle_http(Continuation *cont, HTTPHdr *header) host_len

[GitHub] trafficserver pull request #783: TS-3816 : Replace ptr_len_cmp with memcmp

2016-07-05 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/783#discussion_r69611157 --- Diff: proxy/http/HttpTransact.cc --- @@ -762,8 +762,8 @@ HttpTransact::StartRemapRequest(State *s) const char syntxt[] = "syntheti

[GitHub] trafficserver pull request #786: TS-4396: fix number_of_redirections off-by-...

2016-07-05 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/786#discussion_r69609382 --- Diff: proxy/http/HttpSM.cc --- @@ -1954,9 +1954,7 @@ HttpSM::state_read_server_response_header(int event, void *data

[GitHub] trafficserver pull request #786: TS-4396: fix number_of_redirections off-by-...

2016-07-05 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/786#discussion_r69606800 --- Diff: proxy/http/HttpSM.cc --- @@ -7618,6 +7616,8 @@ HttpSM::do_redirect() return; } + redirection_tries

[GitHub] trafficserver pull request #779: TS-4627: support TSRemapOSResponse in ts_lu...

2016-07-01 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/779#discussion_r69363166 --- Diff: plugins/experimental/ts_lua/ts_lua.c --- @@ -116,6 +116,69 @@ TSRemapDeleteInstance(void *ih) return; } +void

[GitHub] trafficserver pull request #779: TS-4627: support TSRemapOSResponse in ts_lu...

2016-07-01 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/779#discussion_r69363133 --- Diff: plugins/experimental/ts_lua/ts_lua.c --- @@ -116,6 +116,69 @@ TSRemapDeleteInstance(void *ih) return; } +void

[GitHub] trafficserver pull request #779: TS-4627: support TSRemapOSResponse in ts_lu...

2016-07-01 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/779#discussion_r69362522 --- Diff: plugins/experimental/ts_lua/ts_lua_http.c --- @@ -29,9 +29,33 @@ typedef enum { TS_LUA_CACHE_LOOKUP_SKIPPED

[GitHub] trafficserver pull request #779: TS-4627: support TSRemapOSResponse in ts_lu...

2016-07-01 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/779#discussion_r69362504 --- Diff: plugins/experimental/ts_lua/ts_lua_http.c --- @@ -29,9 +29,33 @@ typedef enum { TS_LUA_CACHE_LOOKUP_SKIPPED

[GitHub] trafficserver pull request #784: Temporarily disable ParentProxy API tests.

2016-07-01 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/784 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #783: TS-3816 : Replace ptr_len_cmp with memcmp

2016-07-01 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/783#discussion_r69356010 --- Diff: proxy/http/HttpTransact.cc --- @@ -762,8 +762,8 @@ HttpTransact::StartRemapRequest(State *s) const char syntxt[] = "syntheti

[GitHub] trafficserver pull request #783: TS-3816 : Replace ptr_len_cmp with memcmp

2016-07-01 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/783#discussion_r69355867 --- Diff: proxy/http/HttpTransact.cc --- @@ -249,7 +249,7 @@ find_server_and_update_current_info(HttpTransact::State *s) int host_len

[GitHub] trafficserver pull request #783: TS-3816 : Replace ptr_len_cmp with memcmp

2016-07-01 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/783#discussion_r69355758 --- Diff: proxy/StatPages.cc --- @@ -83,7 +83,7 @@ StatPagesManager::handle_http(Continuation *cont, HTTPHdr *header) host_len

[GitHub] trafficserver pull request #784: Temporarily disable ParentProxy API tests.

2016-07-01 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/784 Temporarily disable ParentProxy API tests. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jpeach/trafficserver fix/disable-proxy-tests

[GitHub] trafficserver issue #784: Temporarily disable ParentProxy API tests.

2016-07-01 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/784 @zwoop --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] trafficserver issue #777: TS-4623 Adds a pre-commit script for git

2016-07-01 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/777 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] trafficserver pull request #777: TS-4623 Adds a pre-commit script for git

2016-07-01 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/777#discussion_r69330732 --- Diff: tools/pre-commit --- @@ -0,0 +1,66 @@ +#! /usr/bin/env bash +# +# Simple pre-commit hook script, enforcing clang-format on our

[GitHub] trafficserver pull request #740: TS-4570: Return to TS_HTTP_OS_DNS_HOOK if s...

2016-06-30 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/740 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #741: TS-4588: Require braces around statements.

2016-06-30 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/741 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #775: TS-4598 : Coverity Null-Check after deref in Netwo...

2016-06-30 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/775 s/NetworkUtilisRemote/NetworkUtilsRemote/ ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] trafficserver issue #773: TS-4622 User port from SRV response when connectin...

2016-06-30 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/773 @jacksontj Maybe the right place to do this is when ``HttpSM::set_next_state() `` handles ``SM_ACTION_DNS_LOOKUP``? --- If your project is set up for it, you can reply to this email and

[GitHub] trafficserver pull request #747: TS-4395 Add new plugin, remap_purge

2016-06-30 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/747#discussion_r69190550 --- Diff: plugins/experimental/remap_purge/remap_purge.c --- @@ -143,18 +144,17 @@ on_http_cache_lookup_complete(TSHttpTxn txnp, TSCont contp

[GitHub] trafficserver pull request #747: TS-4395 Add new plugin, remap_purge

2016-06-30 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/747#discussion_r69190382 --- Diff: plugins/experimental/remap_purge/remap_purge.c --- @@ -202,34 +202,38 @@ handle_purge(TSHttpTxn txnp, PurgeInstance *purge) bool

[GitHub] trafficserver issue #773: TS-4622 User port from SRV response when connectin...

2016-06-30 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/773 -1, this breaks ``TSHttpTxnServerAddrSet``. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] trafficserver pull request #747: TS-4395 Add new plugin, remap_purge

2016-06-30 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/747#discussion_r69163526 --- Diff: plugins/experimental/remap_purge/remap_purge.c --- @@ -0,0 +1,335 @@ +/** @file + + Per-remap purge RESTful API for stateful

[GitHub] trafficserver pull request #747: TS-4395 Add new plugin, remap_purge

2016-06-30 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/747#discussion_r69163433 --- Diff: plugins/experimental/remap_purge/remap_purge.c --- @@ -0,0 +1,335 @@ +/** @file + + Per-remap purge RESTful API for stateful

[GitHub] trafficserver pull request #747: TS-4395 Add new plugin, remap_purge

2016-06-30 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/747#discussion_r69163229 --- Diff: plugins/experimental/remap_purge/remap_purge.c --- @@ -0,0 +1,335 @@ +/** @file + + Per-remap purge RESTful API for stateful

[GitHub] trafficserver pull request #747: TS-4395 Add new plugin, remap_purge

2016-06-30 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/747#discussion_r69163031 --- Diff: plugins/experimental/remap_purge/remap_purge.c --- @@ -0,0 +1,335 @@ +/** @file + + Per-remap purge RESTful API for stateful

[GitHub] trafficserver pull request #747: TS-4395 Add new plugin, remap_purge

2016-06-30 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/747#discussion_r69162592 --- Diff: plugins/experimental/remap_purge/remap_purge.c --- @@ -0,0 +1,335 @@ +/** @file + + Per-remap purge RESTful API for stateful

[GitHub] trafficserver pull request #747: TS-4395 Add new plugin, remap_purge

2016-06-30 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/747#discussion_r69162190 --- Diff: plugins/experimental/remap_purge/remap_purge.c --- @@ -0,0 +1,335 @@ +/** @file + + Per-remap purge RESTful API for stateful

[GitHub] trafficserver pull request #747: TS-4395 Add new plugin, remap_purge

2016-06-30 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/747#discussion_r69160469 --- Diff: plugins/experimental/remap_purge/remap_purge.c --- @@ -0,0 +1,335 @@ +/** @file + + Per-remap purge RESTful API for stateful

[GitHub] trafficserver pull request #747: TS-4395 Add new plugin, remap_purge

2016-06-30 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/747#discussion_r69160033 --- Diff: plugins/experimental/remap_purge/remap_purge.c --- @@ -0,0 +1,335 @@ +/** @file + + Per-remap purge RESTful API for stateful

[GitHub] trafficserver pull request #747: TS-4395 Add new plugin, remap_purge

2016-06-30 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/747#discussion_r69159927 --- Diff: plugins/experimental/remap_purge/remap_purge.c --- @@ -0,0 +1,335 @@ +/** @file + + Per-remap purge RESTful API for stateful

[GitHub] trafficserver pull request #747: TS-4395 Add new plugin, remap_purge

2016-06-30 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/747#discussion_r69158965 --- Diff: plugins/experimental/remap_purge/remap_purge.c --- @@ -0,0 +1,335 @@ +/** @file + + Per-remap purge RESTful API for stateful

[GitHub] trafficserver pull request #747: TS-4395 Add new plugin, remap_purge

2016-06-30 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/747#discussion_r69158585 --- Diff: plugins/experimental/remap_purge/remap_purge.c --- @@ -0,0 +1,335 @@ +/** @file + + Per-remap purge RESTful API for stateful

[GitHub] trafficserver pull request #747: TS-4395 Add new plugin, remap_purge

2016-06-30 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/747#discussion_r69158201 --- Diff: plugins/experimental/remap_purge/remap_purge.c --- @@ -0,0 +1,335 @@ +/** @file + + Per-remap purge RESTful API for stateful

[GitHub] trafficserver pull request #747: TS-4395 Add new plugin, remap_purge

2016-06-30 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/747#discussion_r69157502 --- Diff: plugins/experimental/remap_purge/remap_purge.c --- @@ -0,0 +1,335 @@ +/** @file + + Per-remap purge RESTful API for stateful

[GitHub] trafficserver pull request #747: TS-4395 Add new plugin, remap_purge

2016-06-30 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/747#discussion_r69157359 --- Diff: plugins/experimental/remap_purge/remap_purge.c --- @@ -0,0 +1,335 @@ +/** @file + + Per-remap purge RESTful API for stateful

[GitHub] trafficserver pull request #747: TS-4395 Add new plugin, remap_purge

2016-06-30 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/747#discussion_r69157179 --- Diff: plugins/experimental/remap_purge/remap_purge.c --- @@ -0,0 +1,335 @@ +/** @file + + Per-remap purge RESTful API for stateful

[GitHub] trafficserver issue #770: Integrate clang-tidy into the build.

2016-06-29 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/770 @zwoop @PSUdaemon Please take this for a spin, but let's not merge yet. It looks like ``clang-tidy`` still get various build errors which cause it to eat code in unfortunate

[GitHub] trafficserver pull request #770: Integrate clang-tidy into the build.

2016-06-29 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/770 Integrate clang-tidy into the build. Add a recursive tidy rule to run clang-tidy over all the source. The mor recommended way to do this is to build a compilation database, however the

[GitHub] trafficserver issue #740: TS-4570: Return to TS_HTTP_OS_DNS_HOOK if server a...

2016-06-29 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/740 @SolidWallOfCode I filed [TS-4574](https://issues.apache.org/jira/browse/TS-4574) to clear the explicit address. However now that I know a bit more about how the DNS resolutions works, the

[GitHub] trafficserver pull request #757: Update configuring-traffic-server.en.rst : ...

2016-06-29 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/757 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #741: TS-4588: Require braces around statements.

2016-06-29 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/741 Abandoning this PR for now. Will go back and look into getting ``clang-tidy`` support into the build system. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #757: Update configuring-traffic-server.en.rst : 'config...

2016-06-29 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/757 Yup --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver issue #757: Update configuring-traffic-server.en.rst : 'config...

2016-06-29 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/757 What is the output of ``python ./doc/checkvers.py --check-version``? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] trafficserver issue #757: Update configuring-traffic-server.en.rst : 'config...

2016-06-29 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/757 Do you have the ``sphinx-doc`` package installed? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] trafficserver pull request #745: TS-4550 Adds X-Transaction-Id to xdebug

2016-06-29 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/745#discussion_r68974323 --- Diff: plugins/experimental/xdebug/xdebug.cc --- @@ -234,6 +237,20 @@ InjectMilestonesHeader(TSHttpTxn txn, TSMBuffer buffer, TSMLoc hdr

[GitHub] trafficserver pull request #745: TS-4550 Adds X-Transaction-Id to xdebug

2016-06-29 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/745#discussion_r68973675 --- Diff: plugins/experimental/xdebug/xdebug.cc --- @@ -234,6 +237,20 @@ InjectMilestonesHeader(TSHttpTxn txn, TSMBuffer buffer, TSMLoc hdr

[GitHub] trafficserver issue #757: Update configuring-traffic-server.en.rst : 'config...

2016-06-29 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/757 @zwoop I'm going to merge this as is for now, ok? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] trafficserver pull request #748: TS-4504 Use the default config dir for conf...

2016-06-29 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/748#discussion_r68971045 --- Diff: plugins/healthchecks/healthchecks.c --- @@ -301,8 +301,22 @@ parse_configs(const char *fname) char buf[2 * 1024]; HCFileInfo

[GitHub] trafficserver pull request #748: TS-4504 Use the default config dir for conf...

2016-06-29 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/748#discussion_r68970820 --- Diff: plugins/healthchecks/healthchecks.c --- @@ -301,8 +301,22 @@ parse_configs(const char *fname) char buf[2 * 1024]; HCFileInfo

[GitHub] trafficserver pull request #764: Fix the CPP API plugins to link against lib...

2016-06-28 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/764 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #764: Fix the CPP API plugins to link against libatscppa...

2016-06-28 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/764 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver pull request #764: Fix the CPP API plugins to link against lib...

2016-06-28 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/764 Fix the CPP API plugins to link against libatscppapi. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jpeach/trafficserver fix/cppapi

[GitHub] trafficserver pull request #759: TS-4609: Fix uninitialized read in SDK_API_...

2016-06-28 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/759 TS-4609: Fix uninitialized read in SDK_API_HttpTxnTransform. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jpeach/trafficserver fix

[GitHub] trafficserver issue #759: TS-4609: Fix uninitialized read in SDK_API_HttpTxn...

2016-06-28 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/759 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #757: Update configuring-traffic-server.en.rst : 'config...

2016-06-28 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/757 For a suboption, I think the syntax would be: :option:`traffic_ctl config set` NAME VALUE But I'd have to render the docs locally to see exactly what happens. @persi

[GitHub] trafficserver pull request #756: TS-4604 : Command for configuring traffic s...

2016-06-28 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/756 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #756: TS-4604 : Commands for configuring traffic ...

2016-06-28 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/756#discussion_r68795473 --- Diff: doc/admin-guide/configuring-traffic-server.en.rst --- @@ -27,14 +27,14 @@ Traffic Server provides several options for configuring the system

[GitHub] trafficserver pull request #756: TS-4604 : Commands for configuring traffic ...

2016-06-28 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/756#discussion_r68793583 --- Diff: doc/admin-guide/configuring-traffic-server.en.rst --- @@ -43,13 +43,13 @@ To view a configuration setting, enter the following command

[GitHub] trafficserver pull request #756: TS-4604 : Commands for configuring traffic ...

2016-06-28 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/756#discussion_r68793447 --- Diff: doc/admin-guide/configuring-traffic-server.en.rst --- @@ -27,13 +27,13 @@ Traffic Server provides several options for configuring the system

[GitHub] trafficserver issue #755: TS-4518 Eliminate memory leaks in UUID regressions

2016-06-28 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/755 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] trafficserver pull request #750: TS-3371 Add configuration to globally contr...

2016-06-27 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/750#discussion_r68694184 --- Diff: mgmt/RecordsConfig.cc --- @@ -1212,6 +1212,8 @@ static const RecordElement RecordsConfig

[GitHub] trafficserver pull request #750: TS-3371 Add configuration to globally contr...

2016-06-27 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/750#discussion_r68693861 --- Diff: mgmt/RecordsConfig.cc --- @@ -1212,6 +1212,8 @@ static const RecordElement RecordsConfig

[GitHub] trafficserver issue #653: TS-4331: Major re-write of hostdb

2016-06-27 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/653 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] trafficserver issue #736: TS-4518 Add the basic APIs and code for UUIDs

2016-06-27 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/736 Looks good 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] trafficserver pull request #736: TS-4518 Add the basic APIs and code for UUI...

2016-06-27 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/736#discussion_r68610169 --- Diff: proxy/api/ts/ts.h --- @@ -2389,6 +2392,19 @@ tsapi const char *TSHttpHookNameLookup(TSHttpHookID hook); */ tsapi const char

[GitHub] trafficserver pull request #736: TS-4518 Add the basic APIs and code for UUI...

2016-06-27 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/736#discussion_r68609628 --- Diff: doc/developer-guide/api/types/TSUuid.en.rst --- @@ -0,0 +1,48 @@ +.. Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] trafficserver pull request #736: TS-4518 Add the basic APIs and code for UUI...

2016-06-27 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/736#discussion_r68609258 --- Diff: doc/developer-guide/api/types/TSUuid.en.rst --- @@ -0,0 +1,48 @@ +.. Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] trafficserver pull request #736: TS-4518 Add the basic APIs and code for UUI...

2016-06-27 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/736#discussion_r68609126 --- Diff: doc/developer-guide/api/types/TSUuid.en.rst --- @@ -0,0 +1,48 @@ +.. Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] trafficserver pull request #736: TS-4518 Add the basic APIs and code for UUI...

2016-06-27 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/736#discussion_r68608955 --- Diff: doc/developer-guide/api/functions/TSUuidCreate.en.rst --- @@ -0,0 +1,138 @@ +.. Licensed to the Apache Software Foundation (ASF) under one

[GitHub] trafficserver pull request #736: TS-4518 Add the basic APIs and code for UUI...

2016-06-27 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/736#discussion_r68608958 --- Diff: doc/developer-guide/api/functions/TSUuidCreate.en.rst --- @@ -0,0 +1,138 @@ +.. Licensed to the Apache Software Foundation (ASF) under one

[GitHub] trafficserver pull request #653: TS-4331: Major re-write of hostdb

2016-06-27 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/653#discussion_r68605778 --- Diff: iocore/hostdb/P_RefCountCache.h --- @@ -0,0 +1,896 @@ +/** @file + + A cache (with map-esque interface) for RefCountObjs

[GitHub] trafficserver pull request #742: TS-4589: Coalesce CPP API examples build.

2016-06-26 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/742 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #653: TS-4331: Major re-write of hostdb

2016-06-25 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/653#discussion_r68496042 --- Diff: iocore/hostdb/P_RefCountCache.h --- @@ -0,0 +1,896 @@ +/** @file + + A cache (with map-esque interface) for RefCountObjs

[GitHub] trafficserver pull request #653: TS-4331: Major re-write of hostdb

2016-06-25 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/653#discussion_r68496039 --- Diff: iocore/hostdb/P_RefCountCache.h --- @@ -0,0 +1,896 @@ +/** @file + + A cache (with map-esque interface) for RefCountObjs

[GitHub] trafficserver pull request #653: TS-4331: Major re-write of hostdb

2016-06-25 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/653#discussion_r68496026 --- Diff: iocore/hostdb/P_RefCountCache.h --- @@ -0,0 +1,896 @@ +/** @file + + A cache (with map-esque interface) for RefCountObjs

[GitHub] trafficserver pull request #653: TS-4331: Major re-write of hostdb

2016-06-25 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/653#discussion_r68496007 --- Diff: iocore/hostdb/P_RefCountCache.h --- @@ -0,0 +1,896 @@ +/** @file + + A cache (with map-esque interface) for RefCountObjs

[GitHub] trafficserver pull request #653: TS-4331: Major re-write of hostdb

2016-06-25 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/653#discussion_r68495996 --- Diff: iocore/hostdb/P_RefCountCache.h --- @@ -0,0 +1,896 @@ +/** @file + + A cache (with map-esque interface) for RefCountObjs

[GitHub] trafficserver pull request #653: TS-4331: Major re-write of hostdb

2016-06-25 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/653#discussion_r68495991 --- Diff: iocore/hostdb/P_RefCountCache.h --- @@ -0,0 +1,896 @@ +/** @file + + A cache (with map-esque interface) for RefCountObjs

[GitHub] trafficserver pull request #653: TS-4331: Major re-write of hostdb

2016-06-25 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/653#discussion_r68495986 --- Diff: iocore/hostdb/P_RefCountCache.h --- @@ -0,0 +1,896 @@ +/** @file + + A cache (with map-esque interface) for RefCountObjs

[GitHub] trafficserver pull request #653: TS-4331: Major re-write of hostdb

2016-06-25 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/653#discussion_r68495979 --- Diff: iocore/hostdb/P_RefCountCache.h --- @@ -0,0 +1,896 @@ +/** @file + + A cache (with map-esque interface) for RefCountObjs

[GitHub] trafficserver pull request #653: TS-4331: Major re-write of hostdb

2016-06-25 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/653#discussion_r68495976 --- Diff: iocore/hostdb/P_RefCountCache.h --- @@ -0,0 +1,896 @@ +/** @file + + A cache (with map-esque interface) for RefCountObjs

[GitHub] trafficserver pull request #653: TS-4331: Major re-write of hostdb

2016-06-25 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/653#discussion_r68495955 --- Diff: iocore/hostdb/HostDB.cc --- @@ -1234,8 +1036,8 @@ HostDBContinuation::removeEvent(int /* event ATS_UNUSED */, Event *e) if (cont

[GitHub] trafficserver pull request #653: TS-4331: Major re-write of hostdb

2016-06-25 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/653#discussion_r68495939 --- Diff: iocore/hostdb/HostDB.cc --- @@ -300,131 +237,77 @@ HostDBProcessor::cache() return &hostDB; } -struct HostDBTe

[GitHub] trafficserver pull request #653: TS-4331: Major re-write of hostdb

2016-06-25 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/653#discussion_r68495917 --- Diff: iocore/hostdb/P_RefCountCache.h --- @@ -0,0 +1,896 @@ +/** @file + + A cache (with map-esque interface) for RefCountObjs

[GitHub] trafficserver pull request #653: TS-4331: Major re-write of hostdb

2016-06-25 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/653#discussion_r68495915 --- Diff: iocore/hostdb/P_RefCountCache.h --- @@ -0,0 +1,896 @@ +/** @file + + A cache (with map-esque interface) for RefCountObjs

[GitHub] trafficserver pull request #653: TS-4331: Major re-write of hostdb

2016-06-25 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/653#discussion_r68495906 --- Diff: iocore/hostdb/P_RefCountCache.h --- @@ -0,0 +1,896 @@ +/** @file + + A cache (with map-esque interface) for RefCountObjs

  1   2   3   4   5   6   7   >