Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/747#discussion_r69190550
--- Diff: plugins/experimental/remap_purge/remap_purge.c ---
@@ -143,18 +144,17 @@ on_http_cache_lookup_complete(TSHttpTxn txnp, TSCont
contp, PurgeInstance *purge
}
/* Before we can send the response, we want to modify it to a "200 OK"
again,
- and produce some reasonabel body output. */
+ and produce some reasonable body output. */
static int
on_send_response_header(TSHttpTxn txnp, TSCont contp, PurgeInstance *purge)
{
TSMBuffer bufp;
TSMLoc hdr_loc;
- TSDebug(PLUGIN_NAME, "Fixing up the response on the succseful PURGE");
+ TSDebug(PLUGIN_NAME, "Fixing up the response on the successful PURGE");
if (TS_SUCCESS == TSHttpTxnClientRespGet(txnp, &bufp, &hdr_loc)) {
char response[1024];
- int len = snprintf(response, sizeof(response) - 1, "PURGED
%s\r\n\r\n", purge->id);
- ;
+ int len = snprintf(response, sizeof(response), "PURGED %s\r\n\r\n",
purge->id);
--- End diff --
``len`` is what ``snprintf`` would have printed. Should be fine in
practice, but in principle could be > ``strlen(response)``.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
