Github user ericcarlschwartz closed the pull request at:
https://github.com/apache/trafficserver/pull/598
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user ericcarlschwartz opened a pull request:
https://github.com/apache/trafficserver/pull/598
[YTSATS-676] Add log field for Server Connection Count
https://issues.apache.org/jira/browse/TS-4379
You can merge this pull request into a Git repository by running:
$ git
Github user ericcarlschwartz commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/375#discussion_r47842401
--- Diff: proxy/http/remap/RemapProcessor.cc ---
@@ -88,7 +88,7 @@ RemapProcessor::setup_for_remap(HttpTransact::State *s)
if
Github user ericcarlschwartz commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/375#discussion_r47842310
--- Diff: proxy/http/remap/RemapProcessor.cc ---
@@ -88,7 +88,7 @@ RemapProcessor::setup_for_remap(HttpTransact::State *s)
if
Github user ericcarlschwartz closed the pull request at:
https://github.com/apache/trafficserver/pull/336
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user ericcarlschwartz commented on the pull request:
https://github.com/apache/trafficserver/pull/336#issuecomment-160693148
Am going to close this PR then. When TS-3612 is done I'll make the change
for this JIRA so that we've got this working in open source.
-
GitHub user ericcarlschwartz opened a pull request:
https://github.com/apache/trafficserver/pull/341
[TS-4031] Update docs to show new log fields
Just an update to the list so that it has new log fields documented.
You can merge this pull request into a Git repository by running
Github user ericcarlschwartz commented on the pull request:
https://github.com/apache/trafficserver/pull/317#issuecomment-156858474
Hey I noticed that when we made this documentation reorganization change we
lost a lot of log tags that had previously been in event-logging-formats
GitHub user ericcarlschwartz opened a pull request:
https://github.com/apache/trafficserver/pull/337
[TS-4024] wire tracing enhancements
This is a combo of three things:
1) Change I made to make wire tracing dynamically available.
2) A change from Susan to give better
GitHub user ericcarlschwartz opened a pull request:
https://github.com/apache/trafficserver/pull/336
[TS-4012] tcp_reused log field doesn't work for http2/spdy
JIRA: https://issues.apache.org/jira/browse/TS-4012
You can merge this pull request into a Git repository by ru
Github user ericcarlschwartz commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/293#discussion_r39430482
--- Diff: proxy/logging/Log.cc ---
@@ -478,7 +478,7 @@ Log::init_fields()
global_field_list.add(field, false
GitHub user ericcarlschwartz opened a pull request:
https://github.com/apache/trafficserver/pull/293
[TS-3911] Create log tag for server connection isSSL
Have tested this and provides the correct info.
You can merge this pull request into a Git repository by running:
$ git
Github user ericcarlschwartz commented on the pull request:
https://github.com/apache/trafficserver/pull/288#issuecomment-140151851
make sure that this will close #288 and #122
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user ericcarlschwartz commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/277#discussion_r39420551
--- Diff: ci/tsqa/tests/test_http2_spec.py ---
@@ -0,0 +1,114 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or
Github user ericcarlschwartz commented on the pull request:
https://github.com/apache/trafficserver/pull/290#issuecomment-139544846
@masaori335 ah thanks for this catch lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user ericcarlschwartz commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/289#discussion_r39201131
--- Diff: doc/admin/event-logging-formats.en.rst ---
@@ -511,6 +511,13 @@ The following list describes Traffic Server custom
logging fields
Github user ericcarlschwartz commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/289#discussion_r39200987
--- Diff: proxy/http/HttpSM.cc ---
@@ -5609,7 +5610,7 @@ HttpSM::attach_server_session(HttpServerSession *s)
hsm_release_assert
GitHub user ericcarlschwartz opened a pull request:
https://github.com/apache/trafficserver/pull/289
[TS-3900] Create log tag for server connection reuse
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ericcarlschwartz
GitHub user ericcarlschwartz opened a pull request:
https://github.com/apache/trafficserver/pull/288
[TS-3648] Desire support for client TLS cipher in custom log format
We had a crash at y! related to this change. Here are our fixes from myself
and @SolidWallOfCode
You can merge
GitHub user ericcarlschwartz opened a pull request:
https://github.com/apache/trafficserver/pull/281
[TS-3534] Wiretracing for SSL connections (doc change only)
Just a doc change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user ericcarlschwartz commented on the pull request:
https://github.com/apache/trafficserver/pull/258#issuecomment-123753341
Sounds good to me just wanted to make sure they both get closed out!
---
If your project is set up for it, you can reply to this email and have your
Github user ericcarlschwartz commented on the pull request:
https://github.com/apache/trafficserver/pull/255#issuecomment-123416518
looks good to me. to those who know better than I, is zero as a default log
value when no port is available standard?
---
If your project is set up for
Github user ericcarlschwartz commented on the pull request:
https://github.com/apache/trafficserver/pull/258#issuecomment-123413575
This looks like it's solving/a duplicate of
https://issues.apache.org/jira/browse/TS-2152
The code looks good to me too. If you'r
GitHub user ericcarlschwartz opened a pull request:
https://github.com/apache/trafficserver/pull/252
[TS-3648] Desire support for client TLS cipher in custom log format
Took @acaciocenteno's original PR here and updated it a bit:
https://github.com/apache/trafficserver/pul
GitHub user ericcarlschwartz opened a pull request:
https://github.com/apache/trafficserver/pull/250
[TS-3476] Add a log tag for application protocol (add docs)
Needed to add to the docs for TS-3476
You can merge this pull request into a Git repository by running:
$ git pull
Github user ericcarlschwartz commented on the pull request:
https://github.com/apache/trafficserver/pull/194#issuecomment-120100458
@shinrich rebased off apache/master and opened a new PR for this here. this
one had some weirdness because of issues w/ apache/master and yahoo/master
Github user ericcarlschwartz closed the pull request at:
https://github.com/apache/trafficserver/pull/194
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user ericcarlschwartz opened a pull request:
https://github.com/apache/trafficserver/pull/246
TS-3534 Wiretracing SSL Connections
Initial Commit
TS-3534 Cleanup before PR
remove tcp_info traces
fix sni server name
update rand mechanism and
Github user ericcarlschwartz commented on the pull request:
https://github.com/apache/trafficserver/pull/194#issuecomment-120092663
@ushachar @shinrich I tend to agree that having some simple stuff available
as records.config settings for those who don't want to write a new p
Github user ericcarlschwartz commented on the pull request:
https://github.com/apache/trafficserver/pull/244#issuecomment-120004282
@shinrich ah yeah I wasn't sure why it'd been dropped but I also can't see
any reason adding it back would introduce any problems eithe
GitHub user ericcarlschwartz opened a pull request:
https://github.com/apache/trafficserver/pull/244
[TS-3476] Add a log tag for application protocol
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yahoo/trafficserver TS-3476
Github user ericcarlschwartz commented on the pull request:
https://github.com/apache/trafficserver/pull/194#issuecomment-119674972
@shinrich I added it to set_context_cert because it looks like both the
ssl_servername_callback and ssl_cert_callback will call that and it saves some
Github user ericcarlschwartz commented on the pull request:
https://github.com/apache/trafficserver/pull/194#issuecomment-119357789
@shinrich here's a proposed solution:
if TS_USE_TLS_SNI isn't set then we put the logic where you'd suggested. if
it is, we set
Github user ericcarlschwartz commented on the pull request:
https://github.com/apache/trafficserver/pull/194#issuecomment-119345316
and for the non SNI-enabled case I can put it in the equivalent function in
the corresponding #else block
---
If your project is set up for it, you can
Github user ericcarlschwartz commented on the pull request:
https://github.com/apache/trafficserver/pull/194#issuecomment-119344998
@shinrich: did some testing there. the problem w/ putting it right in that
particular spot is that the return value from SSL_get_servername call will
Github user ericcarlschwartz commented on the pull request:
https://github.com/apache/trafficserver/pull/194#issuecomment-119295104
Ah yes I remember that part of things in terms of what's stored where, was
just wondering how that worked exactly since the ssl_vc is in the
Github user ericcarlschwartz commented on the pull request:
https://github.com/apache/trafficserver/pull/194#issuecomment-119275969
@shinrich ah ok thanks for the comments. I'll make that first change today.
w.r.t. the second comment will have to think more about it. be
Github user ericcarlschwartz commented on the pull request:
https://github.com/apache/trafficserver/pull/194#issuecomment-115050303
@shinrich I think this is ready for another look if you or someone else has
some time.
---
If your project is set up for it, you can reply to this
Github user ericcarlschwartz commented on the pull request:
https://github.com/apache/trafficserver/pull/182#issuecomment-114962737
@SolidWallOfCode. I think there was some discussion of that on the JIRA,
actually (toward the top). I was of the mindset that that made more sense too
Github user ericcarlschwartz commented on the pull request:
https://github.com/apache/trafficserver/pull/200#issuecomment-112148392
hey @zwoop, this is a header rewrite enhancement we talked about a few
weeks ago to allow for the transact-count to be used as a condition. when
you&#x
Github user ericcarlschwartz commented on the pull request:
https://github.com/apache/trafficserver/pull/154#issuecomment-111560289
this has been finished (different PR w/ commits all squashed down to 1).
---
If your project is set up for it, you can reply to this email and have
Github user ericcarlschwartz closed the pull request at:
https://github.com/apache/trafficserver/pull/154
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user ericcarlschwartz commented on the pull request:
https://github.com/apache/trafficserver/pull/194#issuecomment-105593729
@RolandZink, yeah that's what I was thinking. I will do some searching and
see if something like that's been done before and how wireshark w
Github user ericcarlschwartz commented on the pull request:
https://github.com/apache/trafficserver/pull/194#issuecomment-105585945
I've dropped the tcp_info traces.
My understanding was in line with @sudheerv's that this was never intended
as a total replacemen
Github user ericcarlschwartz commented on the pull request:
https://github.com/apache/trafficserver/pull/194#issuecomment-105575893
@sudheerv: the TCP_INFO usage can definitely be dropped because of the
associated cost/its only situational usefulness. i will prepare a patch with it
GitHub user ericcarlschwartz opened a pull request:
https://github.com/apache/trafficserver/pull/200
[TS-3589] Enhance header_rewrite to support TRANSACT-COUNT as a condiâ¦
â¦tion
TS-3589 fixes
fixes
You can merge this pull request into a Git repository by
Github user ericcarlschwartz commented on the pull request:
https://github.com/apache/trafficserver/pull/198#issuecomment-101064281
The api references transact-count but if we think txn count is better i can
change it.
https://docs.trafficserver.apache.org/en/latest/api
Github user ericcarlschwartz closed the pull request at:
https://github.com/apache/trafficserver/pull/198
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user ericcarlschwartz opened a pull request:
https://github.com/apache/trafficserver/pull/198
[TS-3589] Enhance header_rewrite to support TRANSACT-COUNT as a condiâ¦
â¦tion
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user ericcarlschwartz commented on the pull request:
https://github.com/apache/trafficserver/pull/194#issuecomment-97163497
Right now this PR is multiple commits. I'll probably be adding to it as
people have suggestions for improvement. I can squash stuff down before
any
GitHub user ericcarlschwartz opened a pull request:
https://github.com/apache/trafficserver/pull/194
Ts 3534
Initial pull request for wiretracing v0. Please leave me your comments and
I'll make changes as necessary.
Looking into this now: Making sure we turn tracin
Github user ericcarlschwartz commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/182#discussion_r26780512
--- Diff: proxy/http/HttpSM.cc ---
@@ -4622,16 +4623,16 @@ HttpSM::do_http_server_open(bool raw)
ink_assert(pending_action == NULL
Github user ericcarlschwartz commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/182#discussion_r26780467
--- Diff: proxy/http/HttpSM.cc ---
@@ -4622,16 +4623,16 @@ HttpSM::do_http_server_open(bool raw)
ink_assert(pending_action == NULL
Github user ericcarlschwartz commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/182#discussion_r26780087
--- Diff: proxy/http/HttpTransact.cc ---
@@ -5453,13 +5455,16 @@ void
HttpTransact::initialize_state_variables_for_origin_server(State* s
Github user ericcarlschwartz commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/182#discussion_r26780171
--- Diff: proxy/http/HttpTransact.h ---
@@ -698,16 +698,11 @@ class HttpTransact
bool dns_round_robin;
TransferEncoding_t
Github user ericcarlschwartz commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/182#discussion_r26780107
--- Diff: proxy/http/HttpTransact.cc ---
@@ -5522,7 +5527,10 @@
HttpTransact::initialize_state_variables_from_request(State* s, HTTPHdr
Github user ericcarlschwartz commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/182#discussion_r26779989
--- Diff: proxy/http/HttpTransact.cc ---
@@ -288,6 +288,8 @@
find_server_and_update_current_info(HttpTransact::State* s)
/* fall
Github user ericcarlschwartz commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/182#discussion_r26779947
--- Diff: proxy/http/HttpTransact.cc ---
@@ -288,6 +288,8 @@
find_server_and_update_current_info(HttpTransact::State* s)
/* fall
Github user ericcarlschwartz commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/182#discussion_r26779726
--- Diff: proxy/http/HttpSM.cc ---
@@ -549,8 +549,9 @@ HttpSM::attach_client_session(HttpClientSession *
client_vc, IOBufferReader * bu
GitHub user ericcarlschwartz opened a pull request:
https://github.com/apache/trafficserver/pull/182
[TS-2157] Replace addr with src_addr and dst_addr
This is largely a renaming of existing conventions--there are a few areas
I've highlighted w/ comments.
merge o
Github user ericcarlschwartz closed the pull request at:
https://github.com/apache/trafficserver/pull/157
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user ericcarlschwartz commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/172#discussion_r25563097
--- Diff: ci/new_tsqa/tests/test_spdy_protocol_select.py ---
@@ -0,0 +1,141 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user ericcarlschwartz commented on the pull request:
https://github.com/apache/trafficserver/pull/172#issuecomment-76457517
Updated tests per comments from @jacksontj.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user ericcarlschwartz commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/172#discussion_r25522007
--- Diff: ci/new_tsqa/tests/test_spdy_protocol_select.py ---
@@ -0,0 +1,141 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user ericcarlschwartz commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/172#discussion_r25521956
--- Diff: ci/new_tsqa/tests/test_spdy_protocol_select.py ---
@@ -0,0 +1,141 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user ericcarlschwartz commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/172#discussion_r25511739
--- Diff: ci/new_tsqa/tests/test_spdy_protocol_select.py ---
@@ -0,0 +1,141 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user ericcarlschwartz commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/172#discussion_r25487698
--- Diff: ci/new_tsqa/tests/test_spdy_protocol_select.py ---
@@ -0,0 +1,141 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user ericcarlschwartz commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/172#discussion_r25487677
--- Diff: ci/new_tsqa/tests/test_spdy_protocol_select.py ---
@@ -0,0 +1,141 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user ericcarlschwartz commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/172#discussion_r25487671
--- Diff: ci/new_tsqa/tests/test_spdy_protocol_select.py ---
@@ -0,0 +1,141 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user ericcarlschwartz commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/172#discussion_r25487624
--- Diff: ci/new_tsqa/tests/test_spdy_protocol_select.py ---
@@ -0,0 +1,141 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user ericcarlschwartz commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/172#discussion_r25487614
--- Diff: ci/new_tsqa/tests/test_spdy_protocol_select.py ---
@@ -0,0 +1,141 @@
+# Licensed to the Apache Software Foundation (ASF) under
GitHub user ericcarlschwartz opened a pull request:
https://github.com/apache/trafficserver/pull/172
[TS-3396] new tsqa_spdy protocol selection tests
updated PR. this one has no cert. uses existing cert generated by @jacksontj
You can merge this pull request into a Git repository
Github user ericcarlschwartz closed the pull request at:
https://github.com/apache/trafficserver/pull/171
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user ericcarlschwartz opened a pull request:
https://github.com/apache/trafficserver/pull/171
[TS-3396] new_tsqa SPDY protocol selection tests
simple spdy protocol selection tests
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user ericcarlschwartz opened a pull request:
https://github.com/apache/trafficserver/pull/157
[TS-2157] Replace "addr" with appropriate "src_addr" and "dst_addr" in
ConnectionAttributes
Have made initial changes. No added functionality as of y
GitHub user ericcarlschwartz opened a pull request:
https://github.com/apache/trafficserver/pull/154
TS-1461
JIRA Ticket: https://issues.apache.org/jira/browse/TS-1461
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yahoo
76 matches
Mail list logo
