Re: [E] Re: Proposed change to TS API: TSHeapBuf

2023-01-04 Thread Walt Karas
I'll wait a couple more days for input, then I'll change it to return char * and take an int * parameter to output the length. If we're switching to C++, we can update this based on whatever consensus we reach for the switchover strategy. On Wed, Jan 4, 2023 at 7:03 PM Masakazu Kitajo wrote: >

Re: [E] Re: Proposed change to TS API: TSHeapBuf

2023-01-04 Thread Masakazu Kitajo
> They could make the returned structure a nesting structure in their structure. What if the structure is defined by a library and a plugin author can't modify it? What I'm trying to say is that I don't see the benefit of limiting how a user receives the pointer and the length where nothing receiv

Re: [E] Proposed change to TS API: TSHeapBuf

2023-01-04 Thread Walt Karas
Oh yeah I forgot, isn't a big reason to keep the TS API as C that it allows you to write programs in Rust? And can proxy-wasm handle it OK if the TS API is in C++? How about callbacks from Lua scripts being run by the Lua plugin? On Wed, Jan 4, 2023 at 4:26 PM Leif Hedstrom wrote: > > > > On J

Re: [E] Proposed change to TS API: TSHeapBuf

2023-01-04 Thread Leif Hedstrom
> On Jan 4, 2023, at 3:03 PM, Walt Karas wrote: > > There are people at Yahoo who have written plugins in straight C, and don't > want to change to C++. They can continue to write plugins in C, just have to compile with a C++ compiler. I imagine there will be very few, if any changes. Of cou

Re: [E] Re: Proposed change to TS API: TSHeapBuf

2023-01-04 Thread Walt Karas
There are people at Yahoo who have written plugins in straight C, and don't want to change to C++. On Wed, Jan 4, 2023 at 1:10 PM Leif Hedstrom wrote: > This looks like a string_view to me? > > Why don’t we do what we talked about for years now, and stop supporting > compiling plug-ins with C bu

Re: [E] Re: Proposed change to TS API: TSHeapBuf

2023-01-04 Thread Leif Hedstrom
This looks like a string_view to me? Why don’t we do what we talked about for years now, and stop supporting compiling plug-ins with C but require C++? Then we can introduce nice things in ts.h. The old C plugins just have to be changed to compile with C++, and ABI compatibility within major v

Re: [E] Re: Proposed change to TS API: TSHeapBuf

2023-01-04 Thread Walt Karas
They could make the returned structure a nesting structure in their structure. Better to make things more convenient for the typical case, not the unusual case. On Tue, Jan 3, 2023 at 12:28 PM Masakazu Kitajo wrote: > What's the benefit of forcing users to use the structure? A user might want >