Re: [DISCUSS] Following redirects to 'localhost'

2018-08-23 Thread Derek Dagit
OK I think we can converge on the PR now: https://github.com/apache/trafficserver/pull/4145#issuecomment-415647049 I expect more iterations. On Thu, Aug 23, 2018 at 8:52 PM, Derek Dagit wrote: > Thanks, working on it. > > On Thu, Aug 23, 2018 at 6:19 PM, Bryan Call wrote: > >> Inline >> >> -Br

Re: [DISCUSS] Following redirects to 'localhost'

2018-08-23 Thread Derek Dagit
Thanks, working on it. On Thu, Aug 23, 2018 at 6:19 PM, Bryan Call wrote: > Inline > > -Bryan > > > On Aug 22, 2018, at 11:37 AM, Derek Dagit > wrote: > > > > Bryan, some clarification questions: > > > > > >> 2. 403 > > > > What should we do on the N+1st redirect? Do we try to resolve the targe

Re: Dealing with reverts on master

2018-08-23 Thread Derek Dagit
OK let me draft something for the wiki... On Thu, Aug 23, 2018 at 5:50 PM, Bryan Call wrote: > Sounds good, want to create one? > > -Bryan > > > > > On Aug 22, 2018, at 11:44 AM, Derek Dagit > wrote: > > > > +1 > > > > My cheat sheet for these rules is growing lengthy. Would it be a good > idea

Re: [DISCUSS] Following redirects to 'localhost'

2018-08-23 Thread Bryan Call
Inline -Bryan > On Aug 22, 2018, at 11:37 AM, Derek Dagit wrote: > > Bryan, some clarification questions: > > >> 2. 403 > > What should we do on the N+1st redirect? Do we try to resolve the target > host and 403 that too, or just return it to the client regardless of how it > resolves? > >

Re: Dealing with reverts on master

2018-08-23 Thread Bryan Call
Sounds good, want to create one? -Bryan > On Aug 22, 2018, at 11:44 AM, Derek Dagit wrote: > > +1 > > My cheat sheet for these rules is growing lengthy. Would it be a good idea > to publish to the wiki? > > On Wed, Aug 22, 2018 at 1:23 PM, Bryan Call wrote: > >> +1 - sounds good >> >> -B

Re: Hash containers - some thoughts and recommendations

2018-08-23 Thread Bryan Call
Memory allocations on inserting items is a property of the hash table, not if it is intrusive vs non-intrusive (however, intrusive is this way by default). Performance on a better designed hash table would be many times faster on find, so even having to do a double find on delete isn’t a perfor

Re: Hash containers - some thoughts and recommendations

2018-08-23 Thread Alan Carroll
1) Because you can insert the same object, rather than pointers to the same object. In addition to fewer memory allocations (zero vs 2), it makes finding the object in the second hash table very fast - no search required (see IntrusiveHashMap::iterator_for). It also simplifies key management, becau

Re: Hash containers - some thoughts and recommendations

2018-08-23 Thread Bryan Call
1. How does a intrusive hash table solve the problem with having multiple indexes? You still have to insert the object to both hash tables. 2. It would be good to call out all the hash containers that are used instead of saying plethora. From what I see in the code we have these. InkHas

Re: [ANNOUNCE] Apache Traffic Server Summit Fall 2018

2018-08-23 Thread Bryan Call
The ATS Fall Summit is little over a month away! Please sign up before the event, so we can plan on how many people are attending. LinkedIn has graciously accepted to host the event at their office. Details are on the Summit page: https://cwiki.apache.org/confluence/display/TS/Fall+20