Re: [Dependency Proposal] intel::tbb

2017-09-29 Thread CrazyCow
Yea, I looked into Junction before tbb, until I found this comment on hacker news. Uhm... The absolute Y-position of the curve on the graph is secondary to > its shape. Also, the scalability discussion is largely pointless if the > sample set covers only 6 CPUs. > Intel TBB scales proportionally,

Re: [Dependency Proposal] intel::tbb

2017-09-29 Thread Jason Kenny
interesting to not the junction make will use TBB under the covers... for example: https://github.com/preshing/junction/blob/14c0b8f835d26899c22eb7e747ccdffb775c49f2/junction/extra/impl/MapAdapter_TBB.h On Fri, Sep 29, 2017 at 5:13 PM, Bryan Call wrote: > Here are some benchmark numbers I ran ac

Re: [Dependency Proposal] intel::tbb

2017-09-29 Thread Bryan Call
Here are some benchmark numbers I ran across when looking at different thread safe hash implementations: Source: http://preshing.com/20160201/new-concurrent-hash-maps-for-cpp/ -Bryan > On Sep 29, 2017, at 2:42 PM, Bryan Call

Re: [Dependency Proposal] intel::tbb

2017-09-29 Thread Bryan Call
TCL handles concurrency for memory allocation bits. Looking at it more, the hashtable part of the library doesn’t support currency and you would have to handle locking yourself. I created a test program to see when it was locking: #include "ink_hash_table.h" #include #include using namespace

Re: [Dependency Proposal] intel::tbb

2017-09-29 Thread CrazyCow
I read the code of Tcl_HashTable. They say nothing about handling concurrency. The biggest concern about this is, as Alan and Bryan said, what level of use will we have for ATS. I read docs of TBB. It's offering rich tools of handling t

Re: [Dependency Proposal] intel::tbb

2017-09-29 Thread Bryan Call
This seems like a large dependency to pull in to get a thread safe unordered map. We already have a dependency on Tcl_HashTable (InkHashTable), that handles concurrency, and it used throughout the code base. -Bryan > On Sep 28, 2017, at 5:55 PM, CrazyCow wrote: > > Hi, ATS devs, > > Curre

Re: [Dependency Proposal] intel::tbb

2017-09-29 Thread CrazyCow
Seems the latest version supports FreeBSD and SunOS. https://github.com/01org/tbb/blob/tbb_2018/build/FreeBSD.inc https://github.com/01org/tbb/blob/tbb_2018/build/SunOS.inc 2017-09-29 8:26 GMT-07:00 James Peach : > > > On Sep 29, 2017, at 7:37 AM, Derek Dagit > wrote: > > > > 3) Does it run on p

Re: [Dependency Proposal] intel::tbb

2017-09-29 Thread James Peach
> On Sep 29, 2017, at 7:37 AM, Derek Dagit wrote: > > 3) Does it run on platforms that are supported by ATS, like FreeBSD? I > thought there was not official support without patching it, but not > sure. https://www.threadingbuildingblocks.org/system-requirements AFAICT they claim x86-only and

Re: [Dependency Proposal] intel::tbb

2017-09-29 Thread Derek Dagit
3) Does it run on platforms that are supported by ATS, like FreeBSD? I thought there was not official support without patching it, but not sure. On Thu, Sep 28, 2017 at 7:58 PM, Alan Carroll wrote: > There are two big issues for me: > > 1) What level of use will we have in the rest of the ATS cor