I read the code of Tcl_HashTable. They say nothing about handling concurrency.
The biggest concern about this is, as Alan and Bryan said, what level of use will we have for ATS. I read docs <https://www.threadingbuildingblocks.org/docs/help/index.htm> of TBB. It's offering rich tools of handling threading issues. We can look into it more to see if there are other utilities appealing. Generally speaking, nice docs, good reputation, and upcoming new releases are signs of tbb being a good choice. 2017-09-29 12:11 GMT-07:00 Bryan Call <bc...@apache.org>: > This seems like a large dependency to pull in to get a thread safe > unordered map. We already have a dependency on Tcl_HashTable > (InkHashTable), that handles concurrency, and it used throughout the code > base. > > -Bryan > > > > On Sep 28, 2017, at 5:55 PM, CrazyCow <zhangzizhong0...@gmail.com> wrote: > > Hi, ATS devs, > > Currently, we have a requirement of concurrent_unordered_map (details can > be found https://github.com/apache/trafficserver/pull/2555). And > intel::tbb::concurrent_unordered_map is the most mature one we can try > out. > I understand this dependency is huge. I'd like to hear opinions from you > guys, that whether we need to do it or not and if yes, what is the best > approach to introduce it. > > > Thanks, > Zizhong > > >
