Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/763
Some sort of odd race condition here maybe. If I run single requests using
curl, I'm not seeing the problem. But if I blast it with "ab -c 10 -n 1"
the counter permanently bumps up by 10,000
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/763
So, I tried this patch, and it does not fix the problem I'm running into,
where proxy.process.http.current_active_client_connections is seemingly never
decremented. I had a merge conflict, but I
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/763#discussion_r69666098
--- Diff: proxy/http/HttpSM.cc ---
@@ -200,7 +200,8 @@ HttpVCTable::cleanup_entry(HttpVCTableEntry *e)
// Update stats
switch (e->vc_typ
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/783#discussion_r69650806
--- Diff: proxy/http/HttpTransact.cc ---
@@ -63,7 +63,12 @@ static char range_type[] = "multipart/byteranges;
boundary=RANGE_SEPARATOR";
exter
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/783#discussion_r69649977
--- Diff: proxy/http/HttpTransact.cc ---
@@ -63,7 +63,12 @@ static char range_type[] = "multipart/byteranges;
boundary=RANGE_SEPARATOR";
exter
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/783#discussion_r69647327
--- Diff: proxy/StatPages.cc ---
@@ -83,7 +83,7 @@ StatPagesManager::handle_http(Continuation *cont, HTTPHdr
*header)
host_len = unescapif
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/783#discussion_r69640431
--- Diff: proxy/StatPages.cc ---
@@ -83,7 +83,7 @@ StatPagesManager::handle_http(Continuation *cont, HTTPHdr
*header)
host_len = unescapi
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/783#discussion_r69640193
--- Diff: proxy/StatPages.cc ---
@@ -83,7 +83,7 @@ StatPagesManager::handle_http(Continuation *cont, HTTPHdr
*header)
host_len = unescapif
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/787
Is is possible to break the addditional fixes out into separate tickets and
PRs?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/783#discussion_r69635990
--- Diff: proxy/StatPages.cc ---
@@ -83,7 +83,7 @@ StatPagesManager::handle_http(Continuation *cont, HTTPHdr
*header)
host_len = unescapi
Github user strotyl commented on the issue:
https://github.com/apache/trafficserver/pull/783
Thanks for the feedback jpeach. I've made some updates.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/783#discussion_r69613350
--- Diff: proxy/StatPages.cc ---
@@ -83,7 +83,7 @@ StatPagesManager::handle_http(Continuation *cont, HTTPHdr
*header)
host_len = unescapi
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/783#discussion_r69611852
--- Diff: proxy/http/HttpTransact.cc ---
@@ -762,8 +762,8 @@ HttpTransact::StartRemapRequest(State *s)
const char syntxt[] = "synthetic.txt";
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/783#discussion_r69611157
--- Diff: proxy/http/HttpTransact.cc ---
@@ -762,8 +762,8 @@ HttpTransact::StartRemapRequest(State *s)
const char syntxt[] = "synthetic.txt"
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/786#discussion_r69609382
--- Diff: proxy/http/HttpSM.cc ---
@@ -1954,9 +1954,7 @@ HttpSM::state_read_server_response_header(int event,
void *data)
t_state.api_next_acti
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/786#discussion_r69606800
--- Diff: proxy/http/HttpSM.cc ---
@@ -7618,6 +7616,8 @@ HttpSM::do_redirect()
return;
}
+ redirection_tries++;
+
---
Github user strotyl commented on the issue:
https://github.com/apache/trafficserver/pull/783
OK, ready for review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wis
Github user strotyl commented on the issue:
https://github.com/apache/trafficserver/pull/783
Wait to build this. I found a problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
18 matches
Mail list logo
