Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/783#discussion_r69611852
--- Diff: proxy/http/HttpTransact.cc ---
@@ -762,8 +762,8 @@ HttpTransact::StartRemapRequest(State *s)
const char syntxt[] = "synthetic.txt";
- s->cop_test_page = (ptr_len_cmp(host, host_len, local_host_ip_str,
sizeof(local_host_ip_str) - 1) == 0) &&
- (ptr_len_cmp(path, path_len, syntxt, sizeof(syntxt) -
1) == 0) &&
+ s->cop_test_page = (host_len == sizeof(local_host_ip_str) - 1) &&
(path_len == sizeof(syntxt) - 1) &&
+ (memcmp(host, local_host_ip_str, host_len) == 0) &&
(memcmp(path, syntxt, path_len) == 0) &&
--- End diff --
That feels that it's orthogonal from this Jira / PR, and could be moved to
a different Jira. But up to Tyler to decide IMO.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
