Github user masaori335 commented on the issue:
https://github.com/apache/trafficserver/pull/593
I updated PO files in 0ebfab01d909bcd0d99cd2f8fb2f816916bc80f3.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/770
Linux build *failed*! See
https://ci.trafficserver.apache.org/job/Github-Linux/283/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/770
FreeBSD build *failed*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/387/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/770
@zwoop @PSUdaemon
Please take this for a spin, but let's not merge yet. It looks like
``clang-tidy`` still get various build errors which cause it to eat code in
unfortunate ways.
-
GitHub user jpeach opened a pull request:
https://github.com/apache/trafficserver/pull/770
Integrate clang-tidy into the build.
Add a recursive tidy rule to run clang-tidy over all the source.
The mor recommended way to do this is to build a compilation database,
however the
blockquote, div.yahoo_quoted { margin-left: 0 !important; border-left:1px
#715FFA solid !important; padding-left:1ex !important; background-color:white
!important; } I think this config was introduced to ensure "backward"
compatibility, since we wanted to block/reject non HTTP responses, but th
Github user masaori335 closed the pull request at:
https://github.com/apache/trafficserver/pull/733
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
(This is discussed in https://issues.apache.org/jira/browse/TS-4405).
This option, proxy.config.http.parse.allow_non_http, allows the response parser
to not require HTTP/n.m in the response. I don’t know when this is useful any
more, likely this is a remnant from either old servers, or old proto
Github user masaori335 closed the pull request at:
https://github.com/apache/trafficserver/pull/767
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/723
@jpeach Hmmm, what happened here, did we not land this? I have lost my
mind, and do not remember ...
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/745
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/747
Any thoughts on this ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wish
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/740
@SolidWallOfCode I filed
[TS-4574](https://issues.apache.org/jira/browse/TS-4574) to clear the explicit
address. However now that I know a bit more about how the DNS resolutions
works, the pat
Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/740
I think this should be OK. I was concerned about its interaction with
transparency but the `os_addr_style` values are set up to avoid that (e.g. that
can be moved to values that preven
GitHub user kawaiirice opened a pull request:
https://github.com/apache/trafficserver/pull/769
TS 4593: Extend ip_allow.config to filter destination IPs
Documentation for extending ip_allow.config to filter destination IP
addresses, as proposed by Edge.
Do not merge: This
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/744
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/749
Yeah, I need to work on this some more, not sure exactly yet what path to
take yet. We have some options :). I'd like to keep this open, so we retain the
feedback.
---
If your project is set u
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/749
It should be conditional on the 304 in the build_error_response and also
added to build_response. Maybe pull the logic into a method and call it from
both.
---
If your project is set up f
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/749#discussion_r69032683
--- Diff: proxy/http/HttpTransact.cc ---
@@ -8199,13 +8199,15 @@ HttpTransact::build_error_response(State *s,
HTTPStatus status_code, const char
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/749#discussion_r69032591
--- Diff: proxy/http/HttpTransact.cc ---
@@ -8199,13 +8199,15 @@ HttpTransact::build_error_response(State *s,
HTTPStatus status_code, const char
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/733
ð Looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishe
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/760
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/748
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/386/ for details.
---
If your project is set up for it, you can reply to this email and have your
r
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/748
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/282/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/748#discussion_r69008502
--- Diff: plugins/healthchecks/healthchecks.c ---
@@ -301,8 +301,22 @@ parse_configs(const char *fname)
char buf[2 * 1024];
HCFileInfo *head
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/766
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/281/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/762
clang-format
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/766
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/385/ for details.
---
If your project is set up for it, you can reply to this email and have your
r
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/765
Bike shedding and side-tracking a bit, but we should encourage to not use
the pattern
if (foo)
delete foo;
it should be just
delete foo;
---
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/739
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/739
@SolidWallOfCode decided that we should keep this, so closing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/766
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/767
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
Github user jpeach closed the pull request at:
https://github.com/apache/trafficserver/pull/757
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user persiaAziz commented on the issue:
https://github.com/apache/trafficserver/pull/757
Unfortunately the machine I am working on can not find a later version. I
will probably try later when I have my own machine. I think it is better if you
merge this as is for now.
---
If
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/741
Abandoning this PR for now. Will go back and look into getting
``clang-tidy`` support into the build system.
---
If your project is set up for it, you can reply to this email and have your
rep
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/757
Yup
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
Github user persiaAziz commented on the issue:
https://github.com/apache/trafficserver/pull/757
needs an update?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishe
Github user persiaAziz commented on the issue:
https://github.com/apache/trafficserver/pull/757
`checking for sphinx version >= 1.1... found 0.6.6`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/757
What is the output of ``python ./doc/checkvers.py --check-version``?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user persiaAziz commented on the issue:
https://github.com/apache/trafficserver/pull/757
Yes I just did. But still getting the same error.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/757
Do you have the ``sphinx-doc`` package installed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/745
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/280/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user persiaAziz commented on the issue:
https://github.com/apache/trafficserver/pull/757
I tried to build the documentation using the following link
[https://docs.trafficserver.apache.org/en/latest/developer-guide/documentation/building.en.html](https://docs.trafficserver.a
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/745
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/384/ for details.
---
If your project is set up for it, you can reply to this email and have your
r
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/745#discussion_r68974323
--- Diff: plugins/experimental/xdebug/xdebug.cc ---
@@ -234,6 +237,20 @@ InjectMilestonesHeader(TSHttpTxn txn, TSMBuffer
buffer, TSMLoc hdr)
}
GitHub user jacksontj opened a pull request:
https://github.com/apache/trafficserver/pull/768
TS-4615 set SRV scheme based on next_hop_scheme
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jacksontj/trafficserver TS-4615
Altern
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/745#discussion_r68973675
--- Diff: plugins/experimental/xdebug/xdebug.cc ---
@@ -234,6 +237,20 @@ InjectMilestonesHeader(TSHttpTxn txn, TSMBuffer
buffer, TSMLoc hdr)
}
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/765
@jpeach points out that the existing code should recursively free the chain
of port objects. So we are not understanding the leak case. How did you
detect this leak? And can you link the J
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/757
@zwoop I'm going to merge this as is for now, ok?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/701
I think that I agree with @jpeach's comments and code suggestion.
Returning _EOS really only makes sense for read. I think by the time you get
to that point in the code it is a failure.
-
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/748#discussion_r68971045
--- Diff: plugins/healthchecks/healthchecks.c ---
@@ -301,8 +301,22 @@ parse_configs(const char *fname)
char buf[2 * 1024];
HCFileInfo *hea
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/748#discussion_r68970820
--- Diff: plugins/healthchecks/healthchecks.c ---
@@ -301,8 +301,22 @@ parse_configs(const char *fname)
char buf[2 * 1024];
HCFileInfo *hea
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/701
@oknet the SSL_write logic is handled in SSLUtils/SSLNetVConnection. The
openssl library does its own read/write for the most part, and that logic
handles the SSL_ERROR_WANT_READ case. In t
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/752
Ok, that makes sense. Looks good then. I can merge up later today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user shinrich commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/754#discussion_r68956117
--- Diff: iocore/net/UnixNetVConnection.cc ---
@@ -556,13 +556,17 @@ write_to_net_io(NetHandler *nh, UnixNetVConnection
*vc, EThread *thread)
Github user shinrich commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/754#discussion_r68947581
--- Diff: iocore/net/UnixNetVConnection.cc ---
@@ -573,17 +577,18 @@ write_to_net_io(NetHandler *nh, UnixNetVConnection
*vc, EThread *thread)
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/765
Looks reasonable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user shinrich commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/766#discussion_r68942583
--- Diff: iocore/net/UnixNet.cc ---
@@ -682,8 +682,9 @@ NetHandler::_close_vc(UnixNetVConnection *vc,
ink_hrtime now, int &handle_event,
// c
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/767
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/278/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/767
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/382/ for details.
---
If your project is set up for it, you can reply to this email and have your
r
GitHub user masaori335 opened a pull request:
https://github.com/apache/trafficserver/pull/767
TS-4605: fix Coverity issue 1357058
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/masaori335/trafficserver ts-4605
Alternatively yo
Github user yishimur closed the pull request at:
https://github.com/apache/trafficserver/pull/664
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
GitHub user oknet opened a pull request:
https://github.com/apache/trafficserver/pull/766
TS-4614: avoid e->schedule_in for dummy event
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/oknet/trafficserver TS-4614
Alternatively yo
GitHub user zhouxiangxiang opened a pull request:
https://github.com/apache/trafficserver/pull/765
Update HttpConfig.h
memory leak
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhouxiangxiang/trafficserver patch-2
Alternatively
65 matches
Mail list logo
