Github user oknet closed the pull request at:
https://github.com/apache/trafficserver/pull/665
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user oknet commented on the issue:
https://github.com/apache/trafficserver/pull/665
@jpeach create a new PR#734 base on master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
GitHub user oknet opened a pull request:
https://github.com/apache/trafficserver/pull/734
TS-4483: NetAccept & SSLNetAccept optimize, replace getEtype() with mâ¦
â¦ember etype.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/okn
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/665
This looks very reasonable to me. @oknet can you please rebase onto master?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/733
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/224/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/733
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/330/ for details.
---
If your project is set up for it, you can reply to this email and have your
r
Github user masaori335 commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/733#discussion_r68175695
--- Diff: proxy/http2/Http2ClientSession.h ---
@@ -94,63 +89,60 @@ class Http2Frame
{
this->ioblock = new_IOBufferBlock();
t
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/733
ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/733#discussion_r68171753
--- Diff: proxy/http2/Http2ClientSession.h ---
@@ -65,16 +65,11 @@ class Http2Frame
public:
Http2Frame(const Http2FrameHeader &h, IOBufferRea
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/733#discussion_r68171726
--- Diff: proxy/http2/Http2ClientSession.h ---
@@ -94,63 +89,60 @@ class Http2Frame
{
this->ioblock = new_IOBufferBlock();
this-
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/733#discussion_r68171203
--- Diff: proxy/http2/Http2ClientSession.h ---
@@ -94,63 +89,60 @@ class Http2Frame
{
this->ioblock = new_IOBufferBlock();
this-
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/733
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/223/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/733
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/329/ for details.
---
If your project is set up for it, you can reply to this email and have your
r
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/733
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/328/ for details.
---
If your project is set up for it, you can reply to this email and have your
r
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/733
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/222/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user masaori335 opened a pull request:
https://github.com/apache/trafficserver/pull/733
TS-4324: Allocate 16KB for DATA frame payload exactly
- [TS-4324
comment-15313205](https://issues.apache.org/jira/browse/TS-4324?focusedCommentId=15313205&page=com.atlassian.jira.plugin.sy
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/221/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/327/ for details.
---
If your project is set up for it, you can reply to this email and have your
r
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/220/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user calavera commented on the issue:
https://github.com/apache/trafficserver/pull/732
I'll try following the generator example to see if I can make this better.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/732
I'd have to think about this. Fwiw, the way I had envisioned to rewrite
this is to change it to a TxnServer intercept, instead of a Txn intercept. If
you look at e.g. the generator plugin (which
Github user PSUdaemon closed the pull request at:
https://github.com/apache/trafficserver/pull/728
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
Github user PSUdaemon closed the pull request at:
https://github.com/apache/trafficserver/pull/727
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/727
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/219/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/727
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/325/ for details.
---
If your project is set up for it, you can reply to this email and have your
r
GitHub user calavera opened a pull request:
https://github.com/apache/trafficserver/pull/732
[TS-4270] Make stats_over_http a remap plugin.
I'm opening this Pull Request to get feedback about the current remap
behavior.
I'd like to restrict all access to the stats over http
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/218/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/324/ for details.
---
If your project is set up for it, you can reply to this email and have your
r
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/728
Fwiw, this is where I completely disagree with jpeach, an assert with side
effects is simply wrong. Even if it's a release assert. I'd be ok if we changed
the name of the TSReleaseAssert() to so
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/717
@shinrich I'd really like to see some exhaustive code comments about how
transaction destruction is supposed to work and how to operate this machinery.
Just looking at the diff it really looks
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/217/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/717#discussion_r68083417
--- Diff: proxy/ProxyClientTransaction.h ---
@@ -174,10 +174,10 @@ class ProxyClientTransaction : public VConnection
return true;
}
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/323/ for details.
---
If your project is set up for it, you can reply to this email and have your
r
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/717#discussion_r68082470
--- Diff: proxy/http/Http1ClientSession.cc ---
@@ -82,11 +82,21 @@ Http1ClientSession::Http1ClientSession()
void
Http1ClientSession::destroy()
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/730
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/731
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/717#discussion_r68081721
--- Diff: proxy/http/Http1ClientSession.h ---
@@ -181,7 +189,12 @@ class Http1ClientSession : public ProxyClientSession
MIOBuffer *read_buff
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/216/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
I talked to Phil about this. Since 6.2 will release soon, I will stick with
current version
For the moment and will try to upgrade to that release later.
Thank James, Leif and Phil!
On 6/20/16, 2:39 PM, "James Peach" wrote:
>
>> On Jun 20, 2016, at 10:31 AM, Ye, Hong wrote:
>>
>> Does
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/727
@PSUdaemon do you want to change the ``sprintf`` to ``snprintf`` while you
are changing this function?
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/727
This should probably get back ported to 6.2.0 right ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/728
My preference you be to just ``TSReleaseAssert`` this, but it does look
like the plugin handles a ``NULL`` hostname, so ð
---
If your project is set up for it, you can reply to this email
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/728
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
Github user jacksontj commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/653#discussion_r68080987
--- Diff: proxy/http/HttpTransact.h ---
@@ -1121,7 +1121,7 @@ class HttpTransact
via_string[MAX_VIA_INDICES] = '\0';
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/730
ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/322/ for details.
---
If your project is set up for it, you can reply to this email and have your
r
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/730
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/731
ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/731
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/653#discussion_r68079937
--- Diff: iocore/hostdb/I_HostDBProcessor.h ---
@@ -361,7 +361,13 @@ struct HostDBRoundRobin {
unsigned short current;
ink_time_t timed_rr_
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/653#discussion_r68079215
--- Diff: proxy/http/HttpTransact.h ---
@@ -1121,7 +1121,7 @@ class HttpTransact
via_string[MAX_VIA_INDICES] = '\0';
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/321/ for details.
---
If your project is set up for it, you can reply to this email and have your
r
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/320/ for details.
---
If your project is set up for it, you can reply to this email and have your
r
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
Linux build *failed*! See
https://ci.trafficserver.apache.org/job/Github-Linux/215/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
Linux build *failed*! See
https://ci.trafficserver.apache.org/job/Github-Linux/214/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
Linux build *failed*! See
https://ci.trafficserver.apache.org/job/Github-Linux/213/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
FreeBSD build *failed*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/319/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Another thought would be to pause via send response headers, it won't pause
the incoming data but it will guarantee that the client doesn't see
anything until you're done and have done a setOutputComplete() followed by
a transaction.resume(). This would allow you to do any kind of long running
or a
Is this analysis some horrifically long running thing that cannot happen in
the same thread? That might be the only reason I can think of for needed a
pause...
Brian
On Wednesday, June 22, 2016, Brian Geffon wrote:
> I think you might be misunderstanding certain continuation guarantees
> you'll
I think you might be misunderstanding certain continuation guarantees
you'll have.
First, with transformations you'll never have a content length header
because the content length cannot be committed to until the final
transformation is complete so it will always happen with chunked transfer
encod
60 matches
Mail list logo
