Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/717#discussion_r68083417
--- Diff: proxy/ProxyClientTransaction.h ---
@@ -174,10 +174,10 @@ class ProxyClientTransaction : public VConnection
return true;
}
+ virtual void destroy();
virtual void
- destroy()
+ transaction_done()
--- End diff --
Consider a more explicit tracking of the transaction state, even a simple
IDLE, ACTIVE, DONE would probably make things a lot more explicit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
