Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/653
FWIW this didn't build on OS X:
```
In file included from ../../iocore/hostdb/I_HostDBProcessor.h:34:
../../iocore/hostdb/P_RefCountCache.h:615:3: error: use of undeclared
ident
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/653#discussion_r66908942
--- Diff: iocore/hostdb/P_RefCountCache.h ---
@@ -0,0 +1,955 @@
+/** @file
+
+ A cache (with map-esque interface) for RefCountObjs
+
Github user zizhong commented on the issue:
https://github.com/apache/trafficserver/pull/692
hey @zwoop , how is the code review going? is there any issue I need to
address?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/653#discussion_r66907780
--- Diff: iocore/hostdb/P_RefCountCache.h ---
@@ -0,0 +1,955 @@
+/** @file
+
+ A cache (with map-esque interface) for RefCountObjs
+
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/653#discussion_r66907647
--- Diff: iocore/hostdb/P_HostDBProcessor.h ---
@@ -208,29 +204,17 @@ struct RefCountedHostsFileMap : public RefCountObj {
//
// HostDBCache (P
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/653#discussion_r66907578
--- Diff: iocore/hostdb/Makefile.am ---
@@ -31,15 +31,58 @@ EXTRA_DIST = I_HostDB.h
noinst_LIBRARIES = libinkhostdb.a
libinkhostdb_a_SOUR
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/653#discussion_r66907457
--- Diff: iocore/hostdb/Makefile.am ---
@@ -31,15 +31,58 @@ EXTRA_DIST = I_HostDB.h
noinst_LIBRARIES = libinkhostdb.a
libinkhostdb_a_SOUR
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/653#discussion_r66907395
--- Diff: iocore/hostdb/I_HostDBProcessor.h ---
@@ -139,10 +141,62 @@ struct SRVInfo {
unsigned int key;
};
-struct HostDBInfo {
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/653#discussion_r66907362
--- Diff: iocore/hostdb/I_HostDBProcessor.h ---
@@ -139,10 +141,62 @@ struct SRVInfo {
unsigned int key;
};
-struct HostDBInfo {
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/653#discussion_r66907305
--- Diff: iocore/hostdb/I_HostDBProcessor.h ---
@@ -139,10 +141,62 @@ struct SRVInfo {
unsigned int key;
};
-struct HostDBInfo {
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/653#discussion_r66906927
--- Diff: iocore/hostdb/test_RefCountCache.cc ---
@@ -0,0 +1,178 @@
+#define _test_RefCountCache_cc
+
+#include
+#include "P_RefCountCac
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/653#discussion_r66906864
--- Diff: iocore/hostdb/test_RefCountCache.cc ---
@@ -0,0 +1,260 @@
+/** @file
+
+ Unit tests for RefCountCache
+
+ @section licens
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/653#discussion_r66906794
--- Diff: proxy/http/HttpTransact.h ---
@@ -905,8 +905,9 @@ class HttpTransact
int next_hop_scheme; // out
int orig_scheme; // pre-
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/653#discussion_r66906681
--- Diff: mgmt/RecordsConfig.cc ---
@@ -1089,7 +1091,7 @@ static const RecordElement RecordsConfig[] =
{RECT_CONFIG, "proxy.config.hostdb.timed_ro
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/653#discussion_r66905815
--- Diff: lib/ts/ink_res_init.cc ---
@@ -503,7 +503,20 @@ ink_res_init(ink_res_state statp, ///< State
object to update.
hints.ai
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/150/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jacksontj commented on the issue:
https://github.com/apache/trafficserver/pull/653
Verified that each intermediate commits build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
FreeBSD build *failed*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/252/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jacksontj commented on the issue:
https://github.com/apache/trafficserver/pull/653
@zwoop is there a way to skip linux builds? (Since I know those work-- and
can easily test those).
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/149/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jacksontj commented on the issue:
https://github.com/apache/trafficserver/pull/653
Yea, at this point I only have build failures on freebsd :/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/653
Sorry. Can't you get it to build first on your own box before git push ?
:-).
Also, remember the rule that if you are pushing a multi-commit upstream,
each of the intermediate steps mus
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
FreeBSD build *failed*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/251/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jacksontj commented on the issue:
https://github.com/apache/trafficserver/pull/653
@zwoop now I'm actually trying to fix the build failures ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
Linux build *failed*! See
https://ci.trafficserver.apache.org/job/Github-Linux/148/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
FreeBSD build *failed*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/250/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/653
[skip ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
Linux build *failed*! See
https://ci.trafficserver.apache.org/job/Github-Linux/147/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
FreeBSD build *failed*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/249/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
Linux build *failed*! See
https://ci.trafficserver.apache.org/job/Github-Linux/146/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
FreeBSD build *failed*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/248/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
FreeBSD build *failed*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/247/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
Linux build *failed*! See
https://ci.trafficserver.apache.org/job/Github-Linux/145/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/705
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/246/ for details.
---
If your project is set up for it, you can reply to this email and have your
r
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/705
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/144/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/705
This should wait to be landed until after the issues with ASAN and Lua has
been resolved.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user jpeach opened a pull request:
https://github.com/apache/trafficserver/pull/705
TS-4100: Remove custom XML metrics.
This PR is a heads-up. I'm still going to work on some config file
documentation before I merge this. Additionally we need to figure out an
upgrade path, s
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
FreeBSD build *failed*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/245/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
Linux build *failed*! See
https://ci.trafficserver.apache.org/job/Github-Linux/143/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
FreeBSD build *failed*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/244/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
Linux build *failed*! See
https://ci.trafficserver.apache.org/job/Github-Linux/142/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
Linux build *failed*! See
https://ci.trafficserver.apache.org/job/Github-Linux/141/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
FreeBSD build *failed*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/243/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
Linux build *failed*! See
https://ci.trafficserver.apache.org/job/Github-Linux/140/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
FreeBSD build *failed*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/242/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
Linux build *failed*! See
https://ci.trafficserver.apache.org/job/Github-Linux/139/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
FreeBSD build *failed*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/241/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
Linux build *failed*! See
https://ci.trafficserver.apache.org/job/Github-Linux/138/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
FreeBSD build *failed*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/240/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
FreeBSD build *failed*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/239/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
Linux build *failed*! See
https://ci.trafficserver.apache.org/job/Github-Linux/137/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
FreeBSD build *failed*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/238/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
Linux build *failed*! See
https://ci.trafficserver.apache.org/job/Github-Linux/136/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
FreeBSD build *failed*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/237/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
Linux build *failed*! See
https://ci.trafficserver.apache.org/job/Github-Linux/135/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
FreeBSD build *failed*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/236/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
Linux build *failed*! See
https://ci.trafficserver.apache.org/job/Github-Linux/134/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
Linux build *failed*! See
https://ci.trafficserver.apache.org/job/Github-Linux/133/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
FreeBSD build *failed*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/235/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
FreeBSD build *failed*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/234/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
Linux build *failed*! See
https://ci.trafficserver.apache.org/job/Github-Linux/132/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
FreeBSD build *failed*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/233/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
FreeBSD build *failed*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/232/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
Linux build *failed*! See
https://ci.trafficserver.apache.org/job/Github-Linux/129/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/653
Linux build *failed*! See
https://ci.trafficserver.apache.org/job/Github-Linux/127/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/704
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/228/ for details.
---
If your project is set up for it, you can reply to this email and have your
r
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/704
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/125/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/703
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/226/ for details.
---
If your project is set up for it, you can reply to this email and have your
r
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/703
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/123/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/704
Ping @jacksontj @SolidWallOfCode
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/704
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/227/ for details.
---
If your project is set up for it, you can reply to this email and have your
r
Github user calavera commented on the issue:
https://github.com/apache/trafficserver/pull/703
Yes, I think it should be backported since
https://issues.apache.org/jira/browse/TS-4478 is in 6.2.0 but it's not complete
without this addition.
---
If your project is set up for it, you c
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/704
Linux build *failed*! See
https://ci.trafficserver.apache.org/job/Github-Linux/124/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply app
GitHub user jpeach opened a pull request:
https://github.com/apache/trafficserver/pull/704
TS-4531: Clarify time unit confusion in HostDB sync interval.
Commit d48b76e tried to fix some of the time unit conversions in
HostBD, but didn't notice that RefCountedHostsFileMap::next_sy
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/703
Is this fix related to something we previously did to break it? Basically,
what I'm asking is, should this go into a 6.2.0 back port?
---
If your project is set up for it, you can reply to this
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/701
AFAICT we would get ``EPIPE`` when we write to a socket that has been
closed. This would be an error because there is unwritten data that we can't
write. We would get ``ECONNRESET`` reading fro
GitHub user calavera opened a pull request:
https://github.com/apache/trafficserver/pull/703
[TS-4529] Adjust thread with the right continuation.
This patch seems to fix our issues with HttpAsync calls.
https://issues.apache.org/jira/browse/TS-4529
Signed-off-by: Da
Github user maskit closed the pull request at:
https://github.com/apache/trafficserver/pull/702
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/702
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
I think the only real thing I could add to this is that it would be nice if we
could use the same internal C++ class as part of the C++api, vs wrapping
another class around the C API.
Jason
From: Leif Hedstrom
To: dev@trafficserver.apache.org
Sent: Saturday, June 11, 2016 4:56 PM
Subj
80 matches
Mail list logo
