Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/653#discussion_r66907647
--- Diff: iocore/hostdb/P_HostDBProcessor.h ---
@@ -208,29 +204,17 @@ struct RefCountedHostsFileMap : public RefCountObj {
//
// HostDBCache (Private)
//
-struct HostDBCache : public MultiCache<HostDBInfo> {
- int rebuild_callout(HostDBInfo *e, RebuildMC &r);
+struct HostDBCache {
int start(int flags = 0);
- MultiCacheBase *
- dup()
- {
- return new HostDBCache;
- }
-
- // This accounts for an average of 2 HostDBInfo per DNS cache (for
round-robin etc.)
- // In addition, we can do a padding for additional SRV records storage.
- // In addition, we add 120 for hostname storage (since we now always do
that)
- virtual size_t
- estimated_heap_bytes_per_entry() const
- {
- return sizeof(HostDBInfo) * 2 + 512 * hostdb_srv_enabled + 120;
- }
-
// Map to contain all of the host file overrides, initialize it to empty
Ptr<RefCountedHostsFileMap> hosts_file_ptr;
+ // TODO: cleanup
+ RefCountCache<HostDBInfo> *refcountcache;
--- End diff --
If ``refcountcache`` was ``Ptr<RefCountCache>>`` it will get cleaned up
automatically.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
