Github user oknet commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/568#discussion_r63826235
--- Diff: lib/ts/Diags.cc ---
@@ -625,11 +625,14 @@ Diags::should_roll_diagslog()
fflush(diags_log->m_fp);
if (diags_log->roll()
Github user danobi commented on the pull request:
https://github.com/apache/trafficserver/pull/568#issuecomment-220231207
@chaiman I see what you mean. I'll fix that in a separate ticket.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user jpeach opened a pull request:
https://github.com/apache/trafficserver/pull/648
TS-4460: Remove record conversion from RecSetRecord.
RecSetRecord manually converts a record value from a string. It
could just use RecDataSetFromString. The only place this semantic
is
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/647#issuecomment-220117502
Can one of the admins verify this patch? Only approve PRs which have been
reviewed.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/647#issuecomment-220117229
Can one of the admins verify this patch? Only approve PRs which have been
reviewed.
---
If your project is set up for it, you can reply to this email and have your
GitHub user reveller opened a pull request:
https://github.com/apache/trafficserver/pull/647
TS-4459 - Force domain names in cert to lower on insert into lookup tree
This commit resolves domain names in a cert which need to be lower cased
before being inserted into the lookup table.
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/632#discussion_r63748572
--- Diff: proxy/http2/Http2ConnectionState.cc ---
@@ -906,74 +957,140 @@
Http2ConnectionState::update_initial_rwnd(Http2WindowSize new_size)
}
Github user masaori335 commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/632#discussion_r63741679
--- Diff: proxy/http2/Http2ConnectionState.cc ---
@@ -906,74 +957,140 @@
Http2ConnectionState::update_initial_rwnd(Http2WindowSize new_size)
}
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/632#discussion_r63740460
--- Diff: proxy/http2/Http2ConnectionState.cc ---
@@ -906,74 +957,140 @@
Http2ConnectionState::update_initial_rwnd(Http2WindowSize new_size)
}
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/632#discussion_r63740371
--- Diff: proxy/http2/Http2ConnectionState.cc ---
@@ -906,74 +957,140 @@
Http2ConnectionState::update_initial_rwnd(Http2WindowSize new_size)
}
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/632#discussion_r63739375
--- Diff: proxy/http2/Http2ConnectionState.cc ---
@@ -906,74 +957,140 @@
Http2ConnectionState::update_initial_rwnd(Http2WindowSize new_size)
}
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/630
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
Github user shinrich commented on the pull request:
https://github.com/apache/trafficserver/pull/646#issuecomment-220056278
Looks reasonable to me. The isEosRcvd was added as part of TS-3714. Much
of that buffer saving logic has already been removed because changes in
handshake buff
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/646#issuecomment-220007659
Can one of the admins verify this patch? Only approve PRs which have been
reviewed.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/646#issuecomment-220007429
Can one of the admins verify this patch? Only approve PRs which have been
reviewed.
---
If your project is set up for it, you can reply to this email and have your
GitHub user oknet opened a pull request:
https://github.com/apache/trafficserver/pull/646
TS-4455: remove isEosRcvd() and eosRcvd
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/oknet/trafficserver patch-12
Alternatively you can
Github user yatsukhnenko commented on the pull request:
https://github.com/apache/trafficserver/pull/643#issuecomment-219967991
done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user yatsukhnenko commented on the pull request:
https://github.com/apache/trafficserver/pull/644#issuecomment-219967937
done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user chaiman commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/568#discussion_r63660164
--- Diff: lib/ts/Diags.cc ---
@@ -642,11 +645,14 @@ Diags::should_roll_diagslog()
if (diags_log->roll()) {
--- End diff --
sam
Github user chaiman commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/568#discussion_r63659601
--- Diff: lib/ts/Diags.cc ---
@@ -625,11 +625,14 @@ Diags::should_roll_diagslog()
fflush(diags_log->m_fp);
if (diags_log->roll
Github user oknet commented on the pull request:
https://github.com/apache/trafficserver/pull/642#issuecomment-219947645
review the code again, the variable name 'server_addr' confuse me. now, I'm
using get_remote_addr() to replace server_addr and remote get_server_*() and
get_client_
21 matches
Mail list logo
