[GitHub] trafficserver pull request: TS-4397: Fix build on i386 caused by t...

2016-04-29 Thread felixbuenemann
GitHub user felixbuenemann opened a pull request: https://github.com/apache/trafficserver/pull/607 TS-4397: Fix build on i386 caused by type mismatch It seems lua_Integer is 32-Bit on i386 while it's 54-Bit on x86-64 causing the existing code to fail with: ``` metrics.c

[GitHub] trafficserver pull request: TS-4388: Fix TSHttpTxnParentProxySet

2016-04-29 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/606#issuecomment-215932527 OK I broke out some refactoring into 2 additional commits. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] trafficserver pull request: TS-4328

2016-04-29 Thread jacksontj
Github user jacksontj closed the pull request at: https://github.com/apache/trafficserver/pull/554 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] trafficserver pull request: TS-4328

2016-04-29 Thread jacksontj
Github user jacksontj commented on the pull request: https://github.com/apache/trafficserver/pull/554#issuecomment-215864574 @zwoop @jpeach @SolidWallOfCode After chatting some more on IRC today, it seems the people are quite against the milestones approach-- so I've changed this patc

[GitHub] trafficserver pull request: TS-4388: Fix TSHttpTxnParentProxySet

2016-04-29 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/606#issuecomment-215751946 I agree with Phil, since the refactoring (variable name changes) is so big, it would be much nicer to have this as two separate PRs. --- If your project is set up