Proposal: NetVC Context

2016-04-22 Thread Chao Xu
As a proxy, there has two side: client side ( Client <-> Proxy ) and server side ( Proxy <-> Server ). Add a new member 'netvc_context' into class NetVConnection to indicate which side the NetVC working on. And remove member 'server_addr' from UnixNetVConnection: {code} 246 // amc - what is th

[GitHub] trafficserver pull request: [YTSATS-676] Add log field for Server ...

2016-04-22 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/598#issuecomment-213629092 Please fix the commit message to refer to TS-4379. The commit message should also contain some more information, take a look [this](http://chris.beams.io/posts/gi

[GitHub] trafficserver pull request: [YTSATS-676] Add log field for Server ...

2016-04-22 Thread ericcarlschwartz
GitHub user ericcarlschwartz opened a pull request: https://github.com/apache/trafficserver/pull/598 [YTSATS-676] Add log field for Server Connection Count https://issues.apache.org/jira/browse/TS-4379 You can merge this pull request into a Git repository by running: $ git pull

Re: Unit testing for plugin

2016-04-22 Thread Gancho Tenev
Karthik, If interested in regression / integration testing (trafficserver+plugin) using TSQA you could take a look at cachekey plugin regression tests: https://github.com/apache/trafficserver/blob/master/plugins/experimental/cachekey/tests/test_cachekey.py TSQA link: https://github.com/

Re: Unit testing for plugin

2016-04-22 Thread Karthik Sivaraman
Thanks all. Will follow up on these links Karthik From: Brian Geffon Sent: Friday, April 22, 2016 8:46 AM To: dev@trafficserver.apache.org Subject: Re: Unit testing for plugin Take a look at the open pull requests, there are c++ API mocks that are hopefu

Re: Unit testing for plugin

2016-04-22 Thread James Peach
> On Apr 22, 2016, at 7:01 AM, Karthik Sivaraman > wrote: > > Hi > > > We are planning to maintain a plug-in that does third party feed based URL > filtering. Are there any recommendations for unit test/regression test > frameworks? What does trafficserver use for its unit/regression tests?

Re: Unit testing for plugin

2016-04-22 Thread Brian Geffon
Take a look at the open pull requests, there are c++ API mocks that are hopefully going to land soon too. Brian On Friday, April 22, 2016, James Peach wrote: > > > On Apr 22, 2016, at 7:01 AM, Karthik Sivaraman < > karthiksivara...@outlook.com > wrote: > > > > Hi > > > > > > We are planning to

Re: Unit testing for plugin

2016-04-22 Thread Jason Kenny
Have to remember the joy of e-mail at yahoo Let me try to get a good link to catch https://github.com/philsquared/Catch Jason From: Jason Kenny To: "dev@trafficserver.apache.org" Sent: Friday, April 22, 2016 9:56 AM Subject: Re: Unit testing for plugin I am planning on proposing t

Re: Unit testing for plugin

2016-04-22 Thread Jason Kenny
I am planning on proposing the use of philsquared/Catch | | | | || | | | || philsquared/Catch Catch - A modern, C++-native, header-only, framework for unit-tests, TDD and BDD | | | | for unit testing as part of my work on fixing up testing ATS within Ya

Re: [trafficserver] branch master updated: TS-3922: Websocket Timeouts, transaction overrideable & clang format

2016-04-22 Thread James Peach
> On Apr 21, 2016, at 9:49 PM, Brian Geffon wrote: > > Should be fixed now, thanks! > yes I ran the regressions they passed with -R1 Hmm … maybe you didn’t build with —enable-experimental-plugins? > > Brian > > On Friday, April 22, 2016, James Peach wrote: > >> This commit broke the Lua

Unit testing for plugin

2016-04-22 Thread Karthik Sivaraman
Hi We are planning to maintain a plug-in that does third party feed based URL filtering. Are there any recommendations for unit test/regression test frameworks? What does trafficserver use for its unit/regression tests? Thanks Karthik