Github user jpeach commented on the pull request:

    https://github.com/apache/trafficserver/pull/598#issuecomment-213629092
  
    Please fix the commit message to refer to TS-4379. The commit message 
should also contain some more information, take a look  
[this](http://chris.beams.io/posts/git-commit/).
    
    The logic here needs to be aligned with #554, please sync up with 
@jacksontj and @bgaff.
    
    Has this been benchmarked? ``ConnectionCount::getCount()`` effectively 
takes a global lock, so I would expect some performance impact.
    
    Are logs really the right way to expose this information? Maybe it would be 
better to be able to extract more general statistics about how Traffic Server 
is utilizing origins?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to