[GitHub] trafficserver pull request: TS-4357: Remove SSLv2 and only allow S...

2016-04-20 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/589#issuecomment-212750344 Looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] trafficserver pull request: [TS-3922] Add independent WebSocket ti...

2016-04-20 Thread bgaff
Github user bgaff commented on the pull request: https://github.com/apache/trafficserver/pull/590#issuecomment-212738312 Merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] trafficserver pull request: [TS-3922] Add independent WebSocket ti...

2016-04-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/590 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: [TS-4369]Add VIA_ERROR_MOVED_TEMPORARI...

2016-04-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/586 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: [TS-4369]Add VIA_ERROR_MOVED_TEMPORARI...

2016-04-20 Thread bgaff
Github user bgaff commented on the pull request: https://github.com/apache/trafficserver/pull/586#issuecomment-212736198 Merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] trafficserver pull request: TS-4365: Prevent invalid clang-analyze...

2016-04-20 Thread bgaff
Github user bgaff closed the pull request at: https://github.com/apache/trafficserver/pull/592 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] trafficserver pull request: TS-4365: Prevent invalid clang-analyze...

2016-04-20 Thread bgaff
Github user bgaff commented on the pull request: https://github.com/apache/trafficserver/pull/592#issuecomment-212725625 @zwoop already resolved in c953da0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] trafficserver pull request: TS-4365: Prevent invalid clang-analyze...

2016-04-20 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/592#issuecomment-212725520 With the exception for that one unused GlobalPlugin *plugin we discussed, +1! Thanks! --- If your project is set up for it, you can reply to this email a

[GitHub] trafficserver pull request: TS-4365: Prevent invalid clang-analyze...

2016-04-20 Thread bgaff
GitHub user bgaff opened a pull request: https://github.com/apache/trafficserver/pull/592 TS-4365: Prevent invalid clang-analyzer memory leak warnings clang-analyzer is currently detecting an invalid memory leak, this PR fixes those warnings by saving the plugin pointers. You can m

[GitHub] trafficserver pull request: [TS-3922] Add independent WebSocket ti...

2016-04-20 Thread zizhong
Github user zizhong commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/590#discussion_r6052 --- Diff: iocore/net/UnixNet.cc --- @@ -96,8 +97,8 @@ class InactivityCop : public Continuation NET_SUM_DYN_STAT(keep_alive_queue_timeout

[GitHub] trafficserver pull request: [TS-4369]Add VIA_ERROR_MOVED_TEMPORARI...

2016-04-20 Thread zizhong
Github user zizhong commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/586#discussion_r60520786 --- Diff: doc/admin-guide/plugins/escalate.en.rst --- @@ -61,4 +61,4 @@ With this line in :file:`remap.config` :: Traffic Server would accept a req

[GitHub] trafficserver pull request: TS-4364: Address remnants from HTTP/2 ...

2016-04-20 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/584#issuecomment-212708586 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] trafficserver pull request: [TS-4369]Add VIA_ERROR_MOVED_TEMPORARI...

2016-04-20 Thread bgaff
Github user bgaff commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/586#discussion_r60519785 --- Diff: doc/admin-guide/plugins/escalate.en.rst --- @@ -61,4 +61,4 @@ With this line in :file:`remap.config` :: Traffic Server would accept a reque

[GitHub] trafficserver pull request: [TS-3922] Add independent WebSocket ti...

2016-04-20 Thread bgaff
Github user bgaff commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/590#discussion_r60519710 --- Diff: iocore/net/UnixNet.cc --- @@ -96,8 +97,8 @@ class InactivityCop : public Continuation NET_SUM_DYN_STAT(keep_alive_queue_timeout_t

[GitHub] trafficserver pull request: [TS-3922] Add independent WebSocket ti...

2016-04-20 Thread bgaff
Github user bgaff commented on the pull request: https://github.com/apache/trafficserver/pull/590#issuecomment-212705977 @zizhong we need to add docs too, can you please update the records.config documentation. Thanks. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver pull request: Prevent LogFile from calling NULL refe...

2016-04-20 Thread calavera
GitHub user calavera opened a pull request: https://github.com/apache/trafficserver/pull/591 Prevent LogFile from calling NULL references with ASCII_PIPE. TrafficServer crashes when you try to use ASCII_PIPE because flushing the buffer it tries to set the creation date in a NULL

[GitHub] trafficserver pull request: TS-4357: Remove SSLv2 and only allow S...

2016-04-20 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/589#issuecomment-212625573 Looks good. I'd consider changing the help text to something like Allows SSLv3 for origin connections to be enabled (Only do this if you know the risks)

[GitHub] trafficserver pull request: Add independent WebSocket timeouts

2016-04-20 Thread zizhong
GitHub user zizhong opened a pull request: https://github.com/apache/trafficserver/pull/590 Add independent WebSocket timeouts You can merge this pull request into a Git repository by running: $ git pull https://github.com/zizhong/trafficserver websocket_timout Alternatively

Re: Deprecation of SSL v2/3

2016-04-20 Thread Phil Sorber
As discussed, https://github.com/apache/trafficserver/pull/589 On Sat, Apr 16, 2016 at 10:46 AM Phil Sorber wrote: > Ok, here is my final plan then. I am going to mark them all deprecated for > 6.2.x. > > Then after branching I am going to remove all client <-> proxy support and > ifdef out pro

[GitHub] trafficserver pull request: TS-4357: Remove SSLv2 and only allow S...

2016-04-20 Thread PSUdaemon
GitHub user PSUdaemon opened a pull request: https://github.com/apache/trafficserver/pull/589 TS-4357: Remove SSLv2 and only allow SSLv3 to origin with configure o… …ption. You can merge this pull request into a Git repository by running: $ git pull https://github.com/PSUda

[GitHub] trafficserver pull request: [TS-4369]Add VIA_ERROR_MOVED_TEMPORARI...

2016-04-20 Thread zizhong
Github user zizhong commented on the pull request: https://github.com/apache/trafficserver/pull/586#issuecomment-212553694 Thanks @JamesPeach for reminding me. traffic_via and docs are updated. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver pull request: TS-4291 Adds log field "pqnhl" which i...

2016-04-20 Thread ogoodman
Github user ogoodman commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/588#discussion_r60401090 --- Diff: proxy/logging/LogAccessTest.cc --- @@ -300,6 +300,19 @@ LogAccessTest::marshal_proxy_req_header_len(char *buf) --

[GitHub] trafficserver pull request: TS-4291 Adds log field "pqnhl" which i...

2016-04-20 Thread ogoodman
Github user ogoodman commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/588#discussion_r60399946 --- Diff: proxy/logging/Log.cc --- @@ -594,6 +594,11 @@ Log::init_fields() global_field_list.add(field, false); ink_hash_table_insert(fie