Github user ogoodman commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/588#discussion_r60399946
--- Diff: proxy/logging/Log.cc ---
@@ -594,6 +594,11 @@ Log::init_fields()
global_field_list.add(field, false);
ink_hash_table_insert(field_symbol_hash, "pqhl", field);
+ field = new LogField("proxy_req_net_hdr_len", "pqnhl", LogField::sINT,
&LogAccess::marshal_proxy_req_net_hdr_len,
+ &LogAccess::unmarshal_int_to_str);
+ global_field_list.add(field, false);
+ ink_hash_table_insert(field_symbol_hash, "pqnhl", field);
+
--- End diff --
Looking at this documentation and re-reading sudheerv's remarks at 8:26 and
the eventual wording of the issue lead me to think that adding a new log tag is
not the right fix. If you agree I will commit again removing the new field and
modifying "pqhl" to match the documentation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
