Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/541#issuecomment-209762909
I'm ok with ``ParseRules::is_uri``. I made a couple of comments on the
tests.
Please take a look at [this](http://chris.beams.io/posts/git-commit/)
articl
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/541#discussion_r59663241
--- Diff: proxy/hdrs/URL.cc ---
@@ -1846,4 +1823,42 @@ REGRESSION_TEST(VALIDATE_HDR_FIELD)(RegressionTest
*t, int /* level ATS_UNUSED *
}
}
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/541#discussion_r59663226
--- Diff: proxy/hdrs/URL.cc ---
@@ -1846,4 +1823,42 @@ REGRESSION_TEST(VALIDATE_HDR_FIELD)(RegressionTest
*t, int /* level ATS_UNUSED *
}
}
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/541#discussion_r59663218
--- Diff: proxy/hdrs/URL.cc ---
@@ -1846,4 +1823,42 @@ REGRESSION_TEST(VALIDATE_HDR_FIELD)(RegressionTest
*t, int /* level ATS_UNUSED *
}
}
> On Apr 13, 2016, at 9:45 PM, Masakazu Kitajo wrote:
>
> I merged a pull request on GitHub with "squash and merge" button.
> https://github.com/blog/2141-squash-your-commits
>
> This makes only one commits on master like we used to. It looks better
> than making a merge commit.
Is there a reb
I merged a pull request on GitHub with "squash and merge" button.
https://github.com/blog/2141-squash-your-commits
This makes only one commits on master like we used to. It looks better
than making a merge commit.
On Thu, Apr 14, 2016 at 1:31 PM, wrote:
> This is an automated email from the ASF
Github user maskit closed the pull request at:
https://github.com/apache/trafficserver/pull/551
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/551#issuecomment-209756115
I filed three Jiras.
https://issues.apache.org/jira/browse/TS-4349
https://issues.apache.org/jira/browse/TS-4350
https://issues.apache.org/jira/browse/TS
Github user jacksontj commented on the pull request:
https://github.com/apache/trafficserver/pull/564#issuecomment-209719690
@bgaff @jpeach @zwoop ready for review :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user jacksontj commented on the pull request:
https://github.com/apache/trafficserver/pull/564#issuecomment-209719516
This PR now includes the patches from
https://github.com/apache/trafficserver/pull/562 and
https://github.com/apache/trafficserver/pull/569 as they are related
Github user jacksontj commented on the pull request:
https://github.com/apache/trafficserver/pull/569#issuecomment-209704185
The tests for this are on https://github.com/apache/trafficserver/pull/562
(which I've also pulled in the code patch for as well-- so we can merge a
single PR).
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/541#issuecomment-209696367
Thanks @shenzhang920
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user bgaff opened a pull request:
https://github.com/apache/trafficserver/pull/569
TS-4340: Fix origin max connections
This fixes issues related to max origin connections and makes them honor
the same server matching config that is used for server session pools.
@jpe
Github user danobi commented on the pull request:
https://github.com/apache/trafficserver/pull/568#issuecomment-209691924
@jpeach Is there a preferred framework for unit testing? (ie how/where do I
put the tests?)
---
If your project is set up for it, you can reply to this email and
Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/568#discussion_r59644646
--- Diff: lib/ts/Diags.cc ---
@@ -716,14 +722,12 @@ Diags::should_roll_outputlog()
bool ret_val = false;
bool need_consider_stderr = true;
Github user shenzhang920 commented on the pull request:
https://github.com/apache/trafficserver/pull/541#issuecomment-209688326
@bgaff I search the code, no usage of is_wildmat()/is_wildmat_BIT. @jpeach
any suggestion to the name "is_uri"?
---
If your project is set up for it, you c
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/541#issuecomment-209687483
:+1: This looks good to me, one concern would be the bit name is_uri, can
we find a more descriptive name for this bit? Also, @shenzhang920 you also
confirmed there
Github user shenzhang920 commented on the pull request:
https://github.com/apache/trafficserver/pull/541#issuecomment-209686860
@jpeach I removed is_wildmat_BIT and added is_uri_BIT, please refer to
commit d9d972d
---
If your project is set up for it, you can reply to this email and
Github user shenzhang920 commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/541#discussion_r59641878
--- Diff: proxy/hdrs/URL.cc ---
@@ -1158,9 +1158,51 @@ url_parse_scheme(HdrHeap *heap, URLImpl *url, const
char **start, const char *en
ret
Github user shenzhang920 commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/541#discussion_r59641766
--- Diff: mgmt/RecordsConfig.cc ---
@@ -441,6 +441,8 @@ static const RecordElement RecordsConfig[] =
,
{RECT_CONFIG, "proxy.config.ht
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/568#discussion_r5964
--- Diff: lib/ts/Diags.cc ---
@@ -716,14 +722,12 @@ Diags::should_roll_outputlog()
bool ret_val = false;
bool need_consider_stderr
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/568#issuecomment-209664725
Yes. We looked at various approaches and decided on this one because there
was already a lock around access to the file descriptor. Locking the update to
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/568#issuecomment-209663459
OK the locking makes sense to me I think. You have to hold the lock because
you want to serialize WRT printing output.
``Diags::rebind_stderr`` and ``Diags
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/568#discussion_r59632436
--- Diff: lib/ts/Diags.cc ---
@@ -816,29 +820,39 @@ Diags::set_stdout_output(const char *_bind_stdout)
if (strcmp(_bind_stdout, "") == 0)
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/568#discussion_r59632366
--- Diff: lib/ts/Diags.cc ---
@@ -716,14 +722,12 @@ Diags::should_roll_outputlog()
bool ret_val = false;
bool need_consider_stderr = true;
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/568#discussion_r59632028
--- Diff: lib/ts/Diags.cc ---
@@ -816,29 +820,39 @@ Diags::set_stdout_output(const char *_bind_stdout)
if (strcmp(_bind_stdout, "") == 0)
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/568#discussion_r59631832
--- Diff: lib/ts/Diags.cc ---
@@ -816,29 +820,39 @@ Diags::set_stdout_output(const char *_bind_stdout)
if (strcmp(_bind_stdout, "") == 0)
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/568#discussion_r59631163
--- Diff: lib/ts/Diags.cc ---
@@ -853,29 +867,39 @@ Diags::set_stderr_output(const char *_bind_stderr)
if (strcmp(_bind_stderr, "") == 0)
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/568#discussion_r59629895
--- Diff: lib/ts/Diags.cc ---
@@ -642,10 +642,10 @@ Diags::should_roll_diagslog()
bool ret_val = false;
log_log_trace("should_roll_di
Thanks Susan.
Karthik
On 3/30/16, 6:44 AM, "Susan Hinrichs" wrote:
>Yes, you can decrypt and proxy SSL traffic in forward mode. Typically
>(always?) this is done in transparent mode.
>
>http://trafficserver.readthedocs.org/en/latest/admin-guide/configuration/transparent-forward-proxying.en.
Thanks Susan, I'll check that out.
> On Apr 13, 2016, at 6:35 AM, Susan Hinrichs
> wrote:
>
> I'm assuming you are referring to the handshake between ATS and the user
> agent. You can set a call back before the server certificate is selected.
>
> TSHttpHookAdd(TS_SSL_CERT_HOOK, cb_cert);
>
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/568#issuecomment-209628730
Looks good to me. Dan, Jason, and I discussed this at length prior to the
work and this looks in line with our concensus.
---
If your project is set up f
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/568
TS-4072 Diagnostic log rolling races
This patch prevents race conditions when a diagnostic log rolls. The patch
is a little longer than I had hoped for because of error handling conditions.
Y
Github user jrushford closed the pull request at:
https://github.com/apache/trafficserver/pull/566
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/566#issuecomment-209521176
Yes that sounds fine, thanks @jrushford
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user jrushford commented on the pull request:
https://github.com/apache/trafficserver/pull/566#issuecomment-209520959
@jpeach, I'll wrap these macros in the do {...} while(0) block, good idea.
I'll think about the re-write in the future but, I have some other things that
are h
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/566#issuecomment-209512558
This looks better. @jrushford can you please wrap these macros in a ```do {
... } while (0)``` block? They are giving me the heebie-jeebies.
Could you cons
On 4/13/2016 9:01 AM, Susan Hinrichs wrote:
On 4/13/2016 8:34 AM, Daniel Gruno wrote:
On 04/13/2016 03:21 PM, Susan Hinrichs wrote:
Oh, and I double checked that my github account has two factor
authentication enabled.
You need to accept the invitation from the ASF on GitHub to join the or
On 4/13/2016 8:34 AM, Daniel Gruno wrote:
On 04/13/2016 03:21 PM, Susan Hinrichs wrote:
Oh, and I double checked that my github account has two factor
authentication enabled.
You need to accept the invitation from the ASF on GitHub to join the org
- your team membership is pending acceptance.
I'm assuming you are referring to the handshake between ATS and the user
agent. You can set a call back before the server certificate is selected.
TSHttpHookAdd(TS_SSL_CERT_HOOK, cb_cert);
There are several example plugins and the basic elements are documented
in the API docs. Here is the or
On 04/13/2016 03:21 PM, Susan Hinrichs wrote:
> Oh, and I double checked that my github account has two factor
> authentication enabled.
You need to accept the invitation from the ASF on GitHub to join the org
- your team membership is pending acceptance. MFA cannot be verified
unless you have acc
Github user jrushford commented on the pull request:
https://github.com/apache/trafficserver/pull/566#issuecomment-209441767
@jpeach and @zwoop I modified the regression test REBUILD and REINIT macros
and added code to free allocated memory. This eliminated all the parent
selection r
Oh, and I double checked that my github account has two factor
authentication enabled.
On 4/13/2016 8:16 AM, Susan Hinrichs wrote:
I can get the first two steps done, but the third step reports.
MFA: Unknown, not part of the Apache organisation on GitHub yet. ???
I've waited at least a day i
I can get the first two steps done, but the third step reports.
MFA: Unknown, not part of the Apache organisation on GitHub yet. ???
I've waited at least a day in case something was propagating. Where
else do I need to register?
On 4/10/2016 6:25 PM, Leif Hedstrom wrote:
On Apr 7, 2016, at
44 matches
Mail list logo
