[GitHub] trafficserver pull request: TS-4172: Cleanup debug logs of Http2Co...

Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/454#issuecomment-181738410 @jpeach Please take a look --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] trafficserver pull request: TS-4132 Open source Yahoo's ats-inline...

Github user dmorilha commented on the pull request: https://github.com/apache/trafficserver/pull/459#issuecomment-181726588 good point! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

master branch is now protected

Hi all, As of https://issues.apache.org/jira/browse/INFRA-11234, the paster branch is now protected and force pushes are not allowed thanks, James

[GitHub] trafficserver pull request: TS-4185: Fix Request::getMethod() does...

Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/461 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: tsxs accepts .lo files as argument for...

Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/449 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: setting BUILD variable for .lo, .o and...

Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/458 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS-4132 Open source Yahoo's ats-inline...

Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/459#issuecomment-181698564 @dmorilha You mean ```"%" PRId64 ""``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] trafficserver pull request: TS-4185: Fix Request::getMethod() does...

GitHub user taoshiro opened a pull request: https://github.com/apache/trafficserver/pull/461 TS-4185: Fix Request::getMethod() does not return HTTP_METHOD_PUSH `Request::getMethod()` does not return `HTTP_METHOD_PUSH`. You can merge this pull request into a Git repository by running

[GitHub] trafficserver pull request: adding TS_EVENT_HTTP_PRE_REMAP

Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/452 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS-4176: s3_auth add support for matri...

Github user robguima commented on the pull request: https://github.com/apache/trafficserver/pull/455#issuecomment-181605333 @zwoop thought that was a pretty good argument myself. :) not a prob will change it - also forgot you guys are multiplat... --- If your project is set up for it

[GitHub] trafficserver pull request: TS-4176: s3_auth add support for matri...

Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/455#issuecomment-181604662 Yeah, the problem with it (and pretty much all of STL) is that it has hidden (and sometimes) unpredictable memory allocations behavior. I did some tests recently wi

[GitHub] trafficserver pull request: TS-4132 Open source Yahoo's ats-inline...

Github user dmorilha commented on the pull request: https://github.com/apache/trafficserver/pull/459#issuecomment-181603731 @jpeach all done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] trafficserver pull request: TS-4176: s3_auth add support for matri...

Github user robguima commented on the pull request: https://github.com/apache/trafficserver/pull/455#issuecomment-181600678 2) hmm string is one of the few things I like about C++ :) especially for, like you said, code that is not in the main code path (e.g. debugging). It's just conv

[GitHub] trafficserver pull request: TS-4132 Open source Yahoo's ats-inline...

Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/459#issuecomment-181598361 Let's squash this branch a bit to improve clarity. All the code changes should go into the first commit, then the build integration and documentation in the second

[GitHub] trafficserver pull request: TS-4132 Open source Yahoo's ats-inline...

Github user dmorilha commented on the pull request: https://github.com/apache/trafficserver/pull/459#issuecomment-181596121 @sc0ttbeardsley do you think this `README` files explains it well? https://github.com/dmorilha/trafficserver/blob/28456734fbc604b0115d1582dd2bf1b230263cdf/plugins

[GitHub] trafficserver pull request: TS-4176: s3_auth add support for matri...

Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/455#issuecomment-181594755 Couple of things on that last patch: 1) You have to run clang-format over the code, I'm fairly certain we would never indent like this: if (con_md

[GitHub] trafficserver pull request: TS-4176: s3_auth add support for matri...

Github user robguima commented on the pull request: https://github.com/apache/trafficserver/pull/455#issuecomment-181591169 @zwoop I will squash it to one commit if this change is OK. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] trafficserver pull request: TS-4177: Memory leak in LogFieldAliasT...

Github user SolidWallOfCode commented on the pull request: https://github.com/apache/trafficserver/pull/456#issuecomment-181463542 As far as I know, we can't depend on `std::unique_ptr` being available. If that's changed then yes, we could replace `ats_scoped_str` with `unique_ptr`. T

[GitHub] trafficserver pull request: TS-4177: Memory leak in LogFieldAliasT...

Github user bryancall commented on the pull request: https://github.com/apache/trafficserver/pull/456#issuecomment-181455689 If we want to go down the path of managed pointers then unique_ptr would be the way to go. I don't see a benefit of ats_scopted_str. It not a generic c

[ANNOUNCE] Apache Traffic Server 6.1.1 is Released!

Apache Traffic Server v6.1.1 Released The Apache Software Foundation and the Apache Traffic Server project are pleased to announce the release of Apache Traffic Server v6.1.1! This release immediately available for download at: http://trafficserver.apache.org/downloads

[GitHub] trafficserver pull request: TS-4092: Decouple HPACK from HTTP/2

GitHub user maskit opened a pull request: https://github.com/apache/trafficserver/pull/460 TS-4092: Decouple HPACK from HTTP/2 I tried to decouple HPACK from HTTP2, and it partially succeeded. It's very difficult to completely decouple HPACK unless we use MIMEField in it. #

[GitHub] trafficserver pull request: TS-4177: Memory leak in LogFieldAliasT...

Github user SolidWallOfCode commented on the pull request: https://github.com/apache/trafficserver/pull/456#issuecomment-181417642 Too late but this is the kind of thing {{ats_scoped_str}} is for. --- If your project is set up for it, you can reply to this email and have your reply ap