Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/455#issuecomment-181594755
Couple of things on that last patch:
1) You have to run clang-format over the code, I'm fairly certain we would
never indent like this:
if (con_md5) TSDebug(PLUGIN_NAME, "%.*s", con_md5_len, con_md5);
2) Must we really introduce usage of std::string left("/"); ?? I guess this
is inside a debug if() check, it's not a huge deal, but I cringe when I see
std::string :-).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
