As most of you probably know FOSDEM 2016 (the biggest,
100% free open source developer conference) is right
around the corner:
https://fosdem.org/2016/
We hope to have an ASF booth and we would love to see as
many ASF projects as possible present at various tracks
(AKA Developer rooms):
htt
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/343#issuecomment-160858064
Looks nice. You don't need to hand-marshall the local manager message. Just
use ```mgmt_message_length()``` and ```mgmt_message_marshall()``` to marshall
into a bu
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/356#issuecomment-160855795
> so split out validate_hdr_field which takes a char const* and make a
regression test for that?
yup
---
If your project is set up for it, you can reply
Just a constructive comment but I perosonslly am sort of sick of getting 3
emails for every GitHub comment :/ anything we can do about that regardless?
Brian
On Tuesday, December 1, 2015, Sudheer Vinukonda
wrote:
> It seems like there are pros and cons in both approaches -
> While having the di
Github user masaori335 commented on the pull request:
https://github.com/apache/trafficserver/pull/354#issuecomment-160793948
Rebased with latest master branch. Please take another look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user sudheerv commented on the pull request:
https://github.com/apache/trafficserver/pull/351#issuecomment-160778560
+1 on the approach.
A specific comment on a quick scan of the code - it seems like the patch
only handles the case with *Content-Length* header, what abo
It seems like there are pros and cons in both approaches -
While having the discussions on the Jira ticket allows for consistency and easy
to locate them, having comments (especially, code-level comments) on GitHub
allows for highlighting specific portions of the code.
Internally, we make the Gi
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/356#issuecomment-160768214
James - so split out `validate_hdr_field` which takes a `char const*` and
make a regression test for that?
The use of `ats_ip_parse` is correct. I
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/356#issuecomment-160765501
Can you extract the guts of ```validate_hdr_host``` into a separate
function and use that to add a regression test host validation?
Are you sure that the t
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/354#issuecomment-160761247
There are conflicts with the patch after applying previous pull requests.
Please update.
---
If your project is set up for it, you can reply to this email and
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/353
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github comments should show up in the Jira if they are property linked to
the ticket. I prefer the discussions in the Jira Ticket.
-Bryan
On Nov 30, 2015, at 10:55 AM, Leif Hedstrom wrote:
Now that we agreed to use Github as a patch / review board, the question
is: Where do we post comments? O
Github user mlibbey commented on the pull request:
https://github.com/apache/trafficserver/pull/350#issuecomment-160755930
We have health check and other "random" traffic to machines that make
reading debug logs really painful. As a result, we are constantly wishing for a
way to turn
Github user djcarlin commented on the pull request:
https://github.com/apache/trafficserver/pull/350#issuecomment-160751958
I like it being built into core - we can enable per-ip debugging without
restarting ATS since the setting is overridable. This way we don't end up
clearing the
> On Nov 30, 2015, at 1:55 PM, Leif Hedstrom wrote:
>
> Now that we agreed to use Github as a patch / review board, the question is:
> Where do we post comments? On the Jira, or the Github pull request? My
> preference is constantly using Jira, for two reasons
>
> 1) Our automated release not
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/356#discussion_r46189499
--- Diff: proxy/hdrs/HTTP.cc ---
@@ -161,6 +161,14 @@ is_digit(char c)
return ((c <= '9') && (c >= '0'));
}
+// test to se
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/337#issuecomment-160731514
Seems reasonable, except we should look at unifying the SSL error reporting
logic - that looks very cut and pasted.
---
If your project is set up for it,
Now that we agreed to use Github as a patch / review board, the question is:
Where do we post comments? On the Jira, or the Github pull request? My
preference is constantly using Jira, for two reasons
1) Our automated release notes refer to the Jira, it’d be a lot easier to track
discussions in
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/338
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ericcarlschwartz closed the pull request at:
https://github.com/apache/trafficserver/pull/336
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if th
Github user ericcarlschwartz commented on the pull request:
https://github.com/apache/trafficserver/pull/336#issuecomment-160693148
Am going to close this PR then. When TS-3612 is done I'll make the change
for this JIRA so that we've got this working in open source.
---
If your proje
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/356
TS-4043 Prevent bogus FQDN characters in host header
Validate the host header string to prevent malformed hostnames from being
let in.
You can merge this pull request into a Git repository by
Github user shinrich commented on the pull request:
https://github.com/apache/trafficserver/pull/337#issuecomment-160669428
Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user danobi commented on the pull request:
https://github.com/apache/trafficserver/pull/355#issuecomment-160669072
Messed up the commit message -- going to redo this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user danobi closed the pull request at:
https://github.com/apache/trafficserver/pull/355
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/355
YTSATS-659 XSS via Host header for 404
Validate the host header string to prevent malformed hostnames from being
let in.
You can merge this pull request into a Git repository by running:
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/343#issuecomment-160667524
I have updated the PR with several changes.
* "Alert" is now "Message"
* Messaging is a privileged operation.
* Messages have a tag and pay
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/336#issuecomment-160666396
I think we have decided to put this off until we have a patch for TS-3612
which will make a much cleaner implementation possible.
---
If your project is
GitHub user masaori335 opened a pull request:
https://github.com/apache/trafficserver/pull/354
TS-3986: Cleanup code related to HTTP/2 frame flags validation
[TS-3986](https://issues.apache.org/jira/browse/TS-3986)
Separate Pull-Request from #353 to easy to review.
1. Re
GitHub user masaori335 opened a pull request:
https://github.com/apache/trafficserver/pull/353
TS-3986: Restore validations for flags of HTTP/2 Frame
[TS-3986](https://issues.apache.org/jira/browse/TS-3986)
You can merge this pull request into a Git repository by running:
$ git
30 matches
Mail list logo
