[GitHub] trafficserver pull request: TS-3966 Allow for pre-origin requests ...

Github user sudheerv commented on the pull request: https://github.com/apache/trafficserver/pull/346#issuecomment-158543436 lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] trafficserver pull request: TS-3966 Allow for pre-origin requests ...

GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/346 TS-3966 Allow for pre-origin requests to be denied in header_rewrite This generalizes the concept of set-status, such that it also works in remap read-request hooks. I.e. prior to having a

[GitHub] trafficserver pull request: TS-3960: traffic_line -x doesn't reloa...

Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/301#issuecomment-158530197 Thanks, I'll review again next week. I don't think I understand what you mean about the marshaling APIs being unsuitable. Here's how you would use it to se

[GitHub] trafficserver pull request: TS-4034: Minor atscppapi cleanup

Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/345 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS-4034: Minor atscppapi cleanup

GitHub user bgaff opened a pull request: https://github.com/apache/trafficserver/pull/345 TS-4034: Minor atscppapi cleanup A few things should be cleaned up in atscppapi. - CaseInsensitiveStringComparitor isn't used internally but it is exposed in a public API, so because

[GitHub] trafficserver pull request: Refactoring of atscppapi code

Github user canselcik closed the pull request at: https://github.com/apache/trafficserver/pull/344 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] trafficserver pull request: Refactoring of atscppapi code

Github user canselcik commented on the pull request: https://github.com/apache/trafficserver/pull/344#issuecomment-158515997 Sounds good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] trafficserver pull request: Refactoring of atscppapi code

Github user bgaff commented on the pull request: https://github.com/apache/trafficserver/pull/344#issuecomment-158515283 I already have these changes locally that I'm about to commit you can close this pull request --- If your project is set up for it, you can reply to this email and

[GitHub] trafficserver pull request: Refactoring of atscppapi code

GitHub user canselcik opened a pull request: https://github.com/apache/trafficserver/pull/344 Refactoring of atscppapi code @bgaff Removing `CaseInsensitiveStringComparator` class from `atscppapi` as it can be replaced with and is not used in the codebase at all.

[GitHub] trafficserver pull request: Fix issue with TS-3885. Changes to TSN...

Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/313 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS-3960: traffic_line -x doesn't reloa...

Github user zizhong commented on the pull request: https://github.com/apache/trafficserver/pull/301#issuecomment-158368954 @jpeach I made another pull request with your helpful commits. About the marshalling using APIs from MgmtMarshall, the marshalling API uses va_lists which is