[GitHub] trafficserver pull request: fix rpath flags when multiple "--with-...

2015-11-05 Thread bgaff
Github user bgaff commented on the pull request: https://github.com/apache/trafficserver/pull/324#issuecomment-154329941 This has proven to be very useful for us. I've reviewed the patch and obviously am comfortable with it, it'd be great to get the autoconf expert @SolidWallOfCode to

[GitHub] trafficserver pull request: fix rpath flags when multiple "--with-...

2015-11-05 Thread jaaju
GitHub user jaaju opened a pull request: https://github.com/apache/trafficserver/pull/324 fix rpath flags when multiple "--with-*" arguments are given. @bgaff Using TS_ADDTO to add the custom locations of libraries results in incorrect "-rpath" directive to the linker. This i

[GitHub] trafficserver pull request: Dereferencing a NULL pointer in SpdyCl...

2015-11-05 Thread canselcik
Github user canselcik commented on the pull request: https://github.com/apache/trafficserver/pull/323#issuecomment-154269760 Thanks for the merge, and sounds good, I will look into removing the destructors in the SPDY code and improvements to `ClassAllocator` later today. --- If your

[GitHub] trafficserver pull request: Dereferencing a NULL pointer in SpdyCl...

2015-11-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/323 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: Dereferencing a NULL pointer in SpdyCl...

2015-11-05 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/323#issuecomment-154250586 I agree that this change doesn't make anything worse :) Would you mind making a followup change to remove the destructors in the SPDY code? --- If your project is

[GitHub] trafficserver pull request: Dereferencing a NULL pointer in SpdyCl...

2015-11-05 Thread canselcik
Github user canselcik commented on the pull request: https://github.com/apache/trafficserver/pull/323#issuecomment-154213497 Sounds good. So why don't we move forward with this PR as is, and add the ``` void SpdyClientSession::clear() { if (!mutex) return; //

[GitHub] trafficserver pull request: Dereferencing a NULL pointer in SpdyCl...

2015-11-05 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/323#issuecomment-154125097 Yup, ```SpdyRequest``` has the same issue. I have no objection to improving the way ```ClassAllocator``` works in a separate ticket. One thing you could explore is