GitHub user jaaju opened a pull request:
https://github.com/apache/trafficserver/pull/324
fix rpath flags when multiple "--with-*" arguments are given.
@bgaff
Using TS_ADDTO to add the custom locations of libraries results in
incorrect "-rpath" directive to the linker. This is because TS_ADDTO creates a
unique list of tokens that it adds to its target. E.g.,
./configure --with-openssl=/usr/local/openssl
--with-zlib=/usr/local/zlib
the above should result in
LIBTOOL_LINK_FLAGS: -rpath /usr/local/openssl/lib /usr/local/zlib/lib
The absence of "-rpath" in front of the second path causes an error in the
linker!
This is fixed by introducing a new macro TS_ADD_RPATH_TO that takes a path
and adds it with the "-rpath " prefix.
Also added influential environmental variable RPATH that can be used to
give a base value for the rpath. So, the following
./configure --with-openssl=/usr/local/openssl
--with-zlib=/usr/local/zlib RPATH=/foo
will result in
LIBTOOL_LINK_FLAGS: -rpath /foo -rpath /usr/local/zlib/lib -rpath
/usr/local/openssl/lib
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jaaju/trafficserver master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/324.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #324
----
commit 3a9fc2235f889eeac452b3bf16c40b34d8194e72
Author: Jay Ramamurthi <jrama...@jramamur-ld.linkedin.biz>
Date: 2015-10-15T22:06:30Z
fix rpath flags when multiple "--with-*" arguments are given.
Using TS_ADDTO to add the custom locations of libraries results in
incorrect "-rpath" directive to the linker. This is because TS_ADDTO creates a
unique list of tokens that it adds to its target. E.g.,
./configure --with-openssl=/usr/local/openssl
--with-zlib=/usr/local/zlib
the above should result in
LIBTOOL_LINK_FLAGS: -rpath /usr/local/openssl/lib /usr/local/zlib/lib
The absence of "-rpath" in front of the second path causes an error in the
linker!
This is fixed by introducing a new macro TS_ADD_RPATH_TO that takes a path
and adds it with the "-rpath " prefix.
Also added influential environmental variable RPATH that can be used to
give a base value for the rpath. So, the following
./configure --with-openssl=/usr/local/openssl
--with-zlib=/usr/local/zlib RPATH=/foo
will result in
LIBTOOL_LINK_FLAGS: -rpath /foo -rpath /usr/local/zlib/lib -rpath
/usr/local/openssl/lib
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
