[GitHub] trafficserver pull request: TS-3649 Fix for url_sig plugin securit...

2015-06-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/208 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS-3650: Track configuration variable ...

2015-06-01 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/206#issuecomment-107664507 There's no way to know whether a metric was set by ``traffic_line``. The best you can do is to say whether a metric was set by a specific API, but that's complex a

[GitHub] trafficserver pull request: TS-3650: Track configuration variable ...

2015-06-01 Thread sudheerv
Github user sudheerv commented on the pull request: https://github.com/apache/trafficserver/pull/206#issuecomment-107653612 I don't think there was a consensus yet (at least, not from my side). AFAIK, my question above on persisting the source as traffic_line was not addressed and wit

[GitHub] trafficserver pull request: TS-3649 Fix for url_sig plugin securit...

2015-06-01 Thread gtenev
GitHub user gtenev opened a pull request: https://github.com/apache/trafficserver/pull/208 TS-3649 Fix for url_sig plugin security issues (crash by HTTP request & circumvent signature). You can merge this pull request into a Git repository by running: $ git pull https://github

[GitHub] trafficserver pull request: TS-3650: Track configuration variable ...

2015-06-01 Thread SolidWallOfCode
Github user SolidWallOfCode commented on the pull request: https://github.com/apache/trafficserver/pull/206#issuecomment-107638211 The chat concensus seemed to be to change this to NULL, DEFAULT, EXPLICIT, ENV. I'll change "SRC" to "SOURCE" as well - I was tempted to have "RECS" which

[GitHub] trafficserver pull request: TS-3650: Track configuration variable ...

2015-06-01 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/206#issuecomment-107638604 Yes, I had the same conflict about ``RECS`` ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] trafficserver pull request: TS-3650: Track configuration variable ...

2015-06-01 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/206#issuecomment-107628793 The ``REC_SRC`` constants scan poorly, I think I'd prefer ``REC_SOURCE``. ``REC_SRC_NONE`` should be called ``REC_SOURCE_NULL`` to be consistent with other naming.

[GitHub] trafficserver pull request: Ts 3560

2015-06-01 Thread persiaAziz
GitHub user persiaAziz opened a pull request: https://github.com/apache/trafficserver/pull/207 Ts 3560 proxy.config.http.slow.log.threshold added to InkTestAPI.cc You can merge this pull request into a Git repository by running: $ git pull https://github.com/persiaAziz/traffic