TS-1570

2014-11-10 Thread Cynthia Gu
Hi, I’m investigating this bug (https://issues.apache.org/jira/browse/TS-1570 ) and found that the root cause is in HTTPHdr::_fill_target_cache(). It processes port string and stops before the non-digit char. Pasting the code below: // Check in the URL first, then the HOST field. if (0 != url->

[GitHub] trafficserver pull request: TS-3024

2014-11-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/138 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS-3105

2014-11-10 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/140#issuecomment-62433191 Overall, this makes me a bit nervous. There's some changes which looks obviously good, but other changes that I really don't know about. I'd feel a lot more comfort

[GitHub] trafficserver pull request: TS-2959

2014-11-10 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/137#issuecomment-62421501 I commented in TS-2959 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] trafficserver pull request: TS-3155

2014-11-10 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/139#issuecomment-62421425 This looks pretty good. Please use `strncasecmp() == 0` instead of `!strncasecmp()`. The former is easier to read and consistent with the rest of the code.

[GitHub] trafficserver pull request: TS-3105

2014-11-10 Thread shinrich
Github user shinrich closed the pull request at: https://github.com/apache/trafficserver/pull/140 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] trafficserver pull request: TS-3105

2014-11-10 Thread shinrich
Github user shinrich commented on the pull request: https://github.com/apache/trafficserver/pull/140#issuecomment-62404722 Tracking down one more timing issue. Will request again in a bit. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] trafficserver pull request: TS-3105

2014-11-10 Thread shinrich
GitHub user shinrich opened a pull request: https://github.com/apache/trafficserver/pull/140 TS-3105 Fixes to improve post, memory usage, and reduce connection leaks. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shinrich/traffi

[GitHub] trafficserver pull request: TS-3155

2014-11-10 Thread shinrich
GitHub user shinrich opened a pull request: https://github.com/apache/trafficserver/pull/139 TS-3155 Adding value_get_index to test for presence of value in MIME header field. Using it in the keep alive checks. There are other places in the code where this change can be used

[GitHub] trafficserver pull request: TS-3024

2014-11-10 Thread shinrich
GitHub user shinrich opened a pull request: https://github.com/apache/trafficserver/pull/138 TS-3024 Compile with the OPENSSL_NO_SSL_INTERN flag. Move intern exceptions into SSLInternal.c. You can merge this pull request into a Git repository by running: $ git pull https://git

[GitHub] trafficserver pull request: TS-2959

2014-11-10 Thread shinrich
GitHub user shinrich opened a pull request: https://github.com/apache/trafficserver/pull/137 TS-2959 Fix gcc 4.9.2 compiler warning. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shinrich/trafficserver ts-2959 Alternatively you