[GitHub] trafficserver pull request: patch for TS-2834

2014-05-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/91 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

Re: [API REVIEW] TSHttpIsInternalSession

2014-05-29 Thread James Peach
On May 29, 2014, at 12:02 PM, Leif Hedstrom wrote: > > On May 28, 2014, at 10:12 PM, James Peach wrote: > >> Hi all, >> >> I'd like to add a session-oriented counterpart to TSHttpIsInternalRequest, >> named TSHttpIsInternalSession: >> >> TSReturnCode TSHttpIsInternalSession(TSHttpSsn s

Re: [API REVIEW] TSHttpIsInternalSession

2014-05-29 Thread Leif Hedstrom
On May 28, 2014, at 10:12 PM, James Peach wrote: > Hi all, > > I'd like to add a session-oriented counterpart to TSHttpIsInternalRequest, > named TSHttpIsInternalSession: > > TSReturnCode TSHttpIsInternalSession(TSHttpSsn ssnp); After reviewing another bug, I’m wondering if we should

Spring cleaning on the branches

2014-05-29 Thread Leif Hedstrom
Hi all, I’d like to remove the following branches in our git repo. If any of you (one “vote” is enough) want to preserve/keep any of these, please voice that opinion in the next 72h. Thanks, — leif remotes/origin/TS-645 remotes/origin/TS-645-hard-restart remotes/origin/consistent-errors

Re: [API REVIEW] TSHttpIsInternalSession

2014-05-29 Thread Leif Hedstrom
+1 > On May 28, 2014, at 10:12 PM, James Peach wrote: > > Hi all, > > I'd like to add a session-oriented counterpart to TSHttpIsInternalRequest, > named TSHttpIsInternalSession: > >TSReturnCode TSHttpIsInternalSession(TSHttpSsn ssnp); > > This API has identical semantics to TSHttpIsInter

Re: git commit: TS-2753: Add more SPDY and HTTPS statistics Reviewed: Bryan Call

2014-05-29 Thread James Peach
On May 29, 2014, at 12:19 AM, Wei Sun wrote: > > > On 5/29/14, 1:36 AM, "Bryan Call" wrote: > >> >> On May 26, 2014, at 6:00 PM, James Peach wrote: >> >>> Bryan, >>> >>> How are you expecting proxy.process.ssl.total_handshake_time to be >>> used? What units is it in? Unless I'm missing so

Re: git commit: TS-2753: Add more SPDY and HTTPS statistics Reviewed: Bryan Call

2014-05-29 Thread Wei Sun
On 5/29/14, 1:36 AM, "Bryan Call" wrote: > >On May 26, 2014, at 6:00 PM, James Peach wrote: > >> Bryan, >> >> How are you expecting proxy.process.ssl.total_handshake_time to be >>used? What units is it in? Unless I'm missing something, the aggregate >>handshake time does not seem very interes