On May 29, 2014, at 12:02 PM, Leif Hedstrom <zw...@apache.org> wrote:
> > On May 28, 2014, at 10:12 PM, James Peach <jpe...@apache.org> wrote: > >> Hi all, >> >> I'd like to add a session-oriented counterpart to TSHttpIsInternalRequest, >> named TSHttpIsInternalSession: >> >> TSReturnCode TSHttpIsInternalSession(TSHttpSsn ssnp); > > > After reviewing another bug, I’m wondering if we should maybe name this > > TSHttpIsInternalSsn() > > > I don’t feel strongly either way, Ssn / Txn seems used fairly frequently. > > > I’m also filing a separate Jira on naming convention for the existing API, I > think it should be either > > TSHttpIsInternalTransaction() > > or > > TSHttpIsInternalTxn() I'm not going to change the names as part of this proposal, and I think that whatever the names are, they should match. If you want to change them, you should use the standard naming conventions TSHttpTxnIsInternal, TSHttpSsnIsInternal. That said, if you change them you are going to break a lot of plugins. J
