Re: WebSocket support

2014-01-31 Thread Brian Geffon
I suppose you're right, it will short circuit anyway. So yah, I can move them up. Brian On Friday, January 31, 2014, Leif Hedstrom wrote: > Thanks! > > > I need to check the patch again , but not sure I understand why it be more > expensive to move up the method and version checks (they would s

Re: WebSocket support

2014-01-31 Thread Leif Hedstrom
Thanks! I need to check the patch again , but not sure I understand why it be more expensive to move up the method and version checks (they would still be after the presence checks). It also makes more logical sense to put all prerequisites in one statement. Cheers, -- Leif > On Jan 31, 20

Re: WebSocket support

2014-01-31 Thread Brian Geffon
See responses below. On Fri, Jan 31, 2014 at 4:05 PM, Leif Hedstrom wrote: > > On Jan 29, 2014, at 6:22 PM, Brian Geffon wrote: > > > Hi All, > > I've created a patch adding WebSocket support to ATS, I would appreciate > > community feedback. This is being tracked in TS-2541, the patch is > att

Re: WebSocket support

2014-01-31 Thread Leif Hedstrom
On Jan 31, 2014, at 5:05 PM, Leif Hedstrom wrote: > > On Jan 29, 2014, at 6:22 PM, Brian Geffon wrote: > >> Hi All, >> I've created a patch adding WebSocket support to ATS, I would appreciate >> community feedback. This is being tracked in TS-2541, the patch is attached >> to the jira ticket

Re: WebSocket support

2014-01-31 Thread Leif Hedstrom
On Jan 29, 2014, at 6:22 PM, Brian Geffon wrote: > Hi All, > I've created a patch adding WebSocket support to ATS, I would appreciate > community feedback. This is being tracked in TS-2541, the patch is attached > to the jira ticket https://issues.apache.org/jira/browse/TS-2541 Couple of nitp

Re: 4.2.x branch

2014-01-31 Thread Leif Hedstrom
On Jan 27, 2014, at 11:06 AM, Phil Sorber wrote: > Hello All, > > I plan to fork 4.2.x some time early next week. Here is the list of issues > that are not resolved for 4.2.0: > > https://issues.apache.org/jira/browse/TS-2533?jql=project%20%3D%20TS%20AND%20fixVersion%20%3D%20%224.2.0%22%20AND%