On Jan 31, 2014, at 5:05 PM, Leif Hedstrom <zw...@apache.org> wrote:
> > On Jan 29, 2014, at 6:22 PM, Brian Geffon <bri...@apache.org> wrote: > >> Hi All, >> I've created a patch adding WebSocket support to ATS, I would appreciate >> community feedback. This is being tracked in TS-2541, the patch is attached >> to the jira ticket https://issues.apache.org/jira/browse/TS-2541 > > > > Couple of nitpicks / observations: > > 1. You are adding some new connection metric. Do these count against HTTP(S) > connections as well? I’m assuming not, in which case, there might be some > aggregation metrics (stats.config.xml) that should be updated accordingly. Also, forgot to include it, but there is (I’m pretty sure) logic around counting client connections and using that to decide if a new connection should be accepted or not (“throttling”). This might affect that as well. — leif
