Re: git commit: TS-2526: remove the g_stats_snap_fpath global variable

2014-01-24 Thread James Peach
On Jan 24, 2014, at 12:19 AM, Leif Hedstrom wrote: > > On Jan 24, 2014, at 2:15 AM, jpe...@apache.org wrote: > >> Updated Branches: >> refs/heads/master c2434df8c -> 5b163671c >> >> >> TS-2526: remove the g_stats_snap_fpath global variable > > > I agree with the addition of RecConfigReadPer

Re: git commit: TS-2425: Update to TS-2261 for loading plugins as root

2014-01-24 Thread Bryan Call
Yes, removing elevate on new and delete instance does break backwards compatibility, but I don't think anyone including Y is using it. If you want me to back out that change I can. -Bryan On Jan 24, 2014, at 5:11 PM, James Peach wrote: > > On Jan 23, 2014, at 1:33 PM, Bryan Call wrote: >

Re: git commit: TS-2425: Update to TS-2261 for loading plugins as root

2014-01-24 Thread James Peach
On Jan 23, 2014, at 1:33 PM, Bryan Call wrote: > I removed elevation on delete and new instance. It is needed in dlopen > because the libraries that we link with in our plugins need root privileges > when they statically initialize things. Ah, static initializers. Is removing the elevation o

Re: git commit: TS-2425: Update to TS-2261 for loading plugins as root

2014-01-24 Thread Igor Galić
> > b/proxy/http/remap/RemapConfig.cc > > index bc4a16b..787fbb0 100644 > > --- a/proxy/http/remap/RemapConfig.cc > > +++ b/proxy/http/remap/RemapConfig.cc > > @@ -663,44 +663,6 @@ remap_load_plugin(const char ** argv, int argc, > > url_mapping *mp, char *errbuf, i > > } > > Debug("remap

Re: git commit: TS-2425: Update to TS-2261 for loading plugins as root

2014-01-24 Thread Igor Galić
- Original Message - > Updated Branches: > refs/heads/master 00897775d -> cd86569e9 > > > TS-2425: Update to TS-2261 for loading plugins as root > > > Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo > Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/co

Re: git commit: TS-2526: remove the g_stats_snap_fpath global variable

2014-01-24 Thread Bahram Akhundov
Hi Leif :) what are so panic ?) gr33tz... Am 24.01.2014 12:19, schrieb Leif Hedstrom: On Jan 24, 2014, at 2:15 AM, jpe...@apache.org wrote: Updated Branches: refs/heads/master c2434df8c -> 5b163671c TS-2526: remove the g_stats_snap_fpath global variable I agree with the addition of

Re: git commit: TS-2526: remove the g_stats_snap_fpath global variable

2014-01-24 Thread Leif Hedstrom
On Jan 24, 2014, at 2:15 AM, jpe...@apache.org wrote: > Updated Branches: > refs/heads/master c2434df8c -> 5b163671c > > > TS-2526: remove the g_stats_snap_fpath global variable I agree with the addition of RecConfigReadPersistentStatsPath(), that’s nice, but is it really that important to