> > b/proxy/http/remap/RemapConfig.cc
> > index bc4a16b..787fbb0 100644
> > --- a/proxy/http/remap/RemapConfig.cc
> > +++ b/proxy/http/remap/RemapConfig.cc
> > @@ -663,44 +663,6 @@ remap_load_plugin(const char ** argv, int argc,
> > url_mapping *mp, char *errbuf, i
> >      }
> >      Debug("remap_plugin", "New remap plugin info created for \"%s\"", c);
> >  
> > -    if ((pi->dlh = dlopen(c, RTLD_NOW)) == NULL) {
> > -#if defined(freebsd) || defined(openbsd)
> > -      err = (char *)dlerror();
> > -#else
> > -      err = dlerror();
> > -#endif
> 
> Why is this #if dance necessary here?
> 
> http://www.freebsd.org/cgi/man.cgi?dlerror dlerror() hasn't been const char*
> since
> FreeBSD 8.1. In OpenBSD it's still *is* ...broken, but then we should
> abstract that
> into a wrapper function of our own at autoconf time.
> 
> We're not handling this case at every call of dlerror() anyways.. so....


https://issues.apache.org/jira/browse/TS-2529


-- 
Igor Galić

Tel: +43 (0) 664 886 22 883
Mail: i.ga...@brainsware.org
URL: http://brainsware.org/
GPG: 8716 7A9F 989B ABD5 100F  4008 F266 55D6 2998 1641

Reply via email to