Re: [jira] [Assigned] (TIKA-245) Support of CHM Format

2011-06-07 Thread Oleg Tikhonov
Thank you Chris and Jukka! I tried to keep the KISS principle, but couldn't. On Tue, Jun 7, 2011 at 6:49 PM, Chris A. Mattmann (JIRA) wrote: > > [ > https://issues.apache.org/jira/browse/TIKA-245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel] > > Chris A. Mattmann reassi

[jira] [Commented] (TIKA-245) Support of CHM Format

2011-06-07 Thread Jukka Zitting (JIRA)
[ https://issues.apache.org/jira/browse/TIKA-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045506#comment-13045506 ] Jukka Zitting commented on TIKA-245: Nice! Next time, Oleg, feel free to commit your ch

Re: [jira] [Commented] (TIKA-245) Support of CHM Format

2011-06-07 Thread Mattmann, Chris A (388J)
Hey Jukka, Thanks for the motivation. I put my money where my mouth was :-) Oleg, your patch rox. That's all I had to say. My improvement was simply to commit it to the Tika sources. Feel free to mod/add/whatever on it after that, per Jukka's comments. I am going to make one more update, just

[jira] [Assigned] (TIKA-245) Support of CHM Format

2011-06-07 Thread Chris A. Mattmann (JIRA)
[ https://issues.apache.org/jira/browse/TIKA-245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris A. Mattmann reassigned TIKA-245: -- Assignee: Chris A. Mattmann > Support of CHM Format > - > >

[jira] [Resolved] (TIKA-245) Support of CHM Format

2011-06-07 Thread Chris A. Mattmann (JIRA)
[ https://issues.apache.org/jira/browse/TIKA-245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris A. Mattmann resolved TIKA-245. Resolution: Fixed Fix Version/s: 1.0 OK, in r1133047, 1133048, 1133049 and 1133050, I

Re: [jira] [Commented] (TIKA-245) Support of CHM Format

2011-06-07 Thread Mattmann, Chris A (388J)
Hey Jukka, On Jun 7, 2011, at 6:55 AM, Jukka Zitting wrote: > Hi, > > On Tue, Jun 7, 2011 at 3:52 PM, Mattmann, Chris A (388J) > wrote: >> Please revert r1132997, and then just modify your patch to make sure that >> your java classes and files fit into the appropriate Tika source code area. >>

Re: [jira] [Commented] (TIKA-245) Support of CHM Format

2011-06-07 Thread Jukka Zitting
Hi, On Tue, Jun 7, 2011 at 3:52 PM, Mattmann, Chris A (388J) wrote: > Please revert r1132997, and then just modify your patch to make sure that > your java classes and files fit into the appropriate Tika source code area. > Then please attach a new patch real quick so I (or some other committer)

Re: [jira] [Commented] (TIKA-245) Support of CHM Format

2011-06-07 Thread Mattmann, Chris A (388J)
Hi Oleg, On Jun 7, 2011, at 6:28 AM, Oleg Tikhonov wrote: > Hi Chris, > > I've applied the patch to the > tika-parsers/src/main/java/org/apache/tika/parser/chm, also added 3 chm > files to the tika-parsers\src\test\resources\test-documents and the tests. Thanks sorry I think I confused you with

Re: [jira] [Commented] (TIKA-245) Support of CHM Format

2011-06-07 Thread Oleg Tikhonov
Hi Chris, I've applied the patch to the tika-parsers/src/main/java/org/apache/tika/parser/chm, also added 3 chm files to the tika-parsers\src\test\resources\test-documents and the tests. BR, Oleg On Sun, Jun 5, 2011 at 1:32 AM, Chris A. Mattmann (JIRA) wrote: > >[ > https://issues.apache.or

Jenkins build is back to normal : Tika-trunk #560

2011-06-07 Thread Apache Jenkins Server
See

[jira] [Commented] (TIKA-568) Language Detection isReasonablyCertain() hides valuable information

2011-06-07 Thread JIRA
[ https://issues.apache.org/jira/browse/TIKA-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045312#comment-13045312 ] Jan Høydahl commented on TIKA-568: -- Or perhaps better, a getProbability() method returning

[jira] [Commented] (TIKA-568) Language Detection isReasonablyCertain() hides valuable information

2011-06-07 Thread JIRA
[ https://issues.apache.org/jira/browse/TIKA-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045311#comment-13045311 ] Jan Høydahl commented on TIKA-568: -- An intermediate step would perhaps be to add the getDis