Hey Jukka, Thanks for the motivation. I put my money where my mouth was :-)
Oleg, your patch rox. That's all I had to say. My improvement was simply to commit it to the Tika sources. Feel free to mod/add/whatever on it after that, per Jukka's comments. I am going to make one more update, just to add the parser to the SPI provider file for Parsers. Thanks guys! Cheers, Chris On Jun 7, 2011, at 7:27 AM, Mattmann, Chris A (388J) wrote: > Hey Jukka, > > On Jun 7, 2011, at 6:55 AM, Jukka Zitting wrote: > >> Hi, >> >> On Tue, Jun 7, 2011 at 3:52 PM, Mattmann, Chris A (388J) >> <chris.a.mattm...@jpl.nasa.gov> wrote: >>> Please revert r1132997, and then just modify your patch to make sure that >>> your java classes and files fit into the appropriate Tika source code area. >>> Then please attach a new patch real quick so I (or some other committer) >>> can verify and then you're good to go. >> >> Oleg's a committer like anyone else, so IMHO there's no need for an >> extra round of review. CTR and all that. >> >> If you have ideas on how to improve on Oleg's commit, you can post a >> patch or commit the improvements directly. > > I thought about doing that after sending the email -- that said, I was trying > to give him a shot to do it. > > If he doesn't, or if no one else does soon, I'll get to it this weekend. > > Cheers, > Chris > > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > Chris Mattmann, Ph.D. > Senior Computer Scientist > NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA > Office: 171-266B, Mailstop: 171-246 > Email: chris.a.mattm...@nasa.gov > WWW: http://sunset.usc.edu/~mattmann/ > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > Adjunct Assistant Professor, Computer Science Department > University of Southern California, Los Angeles, CA 90089 USA > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Chris Mattmann, Ph.D. Senior Computer Scientist NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA Office: 171-266B, Mailstop: 171-246 Email: chris.a.mattm...@nasa.gov WWW: http://sunset.usc.edu/~mattmann/ ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Adjunct Assistant Professor, Computer Science Department University of Southern California, Los Angeles, CA 90089 USA ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
