Re: [dev] [st] [PATCH] Replace close and dup with dup2.

> > Second I don't have any warning with any of the compilers I use. > > Good for you. How is that in any way relevant? There is no prescribed > compiler, is there? Also, the idea with this sort of distribution model > is that the users also catch things that the maintainer won't. I wanted to sa

[dev] Moving scc

Hi, It is long time since I began to collaborate with suckless, I think almost 6 years. In that time I send patches for a lot of different projects, but the majority of them were for st, becoming eventually the maintainer of it. But this mail is not about all these projects, it is about scc, the

Re: [dev] ncurses or ...

complexity) which is the base for your TUI (split the program in two parts, one, the terminal which handles all the graphic issues, and other the editor which does the functional part). Regards, ---------- Roberto E. Vargas Caballero

Re: [dev] ncurses or ...

set your terminal to return to normal mode) You can see that the terminal already has the important functions. Curses is only a layer which translate between keys and escape sequences, but you already have the ascii mode of the terminal where all the keys generate the correct sequence for the function that they are supposed to implement. Regards, -- Roberto E. Vargas Caballero

[dev] [PATCH] Fix SHIFT+DEL definition

The AppMode and AsciiMode were inverted in the definition of this combination. --- config.def.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/config.def.h b/config.def.h index 986f6e2..4664416 100644 --- a/config.def.h +++ b/config.def.h @@ -186,8 +186,8 @@ static Key

[dev]

After writing this mail I discovered a bug in the Shift+Del definition.

Re: [dev] ncurses or ...

st an editor is stupid. You should avoid words as 'stupid', if you don't want to convert this in something personal. If you don't agree with an idea, please indicate the technical reasons, or in other case shut up. -- Roberto E. Vargas Caballero

[dev] [st][PATCH 1/4] Make CONTROL + DELETE delete a line

If CONTROL + INSERT inserts a line then it seems natural CONTROL + DELETE removes a line. Signed-off-by: Roberto E. Vargas Caballero --- config.def.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/config.def.h b/config.def.h index 4664416..d0fc186 100644 --- a

[dev] [st][PATCH 2/4] Make Shift+Home equal to CLS in ascii mode

Signed-off-by: Roberto E. Vargas Caballero --- config.def.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/config.def.h b/config.def.h index d0fc186..b31d7d6 100644 --- a/config.def.h +++ b/config.def.h @@ -153,7 +153,8 @@ static uint ignoremod = Mod2Mask|XK_SWITCH_MOD

[dev] [st][PATCH 1/4] Make CONTROL + DELETE delete a line

If CONTROL + INSERT inserts a line then it seems natural CONTROL + DELETE removes a line. Signed-off-by: Roberto E. Vargas Caballero --- config.def.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/config.def.h b/config.def.h index 4664416..d0fc186 100644 --- a

[dev] [st][PATCH 4/4] Remove non defined behaviour in selcopy

It is not defined when lateral effects of expressions are calculated, so an expression as: --last >= gp && !(selected(last - gp, y) is non portable. Signed-off-by: Roberto E. Vargas Caballero --- st.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --g

[dev] [st][PATCH 3/4] Remove duplicated code in strhandle

The error condition was duplicated in two different switches. This new version centralized the error handling in only one place. Signed-off-by: Roberto E. Vargas Caballero --- st.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/st.c b/st.c index

[dev] [st][PATCH 3/4] Remove duplicated code in strhandle

The error condition was duplicated in two different switches. This new version centralized the error handling in only one place. Signed-off-by: Roberto E. Vargas Caballero --- st.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/st.c b/st.c index

[dev] [st][PATCH 2/4] Make Shift+Home equal to CLS in ascii mode

Signed-off-by: Roberto E. Vargas Caballero --- config.def.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/config.def.h b/config.def.h index d0fc186..b31d7d6 100644 --- a/config.def.h +++ b/config.def.h @@ -153,7 +153,8 @@ static uint ignoremod = Mod2Mask|XK_SWITCH_MOD

[dev] [st][PATCH 4/4] Remove non defined behaviour in selcopy

It is not defined when lateral effects of expressions are calculated, so an expression as: --last >= gp && !(selected(last - gp, y) is non portable. Signed-off-by: Roberto E. Vargas Caballero --- st.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --g

[dev] [st][PATCH] Add xstrdup function

Since we are using xmalloc, xrealloc ..., then it is not logical call directly to strdup. Signed-off-by: Roberto E. Vargas Caballero --- st.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/st.c b/st.c index 6e7077a..49dd889 100644 --- a/st.c +++ b/st.c

Re: [dev] Reasonable Makefiles

inclussion dependences and other things). Regards, -- Roberto E. Vargas Caballero

Re: [dev] Reasonable Makefiles

rates Makefile, so the user knows that he is working with a generated Makefile). I usually don't like this way because the user should read the documentation and see the Makefile/makefile issue. Regards, -- Roberto E. Vargas Caballero

Re: [dev] [st] [PATCH] Allow mouse copy-paste for programs that claim mouse to themselves by holding shift

r "Shift" is pressed, and > instead processing such events themselves. This patch does just this. If nobody complaints about this patch I will apply it the next week. Regards, -- Roberto E. Vargas Caballero

Re: [dev] [st] [PATCH] Allow mouse copy-paste for programs that claim mouse to themselves by holding shift

minals support this feature? Regards, -- Roberto E. Vargas Caballero

Re: [dev] tmux/screen alternative

is patch makes obsolete the wiki patch about pipes). I hope send it in the next days. Regards, -- Roberto E. Vargas Caballero

[dev] [st][PATCH 1/6] Add MC sequence

This sequence control when the printer is enabled or disabled. This sequence control the behaviour of the -o option. --- st.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/st.c b/st.c index cad61bf..314bf3f 100644 --- a/st.c +++ b/st.c @@ -134,6 +134,7 @@

[dev] [st][PATCH 2/6] Add MC for a single line

This sequence print the current line. It is different to the 'printer on' sequence, where all the characters that arrive to the terminal are printer. Here only the ascii characters are printed. --- st.c | 41 - 1 file changed, 32 insertions(+), 9 deletions(-

[dev] [st][PATCH 3/6] Add MC for the full screen

This sequence is very useful because allows comunicate the content of the terminal to another program. --- st.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/st.c b/st.c index e60643c..1711842 100644 --- a/st.c +++ b/st.c @@ -358,6 +358,7 @@ static void strreset(void); static i

[dev] [st][PATCH 4/6] Add key definition for printer sequences

These new combinations generate the same behaviour (basically) of vt102. It is a good way of communicating st with other programs. [0] http://www.vt100.net/docs/vt102-ug/chapter2.html --- config.def.h | 2 ++ st.c | 12 2 files changed, 14 insertions(+) diff --git a/config.

[dev] [st][PATCH 5/6] Add sequence for printing the current selection

This is very usefull in order to can select what is sent to the plumber. --- config.def.h | 1 + st.c | 32 +--- 2 files changed, 30 insertions(+), 3 deletions(-) diff --git a/config.def.h b/config.def.h index 47018a3..58b470e 100644 --- a/config.def.h +++ b/c

[dev] [st][PATCH 6/6] Add terminfo entries for printer

These capabilities inform to programs how print in local printer of the terminal. --- st.info | 3 +++ 1 file changed, 3 insertions(+) diff --git a/st.info b/st.info index 7526141..4e60a89 100644 --- a/st.info +++ b/st.info @@ -152,6 +152,9 @@ st| simpleterm, ncv#3, op=\E[39;49m,

Re: [dev] Reasonable Makefiles

Darwin ) > echo 'Configuring for Darwin' >&2 > echo '# Extra configuration for Darwin (from config.uname)' > echo 'EXTRA_CPPFLAGS = -I/opt/local/include' > ;; > esac > It is similar to the configure of utmp, and usually it is the only thing you need. Regards, -- Roberto E. Vargas Caballero

Re: [dev] [st] problems with terminfo entries and zsh

in different shell versions emitting different > key codes: There are some shells that have bugs, and another that don't have bugs. I begin to be a bit tired of answer the same question all the times. Regards, [1] : http://st.suckless.org/ -- Roberto E. Vargas Caballero

Re: [dev] [st] problems with terminfo entries and zsh

ic database anymore. They have a binary database built with Berkeley DB. You can find a solution to this issue in this thread: http://lists.suckless.org/dev/1309/17580.html. If you can find a better way could be good for st & OpenBSD users. Regards, -- Roberto E. Vargas Caballero

Re: [dev][st][patch] new utf decoder

> It is number of function calls, on cat dwm > > cat UTF-8-demo yields: > utflen 113 > utfencode 8152 > utfdecode 198346 > > So I think only utfdecode need to be optimised if necessary. I also like the patch, so if nobody complaints about it then I will apply next week.

Re: [dev][st][patch] new utf decoder

should be improved. Could you send a fixed patch? Regards, -- Roberto E. Vargas Caballero

Re: [dev][st][patch] new utf decoder

ake me a day or two though and the credit for > the patch would have to go to Damian of course. I agree. Regards, -- Roberto E. Vargas Caballero

Re: [dev][st][patch] new utf decoder

> Find Damian's slightly altered patch below. I hope he is okay with us > applying this version of his patch. > > Just tell me if I should change something. For me is ok, and again, if nobody complaints about it I will apply it. Regards, -- Roberto E. Vargas Caballero

Re: [dev] [st][patch] Fix segfault when pressing PrintScr without a selection

*.jpg) sxiv $1 ;; esac Of course, in the case of *.jpg it will work only if the selection is an absolute name, or the plumber and st are in the same directory. Regards, -- Roberto E. Vargas Caballero

Re: [dev] st stutter and freeze during window resize via mouse drag

ople. Yeah I agree with you Christoph, but I was asking me if we should think in a new stable version. I would like try to get updated the terminfo definition of st by the terminfo maintainer, and it is something I would not like do often. Regards, -- Roberto E. Vargas Caballero

[dev] New version of st

't want find some bugs like the segmentation fault of 672e4e4 after creating the stable version. Regards, -- Roberto E. Vargas Caballero

Re: [dev] st stutter and freeze during window resize via mouse drag

t, it is true we do not have this feature. I don't know why it was in the definition. Regards, -- Roberto E. Vargas Caballero

[dev] Backspace (was: st stutter and freeze ...)

hen a user connects to my unix machines from a different system with a correct backspace key. I would like listen the opinion of st users about this topic before of doing this kind of modifications. Regards, [1] http://www.ibb.net/~anne/keyboard.html [2] http://www.tldp.org/HOWTO/Keyboard-and-Console-HOWTO-5.html -- Roberto E. Vargas Caballero

Re: [dev] [st] [patch] typedefs instead of #defines

hese defines. Regards, -- Roberto E. Vargas Caballero

Re: [dev] Backspace (was: st stutter and freeze ...)

to my unix machines from a different system with > a correct backspace key. > > I would like listen the opinion of st users about this topic before > of doing this kind of modifications. > > > Regards, > > > [1] http://www.ibb.net/~anne/keyboard.html > [2] http://www.tldp.org/HOWTO/Keyboard-and-Console-HOWTO-5.html > -- > Roberto E. Vargas Caballero -- Roberto E. Vargas Caballero

Re: [dev] [st] [PATCH] fix cursor handling when alt screen is disabled

> I don't like this alt screen thing, but when > allowaltscreen == 0, the cursor is still saved > and restored after calling 'less' (or 'man'). > > This patch makes allowaltscreen == 1 usable. Good catch, but I think it makes allowaltscreen == 0 usable, d

Re: [dev] [st] [patch] XSync consistency

> >> Changes 0 to False. > > > > Forgot patch. > > This patch cleans up a style inconsistency. Thanks, I will apply it next week. -- Roberto E. Vargas Caballero

Re: [dev] Backspace (was: st stutter and freeze ...)

d DELETE, so if we only remove the line we solve both problems fixed (of course and modify the terminfo definition). Regards, -- Roberto E. Vargas Caballero

Re: [dev] [st] Understading st behaviour

yaourt it hangs when asking if you want > to continue building a package and you can't pass keys to stdin, they > are printed on the screen. I'm sorry, but I cannot understand you here. Could you explain a bit more about this problem? Regards, -- Roberto E. Vargas Caballero

[dev] [st][PATCH] Fix Backspace and Delete characters

Backspace key must generate the backspace character (\010) and Delete key must generate the delete character (\0177). In some systems the kernel configuration for erasing previous character is \0177, so some programs (for example cat, ed, mail, ...), can not understand the correct meaning of backsp

Re: [dev] [st] [patch] redundant gettimeofday

Christoph, are you again to apply this patch now? Regards, -- Roberto E. Vargas Caballero

Re: [dev] [st] [patch] redundant gettimeofday

On Fri, Apr 11, 2014 at 04:25:26PM +0200, Roberto E. Vargas Caballero wrote: > Christoph, are you again to apply this patch now? Bad typo, I wanted to say "are you going to ...". Sometimes my dislexia makes bad things, sorry. -- Roberto E. Vargas Caballero

Re: [dev] [st] Understading st behaviour

Regards, -- Roberto E. Vargas Caballero

Re: [dev] [PATCH] Don't make bold text bright with default color

havior, otherwise it's making the > bold text hard to read on a gray background ;-) standard? could you explain what standard are you talking?, because I think no iso, or ansi, or whenever you want made a standard about it. Regards, -- Roberto E. Vargas Caballero

Re: [dev] [PATCH] Don't make bold text bright with default color

w option to st could be good. What opinion do you have guys? Regards, -- Roberto E. Vargas Caballero

Re: [dev] [PATCH] remove confusing SERRNO macro

ds to new patches, which don't use this > macro I agree, and I think is better to remove it instead of adding it in the places where it is not used. Regards, -- Roberto E. Vargas Caballero

Re: [dev] [st] [patch] move MODBIT to Macros section

> Patch moves MODBIT to macros section and uses it in tselcs. Good catch, I'll apply the patch. -- Roberto E. Vargas Caballero

Re: [dev] [st] [patch] misplaced parenthesis in LEN macro

> #define LEN(x) (sizeof (x) / sizeof *(x)) I am used to read the other form, but I thing it is only a question of personal taste, and since the other form was sent before your suggestion I'll apply it. Regards, -- Roberto E. Vargas Caballero

Re: [dev] [st] [patch] move MODBIT to Macros section

hat alot mail client is not working anymore with st. I am pretty busy lately and I do not have time to fix it, so could be good if anyone help in this point. I have more information about this problem if it is required. Regards, -- Roberto E. Vargas Caballero

Re: [dev] [PATCH] [st 1/3] Use tsetdirt in tscrollup and tscrolldown.

, orig, term.col-1, orig+n-1); tsetdirt(orig+n, term.bot); Is there any reason to do it in different order?. I think is more understable if the order is the same in both cases. Regards, -- Roberto E. Vargas Caballero

Re: [dev] [st] [PATCH 1/6] Use BETWEEN in tinsertblankline and tdeleteline.

Hi, I am going to apply the full set of patches. Thanks!! -- Roberto E. Vargas Caballero

Re: [dev] [st] [PATCH] Fix techo handling of control characters.

s the reason why tputc has this check). If you modify the commit message and explain the problem with the DEL as the reason for the commit I will apply it. Regards, -- Roberto E. Vargas Caballero

Re: [dev] [st] [PATCH] Fix techo handling of control and multibyte characters.

Applied with a small modification. Thanks -- Roberto E. Vargas Caballero

Re: [dev] [PATCH] [st 1/3] Use tsetdirt in tscrollup and tscrolldown.

ut how dirty bit is set. Regards, -- Roberto E. Vargas Caballero

Re: [dev] [st] [PATCH] Fix techo handling of control and multibyte characters.

to follow the GNU criteria, that is the more suck criteria I know (I think it is because they come from the LISP world, and they want to see your code formatted as LISP, and force you to put a lot of unneded parenthesis ;). Regards, -- Roberto E. Vargas Caballero

Re: [dev] [st] [PATCH] Fix techo handling of control and multibyte characters.

basically the typedef rule. I accept typedef of struct always that the new type begins with upper case. -- Roberto E. Vargas Caballero

Re: [dev] [st] [PATCH] Fix techo handling of control and multibyte characters.

th BETWEEN I will apply it. Regards, -- Roberto E. Vargas Caballero

Re: [dev] [st PATCH 1/4] Simplify tsetscroll.

Applied, thanks! -- Roberto E. Vargas Caballero

[dev] [st][PATCH] Simplify a bit more tdeletechar and tinsertblank

The large and repeated expression used in memmove to indirect the line can be simplified using a pointer, that makes more clear where begins and where ends the movement. --- st.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/st.c b/st.c index 263abaa..e468d73 10064

Re: [dev] [st PATCH 2/4] Use BETWEEN macro in xsetcolorname and fix style.

Hi, It makes sense with the rest of the code, so I'll apply it. Regards, -- Roberto E. Vargas Caballero

Re: [dev] [st PATCH 3/4] Use != instead of ^ for logical values.

> - if(sel.alt ^ IS_SET(MODE_ALTSCREEN)) > + if(sel.alt != IS_SET(MODE_ALTSCREEN)) This bit logical operation comes from another age when IS_SET had not a comparision operator. It does not make sense anymore, so this change is good. Regards, -- Roberto E. Vargas Caballero

Re: [dev] [st PATCH 4/4] Optimize tputtab.

t ugly), so I will apply it to. Regards, -- Roberto E. Vargas Caballero

Re: [dev] [st] [PATCH] On terminal resize, clear the alt screen with its own cursor.

> Currently the alternate screen get messed up on resize if it has > different colors or mode. Good catch, I'll apply it. Regards, -- Roberto E. Vargas Caballero

Re: [dev] [st patch queue 01/12] Simplify tsetscroll.

not a second version. -- Roberto E. Vargas Caballero

Re: [dev] [st patch queue 04/12] Comment fix.

> - * As seen in selcopy: > + * As seen in getsel: Good catch, I'll apply it. Regards, -- Roberto E. Vargas Caballero

Re: [dev] [st patch queue 06/12] Avoid integer overflow in dump().

col = 0; > + } > } dump is not used in any place. It is dead code, so I think the solution is to remove the function. Regards, -- Roberto E. Vargas Caballero

Re: [dev] [st patch queue 05/12] Consistent FALLTHROUGH comments.

h you that the best comment is FALLTHROUGH (I used FALLTHRU in the past because it was used in a project where I worked), that is the comment that lint understand. Regards, -- Roberto E. Vargas Caballero

Re: [dev] [st patch queue 07/12] Remove unnecessary break;s

not harm and help a more consistent style. If we > can > agree on it, I'll write the patch to add break;s for the last switch-cases, > where they are missing. Yeah, I agree, and I am going to commit the patch of nonamed only with the break in the beginnig of the switch. Regards, -- Roberto E. Vargas Caballero

Re: [dev] [st patch queue 08/12] Use xwrite instead of write.

It makes sense, so I will apply it. Regards, -- Roberto E. Vargas Caballero

Re: [dev] [st patch queue 10/12] s/DSC/DCS/ DCS stands for DEVICE CONTROL STRING

> - case 'P': /* DSC -- Device Control String */ > + case 'P': /* DCS -- Device Control String */ I begin to think that you have a very good eyes, because we didn't realise this stupid typo. Thanks!!! -- Roberto E. Vargas Caballero

Re: [dev] [st patch queue 11/12] Fix for multibyte characters in techo.

Applied to, thanks!!! -- Roberto E. Vargas Caballero

Re: [dev] [st patch queue 12/12] Do not eat ESC character if control string is not properly terminated.

sequence, control sequence, or device control string in progress. So I understand CAN should also cancel the sequence. I am going to apply your patch, but I am going to write a patch serie for the rest of cases. Regards, [1] http://www.vt100.net/docs/vt510-rm/chapter4 --

[dev] [st][PATCH] Cancel DCS with SUB, CAN, ESC or any CC1 code

>From http://www.vt100.net/docs/vt510-rm/chapter4: *The VT510 ignores all following characters until it receives a SUB, ST, or any other C1 control character. So OSC, PM and APC sequence ends with a SUB (it cancels the sequence and show a question mark as error), ST or any anothe

[dev] [st][PATCH v2] Cancel DCS with SUB, CAN, ESC or any CC1 code

>From http://www.vt100.net/docs/vt510-rm/chapter4: *The VT510 ignores all following characters until it receives a SUB, ST, or any other C1 control character. So OSC, PM and APC sequence ends with a SUB (it cancels the sequence and show a question mark as error), ST or any anothe

Re: [dev] [PATCH] add break;s for last cases in switch statements

} > @@ -2550,6 +2553,7 @@ tputc(char *c, int len) { > fprintf(stderr, "erresc: unknown sequence ESC > 0x%02X '%c'\n", > (uchar) ascii, isprint(ascii)? > ascii:'.'); > term.esc = 0; > + break; > } > } > /* > -- > 1.8.3.2 > -- Roberto E. Vargas Caballero

[dev] [st][PATCH v3] Cancel DCS with SUB, CAN, ESC or any CC1 code

>From http://www.vt100.net/docs/vt510-rm/chapter4: *The VT510 ignores all following characters until it receives a SUB, ST, or any other C1 control character. So OSC, PM and APC sequence ends with a SUB (it cancels the sequence and show a question mark as error), ST or any anothe

[dev] [st][PATCH 1/4] Remove repeated initialisation of term.esc

Once a sequence is completed term.esc must return to 0, so instead of repeating this expression in all the cases is better put it at the end of the block. --- st.c | 24 ++-- 1 file changed, 6 insertions(+), 18 deletions(-) diff --git a/st.c b/st.c index 124c047..0425c72 10064

[dev] [st][PATCH 2/4] Create a function for DEC test

Almost of the sequences execute their action in a separate function, which is good because helps to read the full set of sequences faster. --- st.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/st.c b/st.c index 0425c72..33e4277 100644 --- a/st.c +++

[dev] [st][PATCH 4/4] Simplify expressions in tputc()

--- st.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/st.c b/st.c index 339d8a9..470a34e 100644 --- a/st.c +++ b/st.c @@ -2450,6 +2450,7 @@ tputc(char *c, int len) { bool control; long unicodep; int width; + Glyph *gp;

[dev] [st][PATCH 3/4] Fix misplaced break

This misplaced break was causing an incorrect fall through from DSR to DECSTBM. --- st.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/st.c b/st.c index 33e4277..339d8a9 100644 --- a/st.c +++ b/st.c @@ -2087,8 +2087,8 @@ csihandle(void) { len = snprint

Re: [dev] [st PATCH 2/6] Use MODBIT in xseturgency.

I'll apply it, thanks. -- Roberto E. Vargas Caballero

Re: [dev] [st PATCH 1/6] Compute ena_sel as one expression.

I'll apply it, thanks. -- Roberto E. Vargas Caballero

Re: [dev] [st PATCH 3/6] Add missing function prototypes.

I'll apply it, thanks. -- Roberto E. Vargas Caballero

Re: [dev] [st PATCH 5/6] Remove unused dump() function.

I'll apply it, thanks. -- Roberto E. Vargas Caballero

Re: [dev] [st PATCH 6/6] Remove one indentation level in getsel().

I'll apply it, thanks. -- Roberto E. Vargas Caballero

Re: [dev] [st PATCH] tresize return value is not used

I think instead of removing the return value, we should check the value returned, and in case of not being possible the resize command then print a warning in stderr. Regards, -- Roberto E. Vargas Caballero

Re: [dev] [st PATCH] Use tfulldirt instead of setting all lines dirty in tresize.

> In fact tfulldirt should be removed completely, as tswapscreen calls > tfulldirt later (twice). Yeah, it is true, it can be removed, but in case of removing it, a comment should be put in tresize, because it is not ovbious that lines become dirty. Regards, -- Roberto E. Vargas Caballero

Re: [dev] [st PATCH] Simplify tputtab.

; !term.tabs[x]) I'm sorry, but this patch is incorrect, because it is implementation defined when side effects of expressions are applied, so x of !term.tabs[x] can be x before decrement, or x after decrement. Regards, -- Roberto E. Vargas Caballero

Re: [dev] [st] utf broken after aa35bbd7a16c6c210a7574a8c45bbe939d5b2922

at position 0 > [0]. It is possible that some line characters that are in the range of C0 are wrong drawn. I will look also this problem. -- Roberto E. Vargas Caballero

Re: [dev] [st] utf broken after aa35bbd7a16c6c210a7574a8c45bbe939d5b2922

) { @@ -2500,7 +2496,7 @@ tputc(char *c, int len) { * they must not cause conflicts with sequences. */ if(control) { - if (tcontrolcode(ascii)) + if (tcontrolcode(unicodep)) return; } else if(term.esc & ESC_START) { if(term.esc & ESC_CSI) { -- Roberto E. Vargas Caballero

Re: [dev] [st] [PATCH] Fix techo handling of control and multibyte characters.

tmoveto(term.c.x+width, term.c.y); } else { term.c.state |= CURSOR_WRAPNEXT; } but you also can find: if(xwrite(cmdfd, s, n) == -1) die("write error on tty: %s\n", strerror(errno)); So, is it mandatory parenthesis in one line if? I don't know it. Regards, -- Roberto E. Vargas Caballero

Re: [dev] [st PATCH] Simplify xunloadfonts.

> + while(frclen > 0) > + XftFontClose(xw.dpy, frc[--frclen].font); I'll apply the patch. -- Roberto E. Vargas Caballero

Re: [dev] [st PATCH 4/6] Do not export chscale and cwscale.

I'll apply it, thanks! -- Roberto E. Vargas Caballero

Re: [dev] [PATCH] Don't make bold text bright with default color

r this? (FAQ is part of st repository). Sorry for delay, but I have too much reviewing job lately. Regards, -- Roberto E. Vargas Caballero

  1   2   3   4   5   6   7   8   >