Hello, > u suffix was here for a purpose. The patch has comment about multibyte > characters. As 0x20u is unsigned, c was converted to unsigned char > before comparison so multibyte characters were not considered control > characters.
I realized it after send the patch. I prefer use uchar instead of suffix u. I known that gcc will complaint with a warning about pointer to data with different signess, but I think we are the programmers and not gcc, so using uchar is the way. Thinking a bit more about this, I don't know why we are using -Wall, because it moves people to follow the GNU criteria, that is the more suck criteria I know (I think it is because they come from the LISP world, and they want to see your code formatted as LISP, and force you to put a lot of unneded parenthesis ;). Regards, -- Roberto E. Vargas Caballero