Re: [dev] [surf] [PATCH] add per-site user styles

2014-11-17 Thread Nick
Quoth Markus Teich: > since the css domain selectors do not work in webkit, another approach needs > to > be taken to support custom css for specific sites. In config.h there is now a > list of regexes and corresponding css filenames. When a page is loaded and > userstyles are active, the first en

Re: [dev] [surf] [PATCH] add per-site user styles

2014-11-17 Thread Nick
Quoth Nick: > I haven't read the code closely yet, but at least in design I think > this should definitely be upstream. I just read the code, and tested it, and it all looks good to me. I don't like assigning variables when they're declared (as you do once), but it isn't uncommon practise in s

Re: [dev] [surf] [PATCH] add per-site user styles

2014-11-17 Thread Nick
Quoth Nick: > Quoth Markus Teich: > > since the css domain selectors do not work in webkit, another approach > > needs to > > be taken to support custom css for specific sites. In config.h there is now > > a > > list of regexes and corresponding css filenames. When a page is loaded and > > userst

Re: [dev] surf competition

2014-11-17 Thread Teodoro Santoni
On Sun, Nov 16, 2014 at 11:19:29PM +0100, hiro wrote: > https://sourceforge.net/projects/fifth-browser/files/ I laughed a lot yesterday! It's good new that someone hacked up a lightweighter Opera and plans to mantain it up-to-date on the Webkit upstream. Imho it's competitive to surf as qtweb is.

Re: [dev] [surf] [PATCH] add per-site user styles

2014-11-17 Thread Markus Teich
Nick wrote: > I have a slight preference for a separate configuration file that is read at > runtime, as I think that would be more usable. Heyho Nick, I have to disagree here. The default css should be sane enough to work with most of the pages. The custom sites need then only be used for regula

Re: [dev] surf competition

2014-11-17 Thread Calvin Morrison
On 17 November 2014 06:08, Teodoro Santoni wrote: > On Sun, Nov 16, 2014 at 11:19:29PM +0100, hiro wrote: >> https://sourceforge.net/projects/fifth-browser/files/ > > I laughed a lot yesterday! > It's good new that someone hacked up a lightweighter Opera and plans to > mantain it up-to-date on the

Re: [dev] [surf] [PATCH] add per-site user styles

2014-11-17 Thread Nick
Quoth Markus Teich: > Nick wrote: > > I have a slight preference for a separate configuration file that is read at > > runtime, as I think that would be more usable. > > I have to disagree here. The default css should be sane enough to work with > most > of the pages. The custom sites need then o

Re: [dev] [surf] [PATCH] add per-site user styles

2014-11-17 Thread FRIGN
On Mon, 17 Nov 2014 17:07:43 + Nick wrote: > You're right, it's only useful for sites you visit often, so > compiled in would be best. I completely agree. This is in line with the motivation for config.h. Even more importantly, surf doesn't take long to compile. I see no reason for parsed c

[dev] [sbase] style

2014-11-17 Thread Evan Gates
sbase has no unified style. Many things change from file to file. I am more annoyed by this than I should be. I propose a style document for sbase. I have included a starting point in order to promote discussion. You will disagree with some of these points. Speak up and explain your alternative and

Re: [dev] [sbase] style

2014-11-17 Thread FRIGN
On Mon, 17 Nov 2014 13:24:21 -0800 Evan Gates wrote: Hey Evan, > sbase has no unified style. Many things change from file to file. I am > more annoyed by this than I should be. I propose a style document for > sbase. I have included a starting point in order to promote > discussion. You will dis

Re: [dev] [sbase] style

2014-11-17 Thread Bobby Powers
Hello, FRIGN wrote: >> tests (boolean) >> === >> do not test against NULL explicitly (e.g. if (!p) instead of if (p == >> NULL)) >> do not test against 0 explicitly (e.g. if (!strcmp(p, q)) instead of >> if (strcmp(p, q) == 0)) (discuss) > > Yes, yes, yes. See the patches I sent i

Re: [dev] [sbase] style

2014-11-17 Thread Evan Gates
On Mon, Nov 17, 2014 at 1:47 PM, FRIGN wrote: > I must honestly say that you gotta work on your coding style a bit better. > I spent all evening yesterday and some hours this afternoon to untangle > your expr.c. It wasn't too bad, but for instance, you had unnecessary > global variables, unsafe po

Re: [dev] [sbase] style

2014-11-17 Thread FRIGN
On Mon, 17 Nov 2014 14:10:49 -0800 Bobby Powers wrote: > By default I read if (!functioncall()) as 'if the function call > failed'. I like the (strcmp(p, q) == 0) idiom because I don't fall > into the trap of reading the statement as 'if the string comparison > failed'. It is the one case I ca

Re: [dev] [sbase] style

2014-11-17 Thread Alex Pilon
> On Mon, 17 Nov 2014 13:24:21 -0800 Evan Gates wrote: > > headers > > === > > system headers (#include <...>) in alphabetical order > > empty line > > local headers (#include "...") in alphabetical order > > if there is any reason to change order, comment to explain > On Mon, Nov 17, 2014 at

Re: [dev] [sbase] style

2014-11-17 Thread koneu
Hi, FRIGN wrote: > If headers depend on order, the headers are broken. Dismissed. Most headers I write are plan9 style[0] headers. "The files are not protected against multiple inclusion and themselves contain no nested #includes. Instead the programmer is expected to sort out the requirements an