Re: [dev] [st] [patch] misplaced parenthesis in LEN macro

Martti Kühne, 22 April 2014 : > On Sun, Apr 20, 2014 at 9:24 PM, Rob wrote: >> Into the bikeshed I go... >> >> LEN(a + 2) doesn't mean anything anyway, as a's type decays. >> >> To do it properly there should be some kind of static assert in the >> macro that the argument is of array type. But thi

Re: [dev] [st] [PATCH] Fix techo handling of control and multibyte characters.

Applied with a small modification. Thanks -- Roberto E. Vargas Caballero

Re: [dev] [PATCH] [st 1/3] Use tsetdirt in tscrollup and tscrolldown.

> They are sorted by row number. ... > If you concatenate these ranges, you get orig..term.bot. For me it is a bit unclear, but I can understand that is more logical for another persons. I have applied this patch serie, but maybe could be a good idea add some comments in this functions about how

[dev] [st PATCH 1/4] Simplify tsetscroll.

--- st.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/st.c b/st.c index aba034f..ede90d5 100644 --- a/st.c +++ b/st.c @@ -1765,17 +1765,11 @@ tsetattr(int *attr, int l) { void tsetscroll(int t, int b) { - int temp; - LIMIT(t, 0, term.row-1);

[dev] [st PATCH 2/4] Use BETWEEN macro in xsetcolorname and fix style.

--- st.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/st.c b/st.c index ede90d5..07f408c 100644 --- a/st.c +++ b/st.c @@ -2750,10 +2750,10 @@ int xsetcolorname(int x, const char *name) { XRenderColor color = { .alpha = 0x }; Colour colour; -

[dev] [st PATCH 3/4] Use != instead of ^ for logical values.

sel.alt is only changed by sel.alt = IS_SET(MODE_ALTSCREEN); --- st.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/st.c b/st.c index 07f408c..e61ee68 100644 --- a/st.c +++ b/st.c @@ -3449,7 +3449,7 @@ drawregion(int x1, int y1, int x2, int y2) { bool ena_sel

[dev] [st PATCH 4/4] Optimize tputtab.

Before this patch executing printf '\e[100I' or printf '\e[100Z' resulted in long delay. --- st.c | 28 1 file changed, 12 insertions(+), 16 deletions(-) diff --git a/st.c b/st.c index e61ee68..964a0ae 100644 --- a/st.c +++ b/st.c @@ -3

Re: [dev] [st] [PATCH] Fix techo handling of control and multibyte characters.

On Wed, Apr 23, 2014 at 08:26:32PM +0200, Roberto E. Vargas Caballero wrote: > Applied with a small modification. Thanks u suffix was here for a purpose. The patch has comment about multibyte characters. As 0x20u is unsigned, c was converted to unsigned char before comparison so multibyte ch

Re: [dev][sandy][patch] minor typo correction

On Wed, Apr 23, 2014 at 7:26 AM, wrote: > Minor typo correction. > diff --git a/TODO b/TODO > index 6e01237..535a8e4 100644 > --- a/TODO > +++ b/TODO > @@ -13,7 +13,7 @@ In no particular order, at sandy.c: > At config.def.h: > - Bindings! > - Use local/system script path and all > -- Choose co

Re: [dev][sandy][patch] minor typo correction

Greetings. On Thu, 24 Apr 2014 06:33:00 +0200 Rafa Garcia Gallego wrote: > On Wed, Apr 23, 2014 at 7:26 AM, wrote: > > Minor typo correction. > > diff --git a/TODO b/TODO > > index 6e01237..535a8e4 100644 > > --- a/TODO > > +++ b/TODO > > @@ -13,7 +13,7 @@ In no particular order, at sandy.c: >

Re: [dev] [st] [PATCH] Fix techo handling of control and multibyte characters.

Hello, > u suffix was here for a purpose. The patch has comment about multibyte > characters. As 0x20u is unsigned, c was converted to unsigned char > before comparison so multibyte characters were not considered control > characters. I realized it after send the patch. I prefer use uchar inste