[dev] [surf] Double execution of masked key binding

2012-10-12 Thread Carlos Pita
Hi, this seems like a bug in surf 0.5 to me. When defining a couple of key bindings for the same key, one with a shift mask and the other without the mask, the commands for both bindings are executed in sequence when I press the shift-masked key once. For example: My keys[] { MODKEY,

Re: [dev] [surf] Double execution of masked key binding

2012-10-12 Thread Christoph Lohmann
Greetings. On Fri, 12 Oct 2012 11:45:04 +0200 Carlos Pita wrote: > Hi, > > this seems like a bug in surf 0.5 to me. When defining a couple of key > bindings for the same key, one with a shift mask and the other without > the mask, the commands for both bindings are executed in sequence when > I

Re: [dev] [surf] Double execution of masked key binding

2012-10-12 Thread Carlos Pita
Sorry Christoph, I've cloned the tip but the last changeset I'm able to see is: changeset: 245:7fe5e1810a81 tag: tip user:Christoph Lohmann <2...@r-36.net> date:Mon Jul 16 16:35:47 2012 +0200 summary: Surf now parses hex window ids properly from tabbed. have you push

Re: [dev] [surf] Double execution of masked key binding

2012-10-12 Thread Christoph Lohmann
Greetings. On Fri, 12 Oct 2012 12:31:17 +0200 Carlos Pita wrote: > Sorry Christoph, I've cloned the tip but the last changeset I'm able to see > is: Yes, I forgot to push the commit. It is now on the repository. Sincerely, Christoph Lohmann

[dev] [tabbed] attach on demand

2012-10-12 Thread Carlos Pita
Hi, I tend to open every surf instance (except for apps like gmail) in its own tabbed instance just because I don't know beforehand if I would need more tabs while navigating from the initial page. The ability to attach (and maybe detach) to tabbed on demand would be very handy in order to avoid t

Re: [dev] [tabbed] attach on demand

2012-10-12 Thread Hadrian Węgrzynowski
On Fri, 12 Oct 2012 08:07:55 -0300 Carlos Pita wrote: > Hi, > > I tend to open every surf instance (except for apps like gmail) in its > own tabbed instance just because I don't know beforehand if I would > need more tabs while navigating from the initial page. The ability to > attach (and maybe

[dev] [surf] zero percent in title bug

2012-10-12 Thread Carlos Pita
Hi, I found this patch for the bug but I don't think it's right to just hide the [0%] because there is the legitimate case when the page hasn't started to load yet. http://www.digipedia.pl/usenet/thread/15253/9123/ So I did this instead: case WEBKIT_LOAD_FINISHED: c->progress = 100;

Re: [dev] [surf] zero percent in title bug

2012-10-12 Thread Christoph Lohmann
Greetings. On Fri, 12 Oct 2012 19:42:11 +0200 Carlos Pita wrote: > Hi, > > I found this patch for the bug but I don't think it's right to just > hide the [0%] because there is the legitimate case when the page > hasn't started to load yet. > > http://www.digipedia.pl/usenet/thread/15253/9123/ >

Re: [dev] [surf] zero percent in title bug

2012-10-12 Thread Alexander Sedov
2012/10/12 Christoph Lohmann <2...@r-36.net>: > Greetings. > > On Fri, 12 Oct 2012 19:42:11 +0200 Carlos Pita > wrote: >> Hi, >> >> I found this patch for the bug but I don't think it's right to just >> hide the [0%] because there is the legitimate case when the page >> hasn't started to load yet

[dev] [surf] [patch] Middle click to open new tab/window (C version)

2012-10-12 Thread Carlos Pita
Hi, experiencing problems in some pages with the "middle click links" js script I wrote this patch to achieve the same goal. Middle button click opens a new tab while inside tabbed and a new window in case surf is not embedded. Also, ctrl-middle-click forces new window. Regards -- Carlos surf-r

[dev] [surf] [patch] Copy link location to primary selection

2012-10-12 Thread Carlos Pita
Makes "copy link location" item in context menu to feed the primary selection so then you can just middle-click to paste as usual. Regards -- Carlos surf-r246-primsel.diff Description: Binary data

Re: [dev] [surf] zero percent in title bug

2012-10-12 Thread Carlos Pita
>>> c->progress = 100; // <--- previously = 0 >> >> Could you please send patches instead of complex inline gibberish? Sorry, it was just 1 LOC and I wasn't even sure that the fix was the right one. Here is the patch. Regards -- Carlos surf-r246-0progress.diff Description: B

[dev] [tabbed] [patch] fix title encoding issues

2012-10-12 Thread Carlos Pita
Using a locale and font configuration that works fine for dwm and dmenu (LANG=en_US.UTF-8, font=-*-terminus-medium-r-*-*-14-*-*-*-*-*-iso8859-1) I have found some encoding issues in the titles shown by tabbed (both for embedded surf and urxvt instances) when they include latin1 characters above the

Re: [dev] [tabbed] [patch] fix title encoding issues

2012-10-12 Thread Christoph Lohmann
Greetings. On Sat, 13 Oct 2012 07:16:28 +0200 Carlos Pita wrote: > Using a locale and font configuration that works fine for dwm and > dmenu (LANG=en_US.UTF-8, > font=-*-terminus-medium-r-*-*-14-*-*-*-*-*-iso8859-1) I have found > some encoding issues in the titles shown by tabbed (both for embed

Re: [dev] [surf] [patch] Middle click to open new tab/window (C version)

2012-10-12 Thread Christoph Lohmann
Greetings. On Sat, 13 Oct 2012 07:17:05 +0200 Carlos Pita wrote: > Hi, > > experiencing problems in some pages with the "middle click links" js > script I wrote this patch to achieve the same goal. Middle button > click opens a new tab while inside tabbed and a new window in case > surf is not e

Re: [dev] [surf] zero percent in title bug

2012-10-12 Thread Christoph Lohmann
Greetings. On Sat, 13 Oct 2012 07:18:23 +0200 Alexander Sedov wrote: > 2012/10/12 Christoph Lohmann <2...@r-36.net>: > > Greetings. > > > > On Fri, 12 Oct 2012 19:42:11 +0200 Carlos Pita > > wrote: > >> Hi, > >> > >> I found this patch for the bug but I don't think it's right to just > >> hide