Re: [dev] [dwm] code cleanup

2011-07-27 Thread garbeam
Hi, On 27 July 2011 00:23, anonymous wrote: > Fixed patch attached. Thanks, applied. --garbeam

Re: [dev] [dwm] code cleanup

2011-07-26 Thread anonymous
On Tue, Jul 26, 2011 at 11:54:14PM +0200, Peter Hartlich wrote: > Hi, > > > void > > grabkeys(void) { > > + unsigned int i, j; > > + unsigned int modifiers[] = { 0, LockMask, numlockmask, > > numlockmask|LockMask }; > > + KeyCode code; > > + > > updatenumlockmask(); > > - { > > -

Re: [dev] [dwm] code cleanup

2011-07-26 Thread Peter Hartlich
Hi, > void > grabkeys(void) { > + unsigned int i, j; > + unsigned int modifiers[] = { 0, LockMask, numlockmask, > numlockmask|LockMask }; > + KeyCode code; > + > updatenumlockmask(); > - { > - unsigned int i, j; > - unsigned int modifiers[] = { 0, L

Re: [dev] [dwm] code cleanup

2011-07-26 Thread Lukas Fleischer
On Tue, Jul 26, 2011 at 11:16:30PM +0400, anonymous wrote: > Style fixes, removed > > missing = NULL; > > line. XCreateFontSet do it for you at the beginning of function [1]. > Added missing blank line, still 5 lines removed. > > dwm page [2] says "dwm is only a single binary, and its sou

Re: [dev] [dwm] code cleanup

2011-07-26 Thread anonymous
Forgot to attach. diff -r 701f651eaecc dwm.c --- a/dwm.c Sun Jul 24 10:41:43 2011 +0100 +++ b/dwm.c Tue Jul 26 21:58:41 2011 +0300 @@ -433,9 +433,9 @@ } if(ev->window == selmon->barwin) { i = x = 0; - do { + do

[dev] [dwm] code cleanup

2011-07-26 Thread anonymous
Style fixes, removed missing = NULL; line. XCreateFontSet do it for you at the beginning of function [1]. Added missing blank line, still 5 lines removed. dwm page [2] says "dwm is only a single binary, and its source code is intended to never exceed 2000 SLOC". wc -l says there are 20