Re: [dev] [PATCH] Add compatibility for OpenBSD in tar

2013-07-19 Thread Galos, David
>> If we are going to use only in this file then maybe is better use the >> snprintf >> directly. > > +1 - that makes more sense. Then, that is what we'll do. Also, sin, I'm looking over your patches, and I'll try to add them tonight.

Re: [dev] [PATCH] Add compatibility for OpenBSD in tar

2013-07-19 Thread sin
On Fri, Jul 19, 2013 at 04:29:23PM +0200, Roberto E. Vargas Caballero wrote: > On Fri, Jul 19, 2013 at 09:19:41AM -0400, Galos, David wrote: > > > OpenBSD defines strlcpy function, and the declaration is a bit different > > > of the static declartion found in tar.c. The duplication of symbol name >

Re: [dev] [PATCH] Add compatibility for OpenBSD in tar

2013-07-19 Thread Roberto E. Vargas Caballero
On Fri, Jul 19, 2013 at 09:19:41AM -0400, Galos, David wrote: > > OpenBSD defines strlcpy function, and the declaration is a bit different > > of the static declartion found in tar.c. The duplication of symbol name > > with different type (one extern and other static, one returning int and > > the

Re: [dev] [PATCH] Add compatibility for OpenBSD in tar

2013-07-19 Thread Galos, David
> OpenBSD defines strlcpy function, and the declaration is a bit different > of the static declartion found in tar.c. The duplication of symbol name > with different type (one extern and other static, one returning int and > the other returning size_t) caused tar couldn't compile in OpenBSD. Since

[dev] [PATCH] Add compatibility for OpenBSD in tar

2013-07-18 Thread Roberto E. Vargas Caballero
From: "Roberto E. Vargas Caballero" OpenBSD defines strlcpy function, and the declaration is a bit different of the static declartion found in tar.c. The duplication of symbol name with different type (one extern and other static, one returning int and the other returning size_t) caused tar could